Log HTTP responses with correct severity and include status reason (#1251)

* Log non-2xx HTTP responses in request completion log

* fix log message
This commit is contained in:
Ophir LOJKINE
2026-03-17 11:35:51 +01:00
committed by GitHub
parent e9762528e1
commit db91902d49
+8 -4
View File
@@ -371,13 +371,17 @@ impl RootSpanBuilder for SqlPageRootSpanBuilder {
DefaultRootSpanBuilder::on_request_end(span, outcome);
// Emit a single log event per completed request so it appears in logs.
// Error responses (4xx/5xx) are already logged by our error handlers.
let _enter = span_ref.enter();
if let Ok(response) = outcome {
let status = response.response().status();
if status.is_success() || status.is_redirection() {
log::info!("{}", status.canonical_reason().unwrap_or("ok"));
}
let level = if status.is_server_error() {
log::Level::Error
} else if status.is_client_error() {
log::Level::Warn
} else {
log::Level::Info
};
log::log!(level, "{status}");
}
}
}