From db91902d49bb5c6842aadc838efc1965dcbbcbb7 Mon Sep 17 00:00:00 2001 From: Ophir LOJKINE Date: Tue, 17 Mar 2026 11:35:51 +0100 Subject: [PATCH] Log HTTP responses with correct severity and include status reason (#1251) * Log non-2xx HTTP responses in request completion log * fix log message --- src/webserver/http.rs | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/webserver/http.rs b/src/webserver/http.rs index 1d0e31e7..7dc4d42d 100644 --- a/src/webserver/http.rs +++ b/src/webserver/http.rs @@ -371,13 +371,17 @@ impl RootSpanBuilder for SqlPageRootSpanBuilder { DefaultRootSpanBuilder::on_request_end(span, outcome); // Emit a single log event per completed request so it appears in logs. - // Error responses (4xx/5xx) are already logged by our error handlers. let _enter = span_ref.enter(); if let Ok(response) = outcome { let status = response.response().status(); - if status.is_success() || status.is_redirection() { - log::info!("{}", status.canonical_reason().unwrap_or("ok")); - } + let level = if status.is_server_error() { + log::Level::Error + } else if status.is_client_error() { + log::Level::Warn + } else { + log::Level::Info + }; + log::log!(level, "{status}"); } } }