github-featured/webmin--webmin
2
0
Fork 0
Code Issues Pull Requests Deployments Models Agent Notes Packages Projects Releases Wiki Activity

Don't print hidden opener table if no content in it

Browse Source 
Previously, when you chosen Google Authenticator, empty extra row was inserted in UI, making it look if something goes wrong.
This commit is contained in:
Ilia Rostovtsev
2019-04-08 12:51:14 +03:00
committed by GitHub
parent b77a782f0b
commit e30b793c3d
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
webmin/edit_twofactor.cgi
+5 -7
View File
@@ -20,7 +20,7 @@ print "<script>\n";
print "function show_prov(name) {\n";
foreach $p (@provs) {
print "d = document.getElementById(\"hiddendiv_$p->[0]\");\n";
print "d.className = name == \"$p->[0]\" ? \"opener_shown\" : \"opener_hidden\";\n";
print "d && (d.className = name == \"$p->[0]\" ? \"opener_shown\" : \"opener_hidden\");\n";
}
print "}\n";
print "</script>\n";
@@ -36,15 +36,13 @@ print ui_table_row($text{'twofactor_provider'},
1, 0, 0, 0, "onChange='show_prov(value)'"), undef, [ "valign=middle","valign=middle" ]);
foreach $p (@provs) {
$dis = $p->[0] eq $miniserv{'twofactor_provider'} ? "opener_shown"
: "opener_hidden";
print &ui_hidden_table_row_start(undef, $p->[0],
$p->[0] eq $miniserv{'twofactor_provider'}, undef);
$sfunc = "show_twofactor_apikey_".$p->[0];
my $sfunc = "show_twofactor_apikey_".$p->[0];
if (defined(&$sfunc)) {
print &ui_hidden_table_row_start(undef, $p->[0],
$p->[0] eq $miniserv{'twofactor_provider'}, undef);
print &$sfunc(\%miniserv);
print &ui_hidden_table_row_end($p->[0]);
}
print &ui_hidden_table_row_end($p->[0]);
}
print ui_table_end();