fix(ci): use Node 24 for TypeScript builds

This commit is contained in:
Chris Tate
2026-08-17 22:21:48 -05:00
parent 313f83687f
commit 0319079c9d
2 changed files with 12 additions and 8 deletions
+7 -7
View File
@@ -20,7 +20,7 @@ jobs:
version: 0.16.0
- uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24
# TypeScript cores compile through the external core compiler at
# build/test time; the compiler and the frontend's toolchain both
# arrive with this one install (without it the ts-core suites skip
@@ -44,7 +44,7 @@ jobs:
version: 0.16.0
- uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24
# The exact-pinned external core compiler and the frontend's
# toolchain, one install (packages/core/package.json is the one
# place the pin lives).
@@ -65,7 +65,7 @@ jobs:
version: 0.16.0
- uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24
# gpu-components is a TypeScript-core app, so its smoke build needs
# the frontend compiler and exact-pinned TypeScript toolchain.
- run: npm ci --prefix packages/core
@@ -184,7 +184,7 @@ jobs:
version: 0.16.0
- uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24
# The TypeScript core suites compile through the external core
# compiler at build/test time; without the install they skip
# silently, so CI must provide it.
@@ -224,7 +224,7 @@ jobs:
version: 0.16.0
- uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24
# The TypeScript examples compile through the external core
# compiler at build time; the compiler and the frontend toolchain
# arrive with this install.
@@ -358,7 +358,7 @@ jobs:
version: 0.16.0
- uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24
# The scaffold default is the TypeScript core; its frontend and
# compiler run at build time from this checkout's packages/core.
- run: npm ci --prefix packages/core
@@ -463,7 +463,7 @@ jobs:
version: 0.16.0
- uses: actions/setup-node@v4
with:
node-version: 22
node-version: 24
# The default scaffold is a TypeScript core: its build runs the
# @native-sdk/core frontend and the external core compiler from
# this checkout's own install.
+5 -1
View File
@@ -1158,7 +1158,7 @@ fn nativeCiYaml(allocator: std.mem.Allocator, names: TemplateNames, framework_pa
const node_setup =
\\ - uses: actions/setup-node@v4
\\ with:
\\ node-version: 22
\\ node-version: 24
\\
;
const compiler_install =
@@ -4531,6 +4531,10 @@ test "writeDefaultApp --full ts-core emits a CI workflow with the node tier" {
// frontend + compiler install inside the fetched SDK's packages/core,
// in BOTH jobs (each builds the app, so each compiles the core).
try std.testing.expect(std.mem.indexOf(u8, ci_yaml_text, "actions/setup-node@v4") != null);
const node_24 = "node-version: 24";
const first_node = std.mem.indexOf(u8, ci_yaml_text, node_24).?;
try std.testing.expect(std.mem.indexOf(u8, ci_yaml_text[first_node + node_24.len ..], node_24) != null);
try std.testing.expect(std.mem.indexOf(u8, ci_yaml_text, "node-version: 22") == null);
const npm_ci = "npm ci --prefix \"$NATIVE_SDK_PATH/packages/core\"";
const first = std.mem.indexOf(u8, ci_yaml_text, npm_ci).?;
try std.testing.expect(std.mem.indexOf(u8, ci_yaml_text[first + npm_ci.len ..], npm_ci) != null);