Eric Allam
936bddf198
## Summary - Upgrades Node.js from 20.19.0 to 20.20.0 (and 22.12.0 to 22.22.0 for supervisor) to address the async_hooks stack overflow DoS vulnerability - Adds `maxDepth` parameter (default 128) to `flattenAttributes` and `unflattenAttributes` to prevent stack overflow on maliciously deep nested structures ## Details The vulnerability (patched in Node.js 20.20.0, 22.22.0, 24.13.0, 25.3.0) causes unrecoverable crashes (exit code 7) when stack overflow occurs during async_hooks callbacks. Since the webapp uses `AsyncLocalStorage`, it was theoretically vulnerable. ### Changes **Node.js version updates:** - `docker/Dockerfile`: 20.11.1 → 20.20.0 - `apps/supervisor/Containerfile`: 22-alpine → 22.22.0-alpine - `.nvmrc`: 20.19.0 → 20.20.0 - `apps/supervisor/.nvmrc`: 22.12.0 → 22.22.0 - `references/prisma-7/.nvmrc`: 20.19.0 → 20.20.0 - All GitHub workflows: 20.19.0 → 20.20.0 **Defense in depth:** - Added `maxDepth` parameter to `flattenAttributes()` and `unflattenAttributes()` in `packages/core` to prevent stack overflow on deeply nested user input ## Test plan - [x] All existing `flattenAttributes` tests pass (50 tests) - [x] New tests for depth limiting added - [x] Verify Docker builds work with new base images
116 lines
4.9 KiB
Docker
116 lines
4.9 KiB
Docker
ARG NODE_IMAGE=node:20.20.0-bullseye-slim@sha256:f52726bba3d47831859be141b4a57d3f7b93323f8fddfbd8375386e2c3b72319
|
|
|
|
FROM golang:1.23-alpine AS goose_builder
|
|
RUN go install github.com/pressly/goose/v3/cmd/goose@latest
|
|
|
|
FROM ${NODE_IMAGE} AS pruner
|
|
|
|
WORKDIR /triggerdotdev
|
|
|
|
COPY --chown=node:node . .
|
|
RUN npx -q turbo@2.5.4 prune --scope=webapp --docker
|
|
RUN find . -name "node_modules" -type d -prune -exec rm -rf '{}' +
|
|
|
|
# Base strategy to have layer caching
|
|
FROM ${NODE_IMAGE} AS base
|
|
RUN apt-get update && apt-get install -y openssl dumb-init
|
|
WORKDIR /triggerdotdev
|
|
COPY --chown=node:node .gitignore .gitignore
|
|
COPY --from=pruner --chown=node:node /triggerdotdev/out/json/ .
|
|
COPY --from=pruner --chown=node:node /triggerdotdev/out/pnpm-lock.yaml ./pnpm-lock.yaml
|
|
COPY --from=pruner --chown=node:node /triggerdotdev/out/pnpm-workspace.yaml ./pnpm-workspace.yaml
|
|
COPY --chown=node:node patches ./patches
|
|
|
|
## Dev deps
|
|
FROM base AS dev-deps
|
|
WORKDIR /triggerdotdev
|
|
# Corepack is used to install pnpm with the exact version from packageManager
|
|
RUN corepack enable && corepack prepare pnpm@10.23.0 --activate
|
|
ENV NODE_ENV=development
|
|
RUN --mount=type=cache,id=pnpm,target=/root/.local/share/pnpm/store pnpm install --no-frozen-lockfile
|
|
# Generate Prisma client here where all deps are installed
|
|
COPY --from=pruner --chown=node:node /triggerdotdev/internal-packages/database/prisma/schema.prisma /triggerdotdev/internal-packages/database/prisma/schema.prisma
|
|
RUN pnpx prisma@6.14.0 generate --schema /triggerdotdev/internal-packages/database/prisma/schema.prisma
|
|
|
|
## Production deps
|
|
FROM base AS production-deps
|
|
WORKDIR /triggerdotdev
|
|
# Corepack is used to install pnpm with the exact version from packageManager
|
|
RUN corepack enable && corepack prepare pnpm@10.23.0 --activate
|
|
ENV NODE_ENV=production
|
|
RUN --mount=type=cache,id=pnpm,target=/root/.local/share/pnpm/store pnpm install --prod --no-frozen-lockfile
|
|
|
|
## Builder (builds the webapp)
|
|
FROM base AS builder
|
|
# This is needed for the sentry-cli binary while building the webapp
|
|
RUN apt-get update && apt-get install -y openssl dumb-init ca-certificates
|
|
WORKDIR /triggerdotdev
|
|
# Corepack is used to install pnpm with the exact version from packageManager
|
|
RUN corepack enable && corepack prepare pnpm@10.23.0 --activate
|
|
|
|
ARG SENTRY_RELEASE
|
|
ARG SENTRY_ORG
|
|
ARG SENTRY_PROJECT
|
|
ENV SENTRY_RELEASE=${SENTRY_RELEASE} \
|
|
SENTRY_ORG=${SENTRY_ORG} \
|
|
SENTRY_PROJECT=${SENTRY_PROJECT}
|
|
|
|
# Goose and schemas
|
|
COPY --from=goose_builder /go/bin/goose /usr/local/bin/goose
|
|
RUN chmod +x /usr/local/bin/goose
|
|
COPY --chown=node:node internal-packages/clickhouse/schema /triggerdotdev/internal-packages/clickhouse/schema
|
|
|
|
COPY --from=pruner --chown=node:node /triggerdotdev/out/full/ .
|
|
COPY --from=dev-deps --chown=node:node /triggerdotdev/ .
|
|
COPY --chown=node:node turbo.json turbo.json
|
|
COPY --chown=node:node docker/scripts ./scripts
|
|
RUN chmod +x ./scripts/wait-for-it.sh
|
|
RUN chmod +x ./scripts/entrypoint.sh
|
|
COPY --chown=node:node .configs/tsconfig.base.json .configs/tsconfig.base.json
|
|
COPY --chown=node:node scripts/updateVersion.ts scripts/updateVersion.ts
|
|
RUN pnpm run generate
|
|
RUN --mount=type=secret,id=sentry_auth_token \
|
|
SENTRY_AUTH_TOKEN=$(cat /run/secrets/sentry_auth_token) \
|
|
pnpm run build --filter=webapp...
|
|
|
|
# Runner
|
|
FROM ${NODE_IMAGE} AS runner
|
|
RUN apt-get update && apt-get install -y openssl netcat-openbsd ca-certificates
|
|
WORKDIR /triggerdotdev
|
|
ENV NODE_ENV=production
|
|
|
|
COPY --from=base /usr/bin/dumb-init /usr/bin/dumb-init
|
|
COPY --from=pruner --chown=node:node /triggerdotdev/out/full/ .
|
|
COPY --from=production-deps --chown=node:node /triggerdotdev .
|
|
# Copy generated Prisma client from dev-deps
|
|
COPY --from=dev-deps --chown=node:node /triggerdotdev/internal-packages/database/generated ./internal-packages/database/generated
|
|
COPY --from=builder --chown=node:node /triggerdotdev/apps/webapp/build/server.js ./apps/webapp/build/server.js
|
|
COPY --from=builder --chown=node:node /triggerdotdev/apps/webapp/build ./apps/webapp/build
|
|
COPY --from=builder --chown=node:node /triggerdotdev/apps/webapp/public ./apps/webapp/public
|
|
COPY --from=builder --chown=node:node /triggerdotdev/scripts ./scripts
|
|
|
|
# Goose and schemas
|
|
COPY --from=builder /usr/local/bin/goose /usr/local/bin/goose
|
|
COPY --from=builder --chown=node:node /triggerdotdev/internal-packages/clickhouse/schema /triggerdotdev/internal-packages/clickhouse/schema
|
|
|
|
# Build info
|
|
ARG BUILD_APP_VERSION
|
|
ARG BUILD_GIT_SHA
|
|
ARG BUILD_GIT_REF_NAME
|
|
ARG BUILD_TIMESTAMP_SECONDS
|
|
ENV BUILD_APP_VERSION=${BUILD_APP_VERSION} \
|
|
BUILD_GIT_SHA=${BUILD_GIT_SHA} \
|
|
BUILD_GIT_REF_NAME=${BUILD_GIT_REF_NAME} \
|
|
BUILD_TIMESTAMP_SECONDS=${BUILD_TIMESTAMP_SECONDS}
|
|
|
|
EXPOSE 3000
|
|
|
|
# Add global pnpm shims and install pnpm during build (root user)
|
|
RUN corepack enable && corepack prepare pnpm@10.23.0 --activate
|
|
|
|
USER node
|
|
|
|
# Ensure pnpm is installed during build and not silently downloaded at runtime (node user)
|
|
RUN corepack prepare pnpm@10.23.0 --activate
|
|
|
|
CMD ["./scripts/entrypoint.sh"] |