Commit Graph

8292 Commits

Author SHA1 Message Date
Katia Bulatova a09d8a86fa fix(webapp): key a repeated view block by its own position
ViewBlocks looked each surviving block's index up with indexOf inside the render
loop: quadratic, and two occurrences of the same block object both answered with
the first index, so they collided on one React key. latestRevisionEntries carries
each survivor's position out instead.
2026-08-09 14:47:20 +00:00
Katia Bulatova e8c43e4f43 fix(webapp): time the report sparkline's bars from the report, not the reader's clock
Bar timestamps came from Date.now() during render, so the same bar reported a
different time on every re-render and a server pass disagreed with the client.
They now come from the view model's generatedAt, which the schema already
describes as the timestamp the renderer must not invent.

Moves the arithmetic into report-spark.ts to keep it clock-free and testable,
and drops the unreachable Math.max on the slice end while doing so.
2026-08-09 14:47:18 +00:00
Katia Bulatova 2c7575fa86 docs(webapp): say who Cmd-I actually opens the agent for 2026-08-09 14:47:17 +00:00
Katia Bulatova 466ed7d0fd fix(webapp): stop the agent's retry duplicating the failed message
Retry appended the last user message again, so the failed turn stayed in the
transcript and its text was sent twice. It now regenerates once the agent has
started answering, and otherwise re-sends the failed turn under its own id.
2026-08-09 14:47:15 +00:00
Katia Bulatova 4472339a05 fix(webapp): stop a zero-limit queue reading as at capacity
A limit of 0 is zero capacity, not saturation: running >= 0 holds for every
queue, so any backlog marked the queue degraded and offered Investigate, while
the agent's own suggested prompt stayed silent. One predicate now decides it
for the queue detail page, the queues list badge and the page mappers.
2026-08-09 14:47:13 +00:00
Katia Bulatova db578e0e19 fix(webapp): give icon-only tooltip buttons an accessible name
Radix tooltip content is not the accessible name of its trigger, so the
icon-only ask-agent button and the two deploy docs links announced as
unnamed controls. Name them explicitly and pass asChild so the tooltip
trigger stops wrapping them in a second button.

Adds a source scan that fails on the next SimpleTooltip with an unnamed
or double-wrapped control, with the pre-existing sites baselined.
2026-08-09 14:47:11 +00:00
Katia Bulatova 8c682da36a perf(webapp): keep report blocks out of the investigation winner pass 2026-08-09 14:47:10 +00:00
Katia Bulatova 4e278722f4 docs: say where the docs went now the header button is gone 2026-08-09 14:47:08 +00:00
Katia Bulatova e73112d88c fix(webapp): keep an empty chat open instead of showing a new one
Selecting a stored chat with no messages dropped you into a fresh draft,
as if the chat had been deleted.
2026-08-09 14:47:07 +00:00
Katia Bulatova 4db8ab32a5 fix(webapp): stop Cmd-J opening Chrome's downloads
Shortcuts can now ask for the browser default to be prevented, and the
agent's keystroke does.
2026-08-09 14:47:05 +00:00
Katia Bulatova 9acbcbfd79 fix(webapp): drop a run diagnosis action that has nowhere to go
Without org/project/env context the run button rendered but did nothing.
2026-08-09 14:47:02 +00:00
Katia Bulatova a447e868bd fix(webapp): give each copyable task snippet its own SDK import
The scheduled example lost its import line to the standard one, so copying
it gave code that does not compile.
2026-08-09 14:46:58 +00:00
Katia Bulatova 6120967d48 test(webapp): give the untrustworthy report fixture the reason field the pipeline emits
The fixture still set `facts.staleReason`, renamed to `untrustworthyReason` three commits
before the caveat started reading it, so the branch's only trust snapshot fell back to
"could not be verified" for a report whose reason is known.
2026-08-09 14:46:55 +00:00
Katia Bulatova ebd1b76922 feat(webapp): give Cmd-I and the CLI's help link back to Ask AI
Ask AI (Kapa) owns the two entry points it had before the dashboard agent
replaced it: Cmd-I, and the `?aiHelp=` deep link the CLI's "Get a fix for
this error using AI" line points at. `AskAIRoot` mounts in the `_app`
layout, above every signed-in page, so Cmd-I reaches it from org-level
pages too and the dialog outlives whatever opened it.

The agent no longer reads deep links at all: nothing produced its `?ask=`
param except the CLI redirect, and both readers consume the param, so a
live agent reader would always beat Kapa to it. It stays the fall-through
— where Kapa cannot open (self-hosted, or no website id), both channels
land on the agent instead of dead-ending.
2026-08-09 14:46:53 +00:00
Katia Bulatova 1d094a8c46 fix(webapp): drop Keep digging once the turn has already kept digging 2026-08-09 14:46:51 +00:00
Katia Bulatova 44cf389099 style(webapp): use the agent's own logo in the Help & Feedback entry 2026-08-09 14:46:50 +00:00
Katia Bulatova 449e9f3d88 feat(webapp): the dashboard agent's UI
The panel, the page-context marks on the pages the agent reads, and the entry points.
2026-08-09 14:46:47 +00:00
Katia Bulatova 20c8f9eb3c fix(webapp): stop an unreadable eval override reading as consent to judge
flag() ignores a per-org override that fails the schema and falls through to the global
default, which is on. For an entitlement that is right; for this flag it means an org that
tried to turn judging off with a stringified boolean kept being judged. The eval policy now
refuses on an override it cannot parse, matching what the flag's own comment already claims.
2026-08-09 14:44:59 +00:00
Katia Bulatova 9805c0adf5 fix(webapp): deny an unknown report key instead of authorizing it against every table
reportQueryTables fell back to the union of every report's tables, so a key naming no
report was checked against all of them. everyResource is a conjunction and checkAuth
denies an empty one, so that happened to be strict rather than permissive - but only by
accident, and the docstring justified it with a claim about empty lists that checkAuth
contradicts. An unknown key now declares no tables and is refused outright.
2026-08-09 14:44:56 +00:00
Katia Bulatova 0fd886c83b perf(webapp): stop the agent transcript re-rendering on every streamed token
The winners map was rebuilt on each render, so every memoized bubble saw a new
prop and re-rendered. Stripped messages were rebuilt too, so the shared
MessageBubble's own memo missed for any tool-calling message. Reuse the map when
the winners are unchanged and cache the stripped message per identity.
2026-08-09 12:11:43 +00:00
Katia Bulatova 8fd53691f3 revert(webapp): move the queue JWT read to the PR that uses it 2026-08-09 11:45:51 +00:00
Katia Bulatova 2aacd26c84 fix(webapp,dashboard-agent): keep investigation cards, and stop a broken request reading as an answer
An investigation card could vanish from a reply that contained step
separators: the winning revision was keyed by its position in the
untouched reply, while rendering walked the stripped parts. Both now
index the same stripped list.

A host-written `data-view` card counted towards winning a revision but
was never drawn as a card, so it could suppress the tool-rendered card
it competed with into nothing. Both carriers now render.

`apiGet` left `fetch` and `res.json()` unguarded, so a connection reset
threw out of the tool, and a transport failure that did land could read
as a definite 404. It now returns a transport failure the way the
sibling paths do.

Also: guard the card's Hypotheses section on length, as Evidence
already is, and move the reports auth resource out of the serializer so
rendering a report doesn't pull the route builder in.
2026-08-09 08:50:35 +00:00
Katia Bulatova d40e9fe330 chore: mark the lockfile as generated too 2026-08-09 08:15:32 +00:00
Katia Bulatova 7e272cc973 chore(webapp): drop the unused waiting-run diagnosis 2026-08-08 23:28:43 +00:00
Katia Bulatova 36691f1ac3 chore: mark drizzle and test snapshots as generated 2026-08-08 23:28:41 +00:00
Katia Bulatova c3b7c10b4c refactor(dashboard-agent): move the watch data layer into the Watch PR
The watch tables and the 0002 migration stay here, so the committed drizzle
snapshot keeps describing them. The four contract types the schema annotates
are widened here and re-narrowed where the watch code lands.
2026-08-08 23:28:37 +00:00
Katia Bulatova 8fc6f203eb style(dashboard-agent): format the two eval test files 2026-08-08 18:03:30 +00:00
Katia Bulatova 0cae30190a fix(dashboard-agent): pin the investigation cards the transcript actually holds
`collectDurableState` read `data-view` parts only, but `render_view` writes
every investigation card as a `tool-render_view` part, so compaction pinned
nothing and an open card could be summarised away.

It now resolves cards through `latestCards`, the resolver the panel and the
watch actions already use: highest revision per id wins whatever order the
renders arrive in, so a stale `in_progress` render landing after the settling
one no longer reopens a closed card. `latestCards` reads host-written
`data-view` blocks too, matching the panel.
2026-08-08 17:03:54 +00:00
Katia Bulatova ed0a7b3374 fix(dashboard-agent): stop a retrieved run's own error counting as a failed tool call in evals 2026-08-08 17:03:53 +00:00
Katia Bulatova 643ea3907f fix(dashboard-agent): read the report's untrustworthy reason under its current name
`curateReport` still read `facts.staleReason`, renamed to `untrustworthyReason`
in dc3b50260 and split into telemetry_stale / telemetry_absent / flow_unmeasured.
The read had been undefined since, so the agent got "untrustworthy" with no why,
and the prompt still told it every such case was stale telemetry.

`facts` is `z.record(z.unknown())`, so nothing typechecked the key. The new test
goes presenter -> reports route JSON -> curateReport without naming a facts key
on the way in, and asserts curation carries every key the presenter emits.
2026-08-08 17:03:53 +00:00
Katia Bulatova ad2698bdcc feat(webapp): render the cards the flows already emit
The prompt requires render_view and the schema union allows actions, investigation
and report blocks, but ViewBlocks only had cases for diagnosis and chart, so those
three rendered as an empty div. Adds the three renderers, the block-envelope
latest-wins resolution the switch keys on, and a contract test that reads the block
types off viewBlockSchema, so a new union member fails until it has a renderer.
2026-08-08 17:03:52 +00:00
Katia Bulatova 566de276fa docs: say that the agent works on branches 2026-08-08 17:02:42 +00:00
Katia Bulatova 3355b6813e fix(webapp): stop an unmeasured queue depth from silencing a measured flow finding
An unmeasurable depth made the whole flow finding unassessable, so a
critical start latency measured off runs showed as crit in format=json
while the rendered report said 'Flow unknown ... nothing to do' and
dropped the row that earned it. The depth still buys no cause, no
attribution and no drain ETA, but the measured symptom is now reported.
2026-08-08 16:23:04 +00:00
Katia Bulatova a66034930c fix(webapp): make each report caveat discount only the input it names
A missing telemetry feed said the run aggregates were a point-in-time
snapshot; they are measured over the window either way, and what is
actually unknown is how current they are. An unmeasured queue depth
blamed throughput, which the report does measure, and contradicted its
own headline. Tests pin the claim rather than the wording.
2026-08-08 16:23:03 +00:00
Katia Bulatova d0f06d5c5e fix(webapp,dashboard-agent): address a branch environment by name and branch
The agent could not read anything on a preview or dev branch. Its environment name
is derived from the environment's type, and every branch shares its parent's type —
so the name identifies a family, not a row. The API's env routes are name-addressed,
so a bare "preview" or "dev" resolved to the parent, and the delegated token's
`environmentId` claim then correctly refused it. The guard was the detector, not the
defect: the exchange was never given enough identity to resolve the environment the
dashboard had selected.

Name and branch are now resolved together into one address, so no caller can take
the name without the branch, and both mint sites share the one type map instead of
keeping a copy each. The address travels to the JWT exchange and to the three
delegated-token reads that resolve by name (list_tasks, correlate_version, the repo
snapshot). The env-JWT reads address the environment by id and are untouched.

Second, and why nobody saw the first: the exchange reported the same "no
environment" for a genuine absence and for any failure, and cached the failure for
the whole turn. Following the queue live-read precedent, only a missing environment
is stated as one; anything else says the read didn't land and carries its status.
2026-08-08 16:21:48 +00:00
Katia Bulatova a4ba0271b0 fix(webapp): refuse a delegated token at the entrance of the PAT-only auth helper
The helper checks no scopes and no capability context, so a read-only user-actor token
reached an alert-channel write and every admin route behind requireAdminApiRequest.
Actor-aware routes are unaffected: they authenticate the token through the route
builders, which enforce its claims.
2026-08-08 16:19:12 +00:00
Katia Bulatova 314a1d795d perf(webapp): skip the global feature-flag query when a per-org override resolves
flag() queried the FeatureFlag row before looking at the caller-supplied overrides, so a
per-org hit still paid a round-trip. Check the override first and only fall through to the
query when it fails the schema, which keeps today's resolution order intact.
2026-08-08 13:59:06 +00:00
Katia Bulatova c3f0d62d62 fix(webapp): undo a new agent chat only when its start never got anywhere
A start that rejects dispatched no handover and sent no message, so the chat
row is taken back. A failed access-token mint is left alone: the session is
live by then and removing the chat would hide a running agent.
2026-08-08 13:46:01 +00:00
Katia Bulatova 14d70bef9a docs(webapp): say that the agent is off until a flag turns it on 2026-08-08 13:45:53 +00:00
Katia Bulatova f6afda3d84 docs(dashboard-agent): say what the queue path encoding is for 2026-08-08 13:37:18 +00:00
Katia Bulatova e2704eaa84 fix(webapp): keep identityOnly off action routes in the type
identityOnly waives the contextless refusal, which is only sound for reads.
The action options intersected the loader options, so the type allowed it.
2026-08-08 11:52:37 +00:00
Katia Bulatova de4cdad61b fix(webapp): list the preview branch an agent token is scoped to
A token signed for a branch child listed nothing: the scope filter and the
base-environments-only filter could never hold together. Unscoped callers
still see base environments only.
2026-08-08 11:52:36 +00:00
Katia Bulatova b38c5186ac fix(webapp): stop a failed agent chat start leaving an empty chat behind
The environment lookup, repo lookup and token mint now all run before the chat
row is created, so a 404 or a mint failure can't orphan a chat in the history.
2026-08-08 11:52:35 +00:00
Katia Bulatova f598f96142 fix(webapp): refuse a dashboard agent turn whose token mint failed
The catch around the turn body tolerated a JSON.parse failure, but it also
swallowed a rejected mint and forwarded the turn with no credential.
2026-08-08 11:52:34 +00:00
Katia Bulatova aa55227b84 fix(cli): say that a capless mint-token is read-only 2026-08-08 09:22:49 +00:00
Katia Bulatova 4c422300c8 fix(webapp): stop treating a ClickHouse unknown identifier as a rollout gap 2026-08-08 09:22:48 +00:00
Katia Bulatova d0be659457 test(webapp): assert the queue depth trend fills its bucket grid 2026-08-08 09:22:47 +00:00
Katia Bulatova 0db1cf0d23 fix(webapp): say why a report's numbers can't be trusted
Absent telemetry and an unmeasured flow were both labelled stale data, so every
snapshot-based report claimed staleness it could not have measured. Choose the
badge and caveat from the reason instead.
2026-08-08 08:29:47 +00:00
Katia Bulatova 1ee6704d53 fix(webapp): describe how far a report metric fell
A fall's multiplier rounds to 0 or 1, so every drop rendered as "flat" — a metric
that collapsed from 100 to 5 read as unchanged. Measure the fall against the
baseline instead, and show a bare arrow when it collapsed to nothing.
2026-08-08 08:29:46 +00:00
Katia Bulatova 05505d5741 fix(webapp): carry a queue's depth forward across empty buckets
The per-queue metrics route mapped ClickHouse rows straight to an array, so a
bucket with no sample shortened the trend and shifted every later point in time.
Fill a fixed-width grid the way the two sibling callers do.
2026-08-08 08:29:46 +00:00