Cleanup run-store entries when chat streams finish

Co-authored-by: Eric Allam <eric@trigger.dev>
This commit is contained in:
Cursor Agent
2026-02-14 23:37:19 +00:00
parent cf1b5c7ffe
commit b51156664d
2 changed files with 72 additions and 0 deletions
+70
View File
@@ -338,6 +338,67 @@ describe("TriggerChatTransport", function () {
expect(observedRunId).toBe("run_factory");
});
it("cleans run store state when stream completes", async function () {
const trackedRunStore = new TrackedRunStore();
const server = await startServer(function (req, res) {
if (req.method === "POST" && req.url === "/api/v1/tasks/chat-task/trigger") {
res.writeHead(200, {
"content-type": "application/json",
"x-trigger-jwt": "pk_run_cleanup",
});
res.end(JSON.stringify({ id: "run_cleanup" }));
return;
}
if (req.method === "GET" && req.url === "/realtime/v1/streams/run_cleanup/chat-stream") {
res.writeHead(200, {
"content-type": "text/event-stream",
});
writeSSE(
res,
"1-0",
JSON.stringify({ type: "text-start", id: "cleanup_1" })
);
writeSSE(
res,
"2-0",
JSON.stringify({ type: "text-end", id: "cleanup_1" })
);
res.end();
return;
}
res.writeHead(404);
res.end();
});
const transport = new TriggerChatTransport({
task: "chat-task",
stream: "chat-stream",
accessToken: "pk_trigger",
baseURL: server.url,
runStore: trackedRunStore,
});
const stream = await transport.sendMessages({
trigger: "submit-message",
chatId: "chat-cleanup",
messageId: undefined,
messages: [],
abortSignal: undefined,
});
const chunks = await readChunks(stream);
expect(chunks).toHaveLength(2);
await waitForCondition(function () {
return trackedRunStore.deleteCalls.includes("chat-cleanup");
});
expect(trackedRunStore.get("chat-cleanup")).toBeUndefined();
});
it("reconnects active streams using tracked lastEventId", async function () {
let reconnectLastEventId: string | undefined;
let firstStreamResponse: ServerResponse<IncomingMessage> | undefined;
@@ -528,3 +589,12 @@ async function waitForCondition(condition: () => boolean, timeoutInMs = 5000) {
throw new Error(`Condition was not met within ${timeoutInMs}ms`);
}
class TrackedRunStore extends InMemoryTriggerChatRunStore {
public readonly deleteCalls: string[] = [];
public delete(chatId: string): void {
this.deleteCalls.push(chatId);
super.delete(chatId);
}
}
+2
View File
@@ -269,12 +269,14 @@ export class TriggerChatTransport<
if (runState) {
runState.isActive = false;
await this.runStore.set(runState);
await this.runStore.delete(chatId);
}
} catch {
const runState = await this.runStore.get(chatId);
if (runState) {
runState.isActive = false;
await this.runStore.set(runState);
await this.runStore.delete(chatId);
}
}
}