github-featured/triggerdotdev--trigger.dev
2
0
Fork 0
Code Issues Pull Requests Deployments Models Agent Notes Packages Projects Releases Wiki Activity

Standardize @types/node to version 20.14.14 across monorepo (#2970)

Browse Source 
## ✅ Checklist

- [ ] I have followed every step in the [contributing
guide](https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md)
- [ ] The PR title follows the convention.
- [ ] I ran and tested the code works

---

## Description

This PR standardizes the `@types/node` dependency across the entire
monorepo to version `20.14.14`. Previously, different packages were
using different versions (ranging from 12.20.55 to 22.13.9), which could
cause type conflicts and inconsistencies.

### Changes Made

1. **tsconfig.json** - Added `"node"` to the `types` array in
`apps/webapp/tsconfig.json` to ensure Node.js types are properly
recognized
2. **package.json overrides** - Added `@types/node` version override to
`20.14.14` in the root `package.json`
3. **pnpm-lock.yaml** - Updated lock file to reflect the standardized
version across all packages and their dependencies
4. **Fixture package.json** - Updated
`packages/cli-v3/e2e/fixtures/emit-decorator-metadata/package.json` to
use the standardized version

This ensures consistent type definitions across the monorepo and
prevents version mismatches that could lead to type errors or unexpected
behavior.

---

## Testing

- Verified that all package references to `@types/node` now point to
version `20.14.14`
- Confirmed that the lock file properly reflects the override across all
transitive dependencies
- Ensured TypeScript configuration includes Node.js types for proper
type checking

---

## Changelog

- Standardized `@types/node` to version `20.14.14` across all packages
in the monorepo
- Added `"node"` to TypeScript compiler types in webapp configuration
- Updated all package dependencies to use the consistent version through
pnpm overrides

💯

https://claude.ai/code/session_018eqp2LvvErkFSN9oK5xBh1
<!-- devin-review-badge-begin -->

---

<a
href="https://app.devin.ai/review/triggerdotdev/trigger.dev/pull/2970">
  <picture>
<source media="(prefers-color-scheme: dark)"
srcset="https://static.devin.ai/assets/gh-open-in-devin-review-dark.svg?v=1">
<img
src="https://static.devin.ai/assets/gh-open-in-devin-review-light.svg?v=1"
alt="Open with Devin">
  </picture>
</a>
<!-- devin-review-badge-end -->

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: Eric Allam <ericallam@users.noreply.github.com>
This commit is contained in:
Eric Allam
2026-01-30 09:15:35 +00:00
committed by GitHub
parent 3925f8cc49
commit 9937823a7f
3 changed files with 46 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/webapp/tsconfig.json
+1 -1
View File
@@ -2,7 +2,7 @@
"exclude": ["./cypress", "./cypress.config.ts"],
"include": ["remix.env.d.ts", "global.d.ts", "**/*.ts", "**/*.tsx"],
"compilerOptions": {
"types": ["vitest/globals"],
"types": ["vitest/globals", "node"],
"lib": ["DOM", "DOM.Iterable", "DOM.AsyncIterable", "ES2020"],
"isolatedModules": true,
"esModuleInterop": true,
package.json
+1
View File
@@ -85,6 +85,7 @@
},
"overrides": {
"typescript": "5.5.4",
"@types/node": "20.14.14",
"express@^4>body-parser": "1.20.3",
"@remix-run/dev@2.1.0>tar-fs": "2.1.3",
"testcontainers@10.28.0>tar-fs": "3.0.9",
pnpm-lock.yaml
Generated
+44 -81
View File
@@ -6,6 +6,7 @@ settings:
overrides:
typescript: 5.5.4
'@types/node': 20.14.14
express@^4>body-parser: 1.20.3
'@remix-run/dev@2.1.0>tar-fs': 2.1.3
testcontainers@10.28.0>tar-fs: 3.0.9
@@ -814,7 +815,7 @@ importers:
version: link:../../internal-packages/testcontainers
'@remix-run/dev':
specifier: 2.1.0
version: 2.1.0(@remix-run/serve@2.1.0(typescript@5.5.4))(@types/node@22.13.9)(bufferutil@4.0.9)(encoding@0.1.13)(lightningcss@1.29.2)(terser@5.44.1)(typescript@5.5.4)
version: 2.1.0(@remix-run/serve@2.1.0(typescript@5.5.4))(@types/node@20.14.14)(bufferutil@4.0.9)(encoding@0.1.13)(lightningcss@1.29.2)(terser@5.44.1)(typescript@5.5.4)
'@remix-run/eslint-config':
specifier: 2.1.0
version: 2.1.0(eslint@8.31.0)(react@18.2.0)(typescript@5.5.4)
@@ -1091,7 +1092,7 @@ importers:
version: 18.3.1
react-email:
specifier: ^2.1.1
version: 2.1.2(@opentelemetry/api@1.9.0)(@swc/helpers@0.5.15)(eslint@8.31.0)
version: 2.1.2(@opentelemetry/api@1.9.0)(@swc/helpers@0.5.15)(bufferutil@4.0.9)(eslint@8.31.0)
resend:
specifier: ^3.2.0
version: 3.2.0
@@ -1119,7 +1120,7 @@ importers:
version: 7.3.2
devDependencies:
'@types/node':
specifier: ^20
specifier: 20.14.14
version: 20.14.14
rimraf:
specifier: ^3.0.2
@@ -1949,7 +1950,7 @@ importers:
specifier: workspace:^4.3.3
version: link:../build
'@types/node':
specifier: ^20.14.14
specifier: 20.14.14
version: 20.14.14
'@types/react':
specifier: '*'
@@ -2211,7 +2212,7 @@ importers:
specifier: ^4.0.3
version: 4.0.8
'@types/node':
specifier: ^20
specifier: 20.14.14
version: 20.14.14
'@types/react':
specifier: ^19
@@ -2293,7 +2294,7 @@ importers:
specifier: workspace:*
version: link:../../packages/build
'@types/node':
specifier: ^20
specifier: 20.14.14
version: 20.14.14
'@types/react':
specifier: ^19
@@ -2674,7 +2675,7 @@ importers:
specifier: ^4
version: 4.0.17
'@types/node':
specifier: ^20
specifier: 20.14.14
version: 20.14.14
'@types/react':
specifier: ^19
@@ -2729,7 +2730,7 @@ importers:
specifier: ^4
version: 4.0.17
'@types/node':
specifier: ^20
specifier: 20.14.14
version: 20.14.14
'@types/react':
specifier: ^19
@@ -2791,7 +2792,7 @@ importers:
version: link:../../packages/trigger-sdk
devDependencies:
'@types/node':
specifier: ^20
specifier: 20.14.14
version: 20.14.14
trigger.dev:
specifier: workspace:*
@@ -10782,24 +10783,9 @@ packages:
'@types/node-fetch@2.6.4':
resolution: {integrity: sha512-1ZX9fcN4Rvkvgv4E6PAY5WXUFWFcRWxZa3EW83UjycOB9ljJCedb2CupIP4RZMEwF/M3eTcCihbBRgwtGbg5Rg==}
'@types/node@12.20.55':
resolution: {integrity: sha512-J8xLz7q2OFulZ2cyGTLE1TbbZcjpno7FaN6zdJNrgAdrJ+DZzh/uFR6YrTb4C+nXakvud8Q4+rbhoIWlYQbUFQ==}
'@types/node@18.19.20':
resolution: {integrity: sha512-SKXZvI375jkpvAj8o+5U2518XQv76mAsixqfXiVyWyXZbVWQK25RurFovYpVIxVzul0rZoH58V/3SkEnm7s3qA==}
'@types/node@20.11.22':
resolution: {integrity: sha512-/G+IxWxma6V3E+pqK1tSl2Fo1kl41pK1yeCyDsgkF9WlVAme4j5ISYM2zR11bgLFJGLN5sVK40T4RJNuiZbEjA==}
'@types/node@20.12.14':
resolution: {integrity: sha512-scnD59RpYD91xngrQQLGkE+6UrHUPzeKZWhhjBSa3HSkwjbQc38+q3RoIVEwxQGRw3M+j5hpNAM+lgV3cVormg==}
'@types/node@20.14.14':
resolution: {integrity: sha512-d64f00982fS9YoOgJkAMolK7MN8Iq3TDdVjchbYHdEmjth/DHowx82GnoA+tVUAN+7vxfYUgAzi+JXbKNd2SDQ==}
'@types/node@22.13.9':
resolution: {integrity: sha512-acBjXdRJ3A6Pb3tqnw9HZmyR3Fiol3aGxRCK1x3d+6CDAMjl7I649wpSd+yNURCjbOUGu9tqtLKnTGxmK6CyGw==}
'@types/nodemailer@7.0.4':
resolution: {integrity: sha512-ee8fxWqOchH+Hv6MDDNNy028kwvVnLplrStm4Zf/3uHWw5zzo8FoYYeffpJtGs2wWysEumMH0ZIdMGMY1eMAow==}
@@ -19386,9 +19372,6 @@ packages:
undici-types@5.26.5:
resolution: {integrity: sha512-JlCMO+ehdEIKqlFxk6IfVoAUVmgz7cU7zD/h9XZ0qzeosSHmUJVOzSQvvYSYWXkFXC+IfLKSIffhv0sVZup6pA==}
undici-types@6.20.0:
resolution: {integrity: sha512-Ny6QZ2Nju20vw1SRHe3d9jVu6gJ+4e3+MMpqu7pqE5HT6WsTSlce++GQmK5UXS8mzV8DSYHrQH+Xrf2jVcuKNg==}
undici@5.29.0:
resolution: {integrity: sha512-raqeBD6NQK4SkWhQzeYKd1KmIG6dllBOTt55Rmkt4HtI9mwdWtJljnrXjAFUBLTSN67HWrOIZ3EPF4kjUw80Bg==}
engines: {node: '>=14.0'}
@@ -19679,7 +19662,7 @@ packages:
engines: {node: ^14.18.0 || >=16.0.0}
hasBin: true
peerDependencies:
'@types/node': '>= 14'
'@types/node': 20.14.14
less: '*'
lightningcss: ^1.21.0
sass: '*'
@@ -19707,7 +19690,7 @@ packages:
engines: {node: ^18.0.0 || >=20.0.0}
hasBin: true
peerDependencies:
'@types/node': ^18.0.0 || >=20.0.0
'@types/node': 20.14.14
less: '*'
lightningcss: ^1.21.0
sass: '*'
@@ -19740,7 +19723,7 @@ packages:
peerDependencies:
'@edge-runtime/vm': '*'
'@types/debug': ^4.1.12
'@types/node': ^18.0.0 || ^20.0.0 || >=22.0.0
'@types/node': 20.14.14
'@vitest/browser': 3.1.4
'@vitest/ui': 3.1.4
happy-dom: '*'
@@ -24104,7 +24087,7 @@ snapshots:
'@kubernetes/client-node@0.20.0(bufferutil@4.0.9)':
dependencies:
'@types/js-yaml': 4.0.9
'@types/node': 20.11.22
'@types/node': 20.14.14
'@types/request': 2.48.12
'@types/ws': 8.5.10
byline: 5.0.0
@@ -24126,7 +24109,7 @@ snapshots:
'@kubernetes/client-node@1.0.0(patch_hash=ba1a06f46256cdb8d6faf7167246692c0de2e7cd846a9dc0f13be0137e1c3745)(bufferutil@4.0.9)(encoding@0.1.13)':
dependencies:
'@types/js-yaml': 4.0.9
'@types/node': 22.13.9
'@types/node': 20.14.14
'@types/node-fetch': 2.6.12
'@types/stream-buffers': 3.0.7
'@types/tar': 6.1.4
@@ -24196,7 +24179,7 @@ snapshots:
'@manypkg/find-root@1.1.0':
dependencies:
'@babel/runtime': 7.28.4
'@types/node': 12.20.55
'@types/node': 20.14.14
find-up: 4.1.0
fs-extra: 8.1.0
@@ -28814,7 +28797,7 @@ snapshots:
transitivePeerDependencies:
- encoding
'@remix-run/dev@2.1.0(@remix-run/serve@2.1.0(typescript@5.5.4))(@types/node@22.13.9)(bufferutil@4.0.9)(encoding@0.1.13)(lightningcss@1.29.2)(terser@5.44.1)(typescript@5.5.4)':
'@remix-run/dev@2.1.0(@remix-run/serve@2.1.0(typescript@5.5.4))(@types/node@20.14.14)(bufferutil@4.0.9)(encoding@0.1.13)(lightningcss@1.29.2)(terser@5.44.1)(typescript@5.5.4)':
dependencies:
'@babel/core': 7.22.17
'@babel/generator': 7.24.7
@@ -28827,7 +28810,7 @@ snapshots:
'@npmcli/package-json': 4.0.1
'@remix-run/server-runtime': 2.1.0(typescript@5.5.4)
'@types/mdx': 2.0.5
'@vanilla-extract/integration': 6.2.1(@types/node@22.13.9)(lightningcss@1.29.2)(terser@5.44.1)
'@vanilla-extract/integration': 6.2.1(@types/node@20.14.14)(lightningcss@1.29.2)(terser@5.44.1)
arg: 5.0.2
cacache: 17.1.4
chalk: 4.1.2
@@ -30878,7 +30861,7 @@ snapshots:
'@types/morgan@1.9.4':
dependencies:
'@types/node': 18.19.20
'@types/node': 20.14.14
'@types/ms@0.7.31': {}
@@ -30893,7 +30876,7 @@ snapshots:
'@types/node-fetch@2.6.2':
dependencies:
'@types/node': 18.19.20
'@types/node': 20.14.14
form-data: 3.0.4
'@types/node-fetch@2.6.4':
@@ -30901,28 +30884,10 @@ snapshots:
'@types/node': 20.14.14
form-data: 3.0.4
'@types/node@12.20.55': {}
'@types/node@18.19.20':
dependencies:
undici-types: 5.26.5
'@types/node@20.11.22':
dependencies:
undici-types: 5.26.5
'@types/node@20.12.14':
dependencies:
undici-types: 5.26.5
'@types/node@20.14.14':
dependencies:
undici-types: 5.26.5
'@types/node@22.13.9':
dependencies:
undici-types: 6.20.0
'@types/nodemailer@7.0.4':
dependencies:
'@aws-sdk/client-sesv2': 3.940.0
@@ -30958,7 +30923,7 @@ snapshots:
'@types/pg@8.6.6':
dependencies:
'@types/node': 18.19.20
'@types/node': 20.14.14
pg-protocol: 1.6.1
pg-types: 2.2.0
@@ -31012,7 +30977,7 @@ snapshots:
'@types/readable-stream@4.0.14':
dependencies:
'@types/node': 18.19.20
'@types/node': 20.14.14
safe-buffer: 5.1.2
'@types/regression@2.0.6': {}
@@ -31072,7 +31037,7 @@ snapshots:
'@types/ssh2@1.15.1':
dependencies:
'@types/node': 18.19.20
'@types/node': 20.14.14
'@types/stream-buffers@3.0.7':
dependencies:
@@ -31092,7 +31057,7 @@ snapshots:
'@types/tar@6.1.4':
dependencies:
'@types/node': 18.19.20
'@types/node': 20.14.14
minipass: 4.0.0
'@types/tedious@4.0.14':
@@ -31137,7 +31102,7 @@ snapshots:
'@types/ws@8.5.4':
dependencies:
'@types/node': 18.19.20
'@types/node': 20.14.14
'@types/yauzl@2.10.3':
dependencies:
@@ -31316,7 +31281,7 @@ snapshots:
media-query-parser: 2.0.2
outdent: 0.8.0
'@vanilla-extract/integration@6.2.1(@types/node@22.13.9)(lightningcss@1.29.2)(terser@5.44.1)':
'@vanilla-extract/integration@6.2.1(@types/node@20.14.14)(lightningcss@1.29.2)(terser@5.44.1)':
dependencies:
'@babel/core': 7.22.17
'@babel/plugin-syntax-typescript': 7.21.4(@babel/core@7.22.17)
@@ -31329,8 +31294,8 @@ snapshots:
lodash: 4.17.23
mlly: 1.7.4
outdent: 0.8.0
vite: 4.4.9(@types/node@22.13.9)(lightningcss@1.29.2)(terser@5.44.1)
vite-node: 0.28.5(@types/node@22.13.9)(lightningcss@1.29.2)(terser@5.44.1)
vite: 4.4.9(@types/node@20.14.14)(lightningcss@1.29.2)(terser@5.44.1)
vite-node: 0.28.5(@types/node@20.14.14)(lightningcss@1.29.2)(terser@5.44.1)
transitivePeerDependencies:
- '@types/node'
- less
@@ -32297,7 +32262,7 @@ snapshots:
bun-types@1.1.17:
dependencies:
'@types/node': 20.12.14
'@types/node': 20.14.14
'@types/ws': 8.5.10
bundle-name@4.1.0:
@@ -33537,7 +33502,7 @@ snapshots:
dependencies:
'@types/cookie': 0.4.1
'@types/cors': 2.8.17
'@types/node': 18.19.20
'@types/node': 20.14.14
accepts: 1.3.8
base64id: 2.0.0
cookie: 0.4.2
@@ -37769,7 +37734,7 @@ snapshots:
openai@4.33.1(encoding@0.1.13):
dependencies:
'@types/node': 18.19.20
'@types/node': 20.14.14
'@types/node-fetch': 2.6.4
abort-controller: 3.0.0
agentkeepalive: 4.5.0
@@ -37782,7 +37747,7 @@ snapshots:
openai@4.68.4(encoding@0.1.13)(zod@3.25.76):
dependencies:
'@types/node': 18.19.20
'@types/node': 20.14.14
'@types/node-fetch': 2.6.4
abort-controller: 3.0.0
agentkeepalive: 4.5.0
@@ -37796,7 +37761,7 @@ snapshots:
openai@4.97.0(encoding@0.1.13)(ws@8.12.0(bufferutil@4.0.9))(zod@3.25.76):
dependencies:
'@types/node': 18.19.20
'@types/node': 20.14.14
'@types/node-fetch': 2.6.12
abort-controller: 3.0.0
agentkeepalive: 4.5.0
@@ -37811,7 +37776,7 @@ snapshots:
openai@4.97.0(encoding@0.1.13)(ws@8.18.3(bufferutil@4.0.9))(zod@3.25.76):
dependencies:
'@types/node': 18.19.20
'@types/node': 20.14.14
'@types/node-fetch': 2.6.12
abort-controller: 3.0.0
agentkeepalive: 4.5.0
@@ -38715,7 +38680,7 @@ snapshots:
'@protobufjs/path': 1.1.2
'@protobufjs/pool': 1.1.0
'@protobufjs/utf8': 1.1.0
'@types/node': 18.19.20
'@types/node': 20.14.14
long: 5.2.3
proxy-addr@2.0.7:
@@ -38967,7 +38932,7 @@ snapshots:
react: 19.1.0
scheduler: 0.26.0
react-email@2.1.2(@opentelemetry/api@1.9.0)(@swc/helpers@0.5.15)(eslint@8.31.0):
react-email@2.1.2(@opentelemetry/api@1.9.0)(@swc/helpers@0.5.15)(bufferutil@4.0.9)(eslint@8.31.0):
dependencies:
'@babel/parser': 7.24.1
'@radix-ui/colors': 1.0.1
@@ -39004,8 +38969,8 @@ snapshots:
react: 18.3.1
react-dom: 18.2.0(react@18.3.1)
shelljs: 0.8.5
socket.io: 4.7.3
socket.io-client: 4.7.3
socket.io: 4.7.3(bufferutil@4.0.9)
socket.io-client: 4.7.3(bufferutil@4.0.9)
sonner: 1.3.1(react-dom@18.2.0(react@18.3.1))(react@18.3.1)
source-map-js: 1.0.2
stacktrace-parser: 0.1.10
@@ -40152,7 +40117,7 @@ snapshots:
- supports-color
- utf-8-validate
socket.io-client@4.7.3:
socket.io-client@4.7.3(bufferutil@4.0.9):
dependencies:
'@socket.io/component-emitter': 3.1.0
debug: 4.3.7(supports-color@10.0.0)
@@ -40181,7 +40146,7 @@ snapshots:
transitivePeerDependencies:
- supports-color
socket.io@4.7.3:
socket.io@4.7.3(bufferutil@4.0.9):
dependencies:
accepts: 1.3.8
base64id: 2.0.0
@@ -41376,8 +41341,6 @@ snapshots:
undici-types@5.26.5: {}
undici-types@6.20.0: {}
undici@5.29.0:
dependencies:
'@fastify/busboy': 2.1.1
@@ -41697,7 +41660,7 @@ snapshots:
d3-time: 3.1.0
d3-timer: 3.0.1
vite-node@0.28.5(@types/node@22.13.9)(lightningcss@1.29.2)(terser@5.44.1):
vite-node@0.28.5(@types/node@20.14.14)(lightningcss@1.29.2)(terser@5.44.1):
dependencies:
cac: 6.7.14
debug: 4.4.1(supports-color@10.0.0)
@@ -41706,7 +41669,7 @@ snapshots:
picocolors: 1.1.1
source-map: 0.6.1
source-map-support: 0.5.21
vite: 4.4.9(@types/node@22.13.9)(lightningcss@1.29.2)(terser@5.44.1)
vite: 4.4.9(@types/node@20.14.14)(lightningcss@1.29.2)(terser@5.44.1)
transitivePeerDependencies:
- '@types/node'
- less
@@ -41762,13 +41725,13 @@ snapshots:
- supports-color
- typescript
vite@4.4.9(@types/node@22.13.9)(lightningcss@1.29.2)(terser@5.44.1):
vite@4.4.9(@types/node@20.14.14)(lightningcss@1.29.2)(terser@5.44.1):
dependencies:
esbuild: 0.18.11
postcss: 8.5.6
rollup: 3.29.1
optionalDependencies:
'@types/node': 22.13.9
'@types/node': 20.14.14
fsevents: 2.3.3
lightningcss: 1.29.2
terser: 5.44.1