Fix run replication telemetry by passing in a tracer (#2045)

This commit is contained in:
Eric Allam
2025-05-14 09:52:09 +01:00
committed by GitHub
parent a815633712
commit 7ace1c3e25
2 changed files with 7 additions and 4 deletions
@@ -1,10 +1,10 @@
import { ClickHouse } from "@internal/clickhouse";
import { RunsReplicationService } from "./runsReplicationService.server";
import { singleton } from "~/utils/singleton";
import invariant from "tiny-invariant";
import { env } from "~/env.server";
import { metricsRegister } from "~/metrics.server";
import { singleton } from "~/utils/singleton";
import { provider } from "~/v3/tracer.server";
import { logger } from "./logger.server";
import { RunsReplicationService } from "./runsReplicationService.server";
export const runsReplicationInstance = singleton(
"runsReplicationInstance",
@@ -49,6 +49,7 @@ function initializeRunsReplicationInstance() {
leaderLockRetryIntervalMs: env.RUN_REPLICATION_LEADER_LOCK_RETRY_INTERVAL_MS,
ackIntervalSeconds: env.RUN_REPLICATION_ACK_INTERVAL_SECONDS,
logLevel: env.RUN_REPLICATION_LOG_LEVEL,
tracer: provider.getTracer("runs-replication-service"),
});
if (env.RUN_REPLICATION_ENABLED === "1") {
+3 -1
View File
@@ -83,7 +83,7 @@ class CustomWebappSampler implements Sampler {
}
}
export const { tracer, logger: otelLogger } = singleton("tracer", getTracer);
export const { tracer, logger: otelLogger, provider } = singleton("tracer", getTracer);
export async function startActiveSpan<T>(
name: string,
@@ -155,6 +155,7 @@ function getTracer() {
return {
tracer: trace.getTracer("trigger.dev", "3.3.12"),
logger: logs.getLogger("trigger.dev", "3.3.12"),
provider: new NodeTracerProvider(),
};
}
@@ -260,6 +261,7 @@ function getTracer() {
return {
tracer: provider.getTracer("trigger.dev", "3.3.12"),
logger: logs.getLogger("trigger.dev", "3.3.12"),
provider,
};
}