Fix email alert failures because of newlines in error messages (fixes #1745) (#1749)

This commit is contained in:
Eric Allam
2025-03-04 10:54:39 +00:00
committed by GitHub
parent c315e38d76
commit 457273e4cf
2 changed files with 13 additions and 4 deletions
+13 -2
View File
@@ -15,7 +15,7 @@ import MagicLinkEmail from "../emails/magic-link";
import WelcomeEmail from "../emails/welcome";
import { constructMailTransport, MailTransport, MailTransportOptions } from "./transports";
export { type MailTransportOptions }
export { type MailTransportOptions };
export const DeliverEmailSchema = z
.discriminatedUnion("email", [
@@ -109,7 +109,9 @@ export class EmailClient {
}
case "alert-run": {
return {
subject: `[${data.organization}] Run ${data.runId} failed for ${data.taskIdentifier} [${data.version}.${data.environment}] ${data.error.message}`,
subject: `[${data.organization}] Run ${data.runId} failed for ${data.taskIdentifier} [${
data.version
}.${data.environment}] ${formatErrorMessageForSubject(data.error.message)}`,
component: <AlertRunFailureEmail {...data} />,
};
}
@@ -128,3 +130,12 @@ export class EmailClient {
}
}
}
function formatErrorMessageForSubject(message?: string) {
if (!message) {
return "";
}
const singleLine = message.replace(/[\r\n]+/g, " ");
return singleLine.length > 30 ? singleLine.substring(0, 27) + "..." : singleLine;
}
-2
View File
@@ -7,7 +7,6 @@ import { ffmpeg, syncEnvVars } from "@trigger.dev/build/extensions/core";
import { puppeteer } from "@trigger.dev/build/extensions/puppeteer";
import { prismaExtension } from "@trigger.dev/build/extensions/prisma";
import { emitDecoratorMetadata } from "@trigger.dev/build/extensions/typescript";
import { pythonExtension } from "@trigger.dev/python/extension";
import { defineConfig } from "@trigger.dev/sdk/v3";
export { handleError } from "./src/handleError.js";
@@ -87,7 +86,6 @@ export default defineConfig({
value: secret.secretValue,
}));
}),
pythonExtension(),
puppeteer(),
],
external: ["re2"],