github-featured/triggerdotdev--trigger.dev
2
0
Fork 0
Code Issues Pull Requests Deployments Models Agent Notes Packages Projects Releases Wiki Activity

Cover newline-tab wrapped invalid baseURL validation paths

Browse Source 
Co-authored-by: Eric Allam <eric@trigger.dev>
This commit is contained in:
Cursor Agent
2026-02-15 06:52:10 +00:00
parent cc0b1d6dd0
commit 3e7fe1fb29
3 changed files with 68 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/tasks/streams.mdx
+1
View File
@@ -688,6 +688,7 @@ Examples:
- ❌ `\u2007///\u2007` (empty after trimming wrapper whitespace)
- ❌ `\u205F///\u205F` (empty after trimming wrapper whitespace)
- ❌ `\u3000///\u3000` (empty after trimming wrapper whitespace)
- ❌ `\n\thttps://api.trigger.dev/base/?query=1\t\n` (query is still rejected after trimming wrappers)
- ❌ `https://api.trigger.dev/\ninternal`
- ❌ `https://api.trigger.dev/in valid`
- ❌ `https://api.trigger.dev/\tinternal`
packages/ai/README.md
+1
View File
@@ -195,6 +195,7 @@ Examples:
- ❌ `\u2007///\u2007` (empty after trimming wrapper whitespace)
- ❌ `\u205F///\u205F` (empty after trimming wrapper whitespace)
- ❌ `\u3000///\u3000` (empty after trimming wrapper whitespace)
- ❌ `\n\thttps://api.trigger.dev/base/?query=1\t\n` (query is still rejected after trimming wrappers)
- ❌ `https://api.trigger.dev/\ninternal` (internal whitespace characters)
- ❌ `https://api.trigger.dev/in valid` (internal space characters)
- ❌ `https://api.trigger.dev/\tinternal` (internal tab characters)
packages/ai/src/chatTransport.test.ts
+66
View File
@@ -1105,6 +1105,17 @@ describe("TriggerChatTransport", function () {
}).toThrowError("baseURL must not include query parameters or hash fragments");
});
it("throws when newline-and-tab wrapped baseURL includes query parameters", function () {
expect(function () {
new TriggerChatTransport({
task: "chat-task",
accessToken: "pk_trigger",
baseURL: "\n\thttps://example.com/base/?query=1\t\n",
stream: "chat-stream",
});
}).toThrowError("baseURL must not include query parameters or hash fragments");
});
it("throws query/hash validation after trimming wrapper whitespace", function () {
expect(function () {
new TriggerChatTransport({
@@ -1138,6 +1149,17 @@ describe("TriggerChatTransport", function () {
}).toThrowError("baseURL must not include query parameters or hash fragments");
});
it("throws when newline-and-tab wrapped baseURL includes hash fragments", function () {
expect(function () {
new TriggerChatTransport({
task: "chat-task",
accessToken: "pk_trigger",
baseURL: "\n\thttps://example.com/base/#fragment\t\n",
stream: "chat-stream",
});
}).toThrowError("baseURL must not include query parameters or hash fragments");
});
it("throws when baseURL includes username or password credentials", function () {
expect(function () {
new TriggerChatTransport({
@@ -1226,6 +1248,17 @@ describe("TriggerChatTransport", function () {
}).toThrowError("baseURL must not include username or password credentials");
});
it("throws when newline-and-tab wrapped baseURL includes username or password credentials", function () {
expect(function () {
new TriggerChatTransport({
task: "chat-task",
accessToken: "pk_trigger",
baseURL: "\n\thttps://user:pass@example.com/base/\t\n",
stream: "chat-stream",
});
}).toThrowError("baseURL must not include username or password credentials");
});
it("accepts https baseURL values without throwing", function () {
expect(function () {
new TriggerChatTransport({
@@ -4064,6 +4097,17 @@ describe("TriggerChatTransport", function () {
}).toThrowError("baseURL must not include query parameters or hash fragments");
});
it("throws from factory when newline-and-tab wrapped baseURL includes query parameters", function () {
expect(function () {
createTriggerChatTransport({
task: "chat-task",
accessToken: "pk_trigger",
baseURL: "\n\thttps://example.com/base/?query=1\t\n",
stream: "chat-stream",
});
}).toThrowError("baseURL must not include query parameters or hash fragments");
});
it("throws query/hash validation after trimming wrapper whitespace in factory", function () {
expect(function () {
createTriggerChatTransport({
@@ -4097,6 +4141,17 @@ describe("TriggerChatTransport", function () {
}).toThrowError("baseURL must not include query parameters or hash fragments");
});
it("throws from factory when newline-and-tab wrapped baseURL includes hash fragments", function () {
expect(function () {
createTriggerChatTransport({
task: "chat-task",
accessToken: "pk_trigger",
baseURL: "\n\thttps://example.com/base/#fragment\t\n",
stream: "chat-stream",
});
}).toThrowError("baseURL must not include query parameters or hash fragments");
});
it("throws from factory when baseURL includes username or password credentials", function () {
expect(function () {
createTriggerChatTransport({
@@ -4185,6 +4240,17 @@ describe("TriggerChatTransport", function () {
}).toThrowError("baseURL must not include username or password credentials");
});
it("throws from factory when newline-and-tab wrapped baseURL includes username or password credentials", function () {
expect(function () {
createTriggerChatTransport({
task: "chat-task",
accessToken: "pk_trigger",
baseURL: "\n\thttps://user:pass@example.com/base/\t\n",
stream: "chat-stream",
});
}).toThrowError("baseURL must not include username or password credentials");
});
it("accepts https baseURL values from factory without throwing", function () {
expect(function () {
createTriggerChatTransport({