Commit Graph

541 Commits

Author SHA1 Message Date
LuluBeatson 609e6f6a63 remove go:build ignore in search_utils_test.go
License Check / license-check (push) Has been cancelled
Publish to MCP Registry / publish (push) Has been cancelled
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (actions) (push) Has been cancelled
Docker / build (push) Has been cancelled
Build and Test Go Project / build (macos-latest) (push) Has been cancelled
Build and Test Go Project / build (ubuntu-latest) (push) Has been cancelled
Build and Test Go Project / build (windows-latest) (push) Has been cancelled
GoReleaser Release / release (push) Has been cancelled
v0.23.0-gosdk
2025-11-24 16:31:41 +00:00
Sam Morrow a18fd3aaa2 Remove unused mark3labs/mcp-go dependency
The e2e tests were migrated to modelcontextprotocol/go-sdk, so the old
SDK and its transitive dependencies are no longer needed.
2025-11-24 16:58:51 +01:00
Sam Morrow bf8e9b40e0 Add TODO comments for e2e test improvements
- FILE-level review comments: Document that they are silently dropped by
  GitHub API under certain conditions and the test doesn't fully verify them
- Directory deletion: Document that the test only deletes a single file
  in a subdirectory, not actual recursive directory deletion
2025-11-24 16:58:51 +01:00
Sam Morrow 5b7b3cdd99 Add side parameter to FILE-level review comment in e2e test
The side parameter is required for review comments but FILE-level
comments still don't appear in ListReviewComments API results.
2025-11-24 16:58:51 +01:00
Sam Morrow e3aeae3032 Fix e2e test bugs in TestDirectoryDeletion and TestPullRequestReviewCommentSubmit
- Fix TestDirectoryDeletion: Create file in test-dir/ subdirectory to
  match expected filename assertion
- Fix TestDirectoryDeletion: Search for deletion commit by message instead
  of assuming first commit in list (order can vary)
- Fix TestPullRequestReviewCommentSubmit: Relax assertion from exactly 3
  comments to at least 2 (FILE-level comments may not be returned by
  ListReviewComments API)
2025-11-24 16:58:51 +01:00
Sam Morrow 61d606b890 Migrate e2e tests to modelcontextprotocol/go-sdk
- Update imports from mark3labs/mcp-go to modelcontextprotocol/go-sdk
- Update setupMCPClient to use CommandTransport and NewInMemoryTransports
- Convert CallToolRequest usage to CallToolParams inline style
- Update type assertions to use pointer types (*mcp.TextContent, etc.)
- Update tool slice type to []*mcp.Tool
- Update EmbeddedResource.Resource access (now *ResourceContents, not interface)
- Update consolidated tool names (issue_write, issue_read, pull_request_read, pull_request_review_write)
- Fix go-github v79 CreateTag/CreateRef API changes
- Fix commitId -> commitID naming convention
- Default to 'all' toolsets for comprehensive testing
2025-11-24 16:58:51 +01:00
Adam Holt a05df2e4f4 Revert change in merge for agent 2025-11-24 16:33:02 +01:00
Adam Holt 5bc4bb6534 Merge branch 'main' into omgitsads/go-sdk 2025-11-24 16:27:28 +01:00
Adam Holt 7c1340b516 Merge branch 'omgitsads/go-sdk' of https://github.com/github/github-mcp-server into omgitsads/go-sdk 2025-11-24 15:52:24 +01:00
Adam Holt e76ae992e1 Fix linter issues 2025-11-24 15:52:12 +01:00
copilot-swe-agent[bot] 71223b2bc0 Update copilot instructions to reference modelcontextprotocol/go-sdk
Co-authored-by: SamMorrowDrums <4811358+SamMorrowDrums@users.noreply.github.com>
2025-11-24 15:37:11 +01:00
Adam Holt 782cadcfa3 re-enable get_label 2025-11-24 15:36:52 +01:00
Adam Holt 77771a22e9 Update documentation 2025-11-24 15:34:40 +01:00
Copilot 001e0a1758 Migrate repos toolset to modelcontextprotocol/go-sdk (#1445)
* Initial plan

* WIP: Migrate repos toolset - 7/18 tools complete

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* Complete repositories.go migration - all 18 tools migrated

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* WIP: Update repositories_test.go - partial migration

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* Complete repos toolset migration to go-sdk

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* re-add 18 tools: 15/17 repos, 3/3 stargazers

* add toolsnaps for ListReleases, GetLatestRelease

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>
Co-authored-by: LuluBeatson <lulubeatson@github.com>
Co-authored-by: Adam Holt <me@adamholt.co.uk>
2025-11-24 15:28:09 +01:00
Adam Holt ba40198c57 Enable empty experiments toolset in Go SDK (#1477) 2025-11-24 15:26:09 +01:00
Copilot 77ac1a7eb0 Migrate projects toolset to modelcontextprotocol/go-sdk (#1475)
* Initial plan

* Migrate projects toolset to modelcontextprotocol/go-sdk

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* Update documentation after projects migration

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* Enable projects toolset after migration

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* nit: keep toolsets in original order, remove dupe

* revert docs changes

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>
Co-authored-by: LuluBeatson <lulubeatson@github.com>
2025-11-24 15:18:15 +01:00
Lulu 9e40d53acc Migrate 4 Search Tools to Go SDK (#1468)
* migrate search.go

* add toolsnap for search_orgs

* re-add 4 search tools

* Dedupe test args

---------

Co-authored-by: Adam Holt <me@adamholt.co.uk>
2025-11-24 13:43:03 +01:00
Copilot 7fbf80d055 Migrate actions toolset to modelcontextprotocol/go-sdk (#1446)
* Initial plan

* Migrate actions toolset to modelcontextprotocol/go-sdk

- Removed //go:build ignore tags from actions.go and actions_test.go
- Updated imports to use modelcontextprotocol/go-sdk instead of mark3labs/mcp-go
- Updated all tool constructor signatures to return new types
- Converted all tool definitions from DSL format to jsonschema.Schema format
- Updated tool handler signatures to use generics
- Updated parameter extraction to use args map instead of request
- Replaced mcp.NewToolResultText/Error with utils package functions
- Updated all tests to work with new handler signature
- Updated toolsnaps for all actions tools

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* re-add actions toolset

* create toolsnaps

* create toolsnaps

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>
Co-authored-by: LuluBeatson <lulubeatson@github.com>
Co-authored-by: Adam Holt <me@adamholt.co.uk>
2025-11-24 12:58:47 +01:00
Lulu 17aaf6b93e Migrate pull_requests toolset to Go SDK (#1466)
* migrate with agent

* re-add pull_requests toolset, fix whitespace

* revert changes not part of migration

* revert changes not part of migration
2025-11-24 11:57:31 +01:00
Copilot ee72841cb5 Migrate notifications toolset to modelcontextprotocol/go-sdk (#1449)
* Initial plan

* Migrate notifications toolset to modelcontextprotocol/go-sdk

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* fix the tests that Copilot removed!

* re-add notifications toolset

* Remove unused variables

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>
Co-authored-by: LuluBeatson <lulubeatson@github.com>
Co-authored-by: Adam Holt <me@adamholt.co.uk>
2025-11-24 11:52:58 +01:00
Copilot 40423387d7 Migrate discussions toolset to modelcontextprotocol/go-sdk (#1448)
* Initial plan

* Migrate discussions toolset to modelcontextprotocol/go-sdk

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* Update documentation after discussions toolset migration

* revert generated docs

* re-add discussions toolset

* rm dupe DefaultGraphQLPageSize

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>
Co-authored-by: LuluBeatson <lulubeatson@github.com>
2025-11-24 11:40:55 +01:00
Ksenia Bobrova 6a57e75d72 Delete package configuration from server.json (temporarily) (#1474)
Build and Test Go Project / build (ubuntu-latest) (push) Has been cancelled
Build and Test Go Project / build (windows-latest) (push) Has been cancelled
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (actions) (push) Has been cancelled
Docker / build (push) Has been cancelled
Build and Test Go Project / build (macos-latest) (push) Has been cancelled
GoReleaser Release / release (push) Has been cancelled
License Check / license-check (push) Has been cancelled
Publish to MCP Registry / publish (push) Has been cancelled
Temporarily removing package configuration for the GitHub MCP server because certain hosts incorrectly generate docker arguments based on it which results in a broken server configuration when installed via registry.

Will bring it back when the issue is resolved by MCP host.
v0.22.0
2025-11-24 09:38:50 +01:00
JoannaaKL 2941e876b6 Add go report card to the Readme (#1462) 2025-11-21 10:43:55 +01:00
JoannaaKL 28b868dad4 Add in memory cache for lockdown mode (#1416)
* Apply lockdown mode to issues and pull requests

* Add cache

* Unlock in defer

* Add muesli/cache2go

* [WIP] Replace custom cache in lockdown.go with cache2go struct (#1425)

* Initial plan

* Replace custom cache with cache2go library

- Added github.com/muesli/cache2go dependency
- Replaced custom map-based cache with cache2go.CacheTable
- Removed manual timer management (scheduleExpiry, ensureEntry methods)
- Removed timer field from repoAccessCacheEntry struct
- Updated GetRepoAccessInfo to use cache2go's Value() and Add() methods
- Updated SetTTL to flush and re-add entries with new TTL
- Used unique cache names per instance to avoid test interference
- All existing tests pass with the new implementation

Co-authored-by: JoannaaKL <67866556+JoannaaKL@users.noreply.github.com>

* Final verification complete

Co-authored-by: JoannaaKL <67866556+JoannaaKL@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: JoannaaKL <67866556+JoannaaKL@users.noreply.github.com>

* Use muesli for cache

* Make RepoAccessCache a singleton (#1426)

* Initial plan

* Implement RepoAccessCache as a singleton pattern

Co-authored-by: JoannaaKL <67866556+JoannaaKL@users.noreply.github.com>

* Complete singleton implementation and verification

Co-authored-by: JoannaaKL <67866556+JoannaaKL@users.noreply.github.com>

* Remove cacheIDCounter as requested

Co-authored-by: JoannaaKL <67866556+JoannaaKL@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: JoannaaKL <67866556+JoannaaKL@users.noreply.github.com>

* Update mutexes

* .

* Reuse cache

* .

* .

* Fix logic after vibe coding

* Update docs

* .

* Refactoring to make the code pretty

* Hide lockdown logic behind shouldFilter function

* .

* Tests

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
2025-11-21 10:34:51 +01:00
Copilot 42b55339b8 Migrate dynamic toolset to modelcontextprotocol/go-sdk (#1450)
* Initial plan

* Migrate dynamic toolset to modelcontextprotocol/go-sdk

This commit migrates the dynamic toolset (enable_toolset, list_available_toolsets,
get_toolset_tools) from mark3labs/mcp-go to modelcontextprotocol/go-sdk.

Changes:
- Removed //go:build ignore tag
- Updated imports to use modelcontextprotocol/go-sdk
- Migrated all tool functions to use new SDK patterns
- Updated ToolsetEnum helper to return []any instead of mcp.PropertyOption
- Converted DSL-based schema definitions to jsonschema.Schema structures
- Updated handler signatures to use map[string]any args
- Replaced old result helpers with utils package equivalents
- Fixed EnableToolset to use RegisterFunc instead of AddTools
- Created comprehensive test suite for all three tools
- Generated toolsnaps for the new tools

Related to #1428

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* Enable dynamic tools

* Remove new test and toolsnaps, we can follow up with this

* Just return the tool and handler directly instead of assigning to variables first.

This stops copilot complaining in review that the variables are unused.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>
Co-authored-by: Adam Holt <me@adamholt.co.uk>
2025-11-20 17:47:11 +01:00
Adam Holt 948fe767ae Fix handling of multi path resources (#1458)
* Migrate repo resources to Go SDK

* Enable resources for repos

* Properly handle encoding and closing of the buffer

* Remove outdated comment

* Switch to StdEncoding, as it was originally

* fix casing for linter

* Update licenses

* Handle multiple path components
2025-11-20 16:18:28 +01:00
Adam Holt 0a19bf4888 Migrate Repository Resources to the Go SDK (#1457)
* Migrate repo resources to Go SDK

* Enable resources for repos

* Properly handle encoding and closing of the buffer

* Remove outdated comment

* Switch to StdEncoding, as it was originally

* fix casing for linter

* Update licenses
2025-11-20 15:20:42 +01:00
Copilot 1b769a5848 Migrate dependabot toolset to modelcontextprotocol/go-sdk (#1429)
* Initial plan

* Migrate dependabot toolset to modelcontextprotocol/go-sdk

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* re-add dependabot toolset

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>
Co-authored-by: LuluBeatson <lulubeatson@github.com>
Co-authored-by: Adam Holt <me@adamholt.co.uk>
2025-11-20 11:18:33 +01:00
Copilot 726c683ed9 Migrate issues toolset to modelcontextprotocol/go-sdk (#1440)
* Initial plan

* Migrate imports and first 3 tools (IssueRead, ListIssueTypes, helper functions)

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* Migrate AddIssueComment, SubIssueWrite and helper functions

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* Migrate SearchIssues and search_utils helper

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* Migrate IssueWrite tool with CreateIssue and UpdateIssue helpers

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* Migrate remaining tools: ListIssues, AssignCopilotToIssue, AssignCodingAgentPrompt

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* Fix all linter errors in issues.go and search_utils.go

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* Fix test file and update toolsnaps - migration complete!

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* uncomment issues toolset

* Migrate Issue workflow prompt

* Remove commented out tool definition

* Remove duplicate func

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>
Co-authored-by: Adam Holt <me@adamholt.co.uk>
2025-11-20 11:14:28 +01:00
Copilot 9bf905bba4 Migrate labels toolset to modelcontextprotocol/go-sdk (#1433)
* Initial plan

* Migrate labels toolset from mark3labs/mcp-go to modelcontextprotocol/go-sdk

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* re-add labels toolset

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>
Co-authored-by: LuluBeatson <lulubeatson@github.com>
2025-11-19 17:33:32 +01:00
Copilot eaf411c1cd Migrate git toolset to modelcontextprotocol/go-sdk (#1432)
* Initial plan

* Migrate git toolset to modelcontextprotocol/go-sdk

- Remove //go:build ignore tag from git.go
- Update imports to use modelcontextprotocol/go-sdk
- Convert GetRepositoryTree tool schema to jsonschema format
- Update handler signature to use new generics pattern
- Update parameter extraction to use args map
- Replace mcp.NewToolResult* with utils package helpers
- Create dedicated git_test.go with updated test patterns
- Update toolsnaps for get_repository_tree

Related to #1428

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* re-add git toolset

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>
Co-authored-by: LuluBeatson <lulubeatson@github.com>
2025-11-19 17:29:29 +01:00
Adam Holt ef60ef7e13 Merge branch 'omgitsads/go-sdk' of https://github.com/github/github-mcp-server into omgitsads/go-sdk 2025-11-19 16:44:51 +01:00
Copilot 66e6ad5415 Migrate secret_scanning toolset to modelcontextprotocol/go-sdk (#1436)
* Initial plan

* Migrate secret_scanning toolset to modelcontextprotocol/go-sdk

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* Enable secret_protection toolset in DefaultToolsetGroup

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* Don't assert without a testing.T

* just return the tool & handler

* use lowercase strings for the jsonschema types

* Add Close method to IOLogger to close underlying reader and writer

* Update cmd/github-mcp-server/generate_docs.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>
Co-authored-by: Adam Holt <me@adamholt.co.uk>
Co-authored-by: Adam Holt <omgitsads@github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: LuluBeatson <lulubeatson@github.com>
2025-11-19 16:43:03 +01:00
Copilot c06ace34cc Migrate security_advisories toolset to modelcontextprotocol/go-sdk (#1434)
* Initial plan

* Migrate security_advisories toolset to modelcontextprotocol/go-sdk

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* Add toolsnaps tests and snapshots for security_advisories

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* Dont bubble up an error for getClient

We should do this eventually, but to keep the existing behavior, we
just return the error to the client.

* re-add security_advisories toolset

* Revert this change from the base PR

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>
Co-authored-by: Adam Holt <me@adamholt.co.uk>
Co-authored-by: LuluBeatson <lulubeatson@github.com>
2025-11-19 16:21:50 +01:00
Adam Holt eab4876b9e Merge branch 'omgitsads/go-sdk' of https://github.com/github/github-mcp-server into omgitsads/go-sdk 2025-11-19 11:48:13 +01:00
Ksenia Bobrova ec6afa776d Instruct LLM to use pull request template when creating PRs (#1442) 2025-11-19 11:47:31 +01:00
Copilot a4055195ea Migrate code-scanning toolset to modelcontextprotocol/go-sdk (#1430)
* Initial plan

* Migrate code-scanning toolset to modelcontextprotocol/go-sdk

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* fix lint

* re-add code_security toolset

* nolint:unused

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>
Co-authored-by: LuluBeatson <lulubeatson@github.com>
2025-11-19 11:44:43 +01:00
Copilot 6c07546591 Migrate gists toolset to modelcontextprotocol/go-sdk (#1431)
* Initial plan

* Migrate gists toolset to modelcontextprotocol/go-sdk

- Remove //go:build ignore tags from gists.go and gists_test.go
- Update imports to use modelcontextprotocol/go-sdk instead of mark3labs/mcp-go
- Migrate all 4 tools (ListGists, GetGist, CreateGist, UpdateGist):
  - Updated tool definitions to use jsonschema.Schema for InputSchema
  - Changed handler signatures to new SDK format with generics
  - Updated parameter extraction to use args map instead of request object
  - Replaced result helpers with utils package equivalents
- Updated all tests to match new handler signatures
- Added toolsnap tests for all 4 tools
- Added parseISOTimestamp utility function to minimal_types.go
- Created toolsnaps for all 4 tools

Related to #1428

Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>

* fix invalid schema, re-add gists toolset to server

* make schema types lowercase

* Don't assert without a testing.T

* just return the tool & handler

* Add Close method to IOLogger to close underlying reader and writer

* Update cmd/github-mcp-server/generate_docs.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* remove unnecessary translation

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: omgitsads <4619+omgitsads@users.noreply.github.com>
Co-authored-by: LuluBeatson <lulubeatson@github.com>
Co-authored-by: Adam Holt <me@adamholt.co.uk>
Co-authored-by: Adam Holt <omgitsads@github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-11-19 11:44:25 +01:00
Tony Truong 548c27ce62 adding remote server header for lockdown configuration (#1417)
* adding remote server header for lockdown configuration

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-11-19 11:22:06 +01:00
Ksenia Bobrova f3b9a63311 Report error when API silently fails to add review comment (#1441) 2025-11-19 10:11:17 +01:00
James Montemagno 9b747a6d8a Add installation guide for OpenAI Codex (#1340)
* Add installation guide for OpenAI Codex

* updates based on feedback

* Remove optional Docker requirement from installation guide for OpenAI Codex

* Remove Docker-related troubleshooting and references from installation guide

* Update docs/installation-guides/install-codex.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update docs/installation-guides/install-codex.md

* Apply suggestions from code review

* Update docs/installation-guides/install-codex.md

Co-authored-by: Gabriel Peal <gpeal@users.noreply.github.com>

* updates on feedback

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Gabriel Peal <gpeal@users.noreply.github.com>
2025-11-19 08:36:52 +01:00
Adam Holt cd77c136c1 Dont bubble up an error for getClient
We should do this eventually, but to keep the existing behavior, we
just return the error to the client.
2025-11-18 16:30:28 +01:00
Adam Holt 5ab610c3ce Merge branch 'omgitsads/go-sdk' of https://github.com/github/github-mcp-server into omgitsads/go-sdk 2025-11-18 14:54:29 +01:00
Adam Holt 407a974b46 Add Close method to IOLogger to close underlying reader and writer 2025-11-18 14:52:57 +01:00
Adam Holt 3f03753942 Update cmd/github-mcp-server/generate_docs.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-11-18 14:42:28 +01:00
Adam Holt 102181d311 use lowercase strings for the jsonschema types 2025-11-18 14:40:39 +01:00
Adam Holt 1286e0620c just return the tool & handler 2025-11-18 14:38:12 +01:00
Adam Holt b1ac345de4 Don't assert without a testing.T 2025-11-18 14:36:39 +01:00
Adam Holt faa90d2af2 fix linter issues 2025-11-18 11:19:21 +01:00
Adam Holt 9f25ebe299 Remove dupe import from merge conflict 2025-11-18 11:05:38 +01:00