refactor: user get methods to avoid nil checks

This commit is contained in:
LuluBeatson
2025-07-04 12:29:29 +01:00
committed by Sam Morrow
parent 37d1ed6fd8
commit 1d057c975d
2 changed files with 9 additions and 17 deletions
+4 -8
View File
@@ -40,14 +40,10 @@ func GetMe(getClient GetClientFn, t translations.TranslationHelperFunc) (mcp.Too
// Create minimal user representation instead of returning full user object
minimalUser := MinimalUser{
Login: user.GetLogin(),
ID: user.GetID(),
}
if user.HTMLURL != nil {
minimalUser.ProfileURL = *user.HTMLURL
}
if user.AvatarURL != nil {
minimalUser.AvatarURL = *user.AvatarURL
Login: user.GetLogin(),
ID: user.GetID(),
ProfileURL: user.GetHTMLURL(),
AvatarURL: user.GetAvatarURL(),
}
return MarshalledTextResult(minimalUser), nil
+5 -9
View File
@@ -224,15 +224,11 @@ func userOrOrgHandler(accountType string, getClient GetClientFn) server.ToolHand
for _, user := range result.Users {
if user.Login != nil {
mu := MinimalUser{Login: *user.Login}
if user.ID != nil {
mu.ID = *user.ID
}
if user.HTMLURL != nil {
mu.ProfileURL = *user.HTMLURL
}
if user.AvatarURL != nil {
mu.AvatarURL = *user.AvatarURL
mu := MinimalUser{
Login: user.GetLogin(),
ID: user.GetID(),
ProfileURL: user.GetHTMLURL(),
AvatarURL: user.GetAvatarURL(),
}
minimalUsers = append(minimalUsers, mu)
}