Andrey Kumanyaev
4af1724fa4
A `new Foo(args)` site produced an instantiates edge to the type but no call edge to Foo's constructor, so find_usages / get_callers on an explicit constructor returned nothing even when a test instantiated the class directly. Every object_creation_expression inside a function now also emits a calls candidate targeting the flat `<Class>.<init>` node. The target name is class-qualified and unique, so resolution binds it to that class's explicit constructor and no other; a class with only an implicit default constructor has no such node, so the candidate stays unresolved and the observable graph is unchanged. The instantiates edge is retained.
39 lines
2.5 KiB
Go
39 lines
2.5 KiB
Go
package resolver
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/zzet/gortex/internal/graph"
|
|
)
|
|
|
|
// A `new Foo(arg)` constructor-call candidate must bind to the class's explicit
|
|
// constructor node, and a `new Bar()` whose class has only an implicit default
|
|
// constructor (no `<init>` node) must stay unresolved rather than latching onto
|
|
// an unrelated class's constructor.
|
|
func TestResolveMethodCall_JavaConstructorCall(t *testing.T) {
|
|
g := graph.New()
|
|
fooFile := "src/main/java/org/example/PetTypeFormatter.java"
|
|
testFile := "src/test/java/org/example/PetTypeFormatterTests.java"
|
|
g.AddNode(&graph.Node{ID: fooFile, Kind: graph.KindFile, Name: "PetTypeFormatter.java", FilePath: fooFile, Language: "java"})
|
|
g.AddNode(&graph.Node{ID: testFile, Kind: graph.KindFile, Name: "PetTypeFormatterTests.java", FilePath: testFile, Language: "java"})
|
|
g.AddNode(&graph.Node{ID: fooFile + "::PetTypeFormatter", Kind: graph.KindType, Name: "PetTypeFormatter", FilePath: fooFile, Language: "java", Meta: map[string]any{"scope_pkg": "org.example"}})
|
|
// Explicit constructor node: flat name `<Class>.<init>`, receiver meta.
|
|
g.AddNode(&graph.Node{ID: fooFile + "::PetTypeFormatter.<init>", Kind: graph.KindMethod, Name: "PetTypeFormatter.<init>", FilePath: fooFile, Language: "java", Meta: map[string]any{"receiver": "PetTypeFormatter", "scope_pkg": "org.example"}})
|
|
g.AddNode(&graph.Node{ID: testFile + "::PetTypeFormatterTests.shouldFormat", Kind: graph.KindMethod, Name: "shouldFormat", FilePath: testFile, Language: "java", Meta: map[string]any{"receiver": "PetTypeFormatterTests", "scope_pkg": "org.example"}})
|
|
|
|
bound := &graph.Edge{From: testFile + "::PetTypeFormatterTests.shouldFormat", To: "unresolved::*.PetTypeFormatter.<init>", Kind: graph.EdgeCalls, FilePath: testFile, Line: 52, Meta: map[string]any{"receiver_type": "PetTypeFormatter", "via": "constructor"}}
|
|
// A class with only an implicit default constructor — no `<init>` node.
|
|
implicit := &graph.Edge{From: testFile + "::PetTypeFormatterTests.shouldFormat", To: "unresolved::*.Visit.<init>", Kind: graph.EdgeCalls, FilePath: testFile, Line: 53, Meta: map[string]any{"receiver_type": "Visit", "via": "constructor"}}
|
|
g.AddEdge(bound)
|
|
g.AddEdge(implicit)
|
|
|
|
r := New(g)
|
|
r.ResolveAll()
|
|
|
|
assert.Equal(t, fooFile+"::PetTypeFormatter.<init>", bound.To,
|
|
"new PetTypeFormatter() must bind to the explicit constructor node")
|
|
assert.Equal(t, "unresolved::*.Visit.<init>", implicit.To,
|
|
"new Visit() with no explicit constructor must stay unresolved, not latch onto another class's ctor")
|
|
}
|