Ilia Ross
6183a4006a
This PR adds the ability for the logging pages to hand the Miniserv access and error logs, and the Webmin actions log, to logrotate instead of having Miniserv periodically delete them. The generated section uses copy-truncate rotation, since Miniserv only reopens its error log when the file disappears. The option only appears when the Log File Rotation module is available and configured correctly.
117 lines
3.9 KiB
Perl
Executable File
117 lines
3.9 KiB
Perl
Executable File
#!/usr/local/bin/perl
|
|
# change_log.cgi
|
|
# Enable or disable logging
|
|
|
|
require './webmin-lib.pl';
|
|
&ReadParse();
|
|
&error_setup($text{'log_err'});
|
|
|
|
&lock_file($ENV{'MINISERV_CONFIG'});
|
|
&get_miniserv_config(\%miniserv);
|
|
my ($miniserv_log, $in_log) = ($miniserv{'log'}, $in{'log'});
|
|
|
|
# Only a change of error destination on a systemd-managed service needs the
|
|
# drop-in and a full restart; otherwise the option is ignored.
|
|
my $journal_changed = defined($in{'error_journal'}) &&
|
|
&miniserv_systemd_journal_available("webmin.service") &&
|
|
($miniserv{'errorlog'} eq '-' ? 1 : 0) != ($in{'error_journal'} ? 1 : 0);
|
|
|
|
$miniserv{'log'} = $in{'log'};
|
|
$miniserv{'loghost'} = $in{'loghost'};
|
|
$miniserv{'logtrust'} = $in{'logtrust'};
|
|
$miniserv{'logclf'} = $in{'logclf'};
|
|
|
|
# Either Miniserv clears the logs itself, or logrotate takes them over. There
|
|
# is no setting for the latter, so it is on when clearing is off and a section
|
|
# already rotates the logs.
|
|
my $logrotate = $in{'logclear'} == 2 ? 1 : 0;
|
|
!$logrotate || &miniserv_logrotate_available() ||
|
|
&error($text{'log_elogrotate'});
|
|
my $was_logrotate = !int($miniserv{'logclear'}) &&
|
|
&miniserv_logrotate_available() &&
|
|
&get_miniserv_logrotate_section(\%miniserv) ? 1 : 0;
|
|
$miniserv{'logclear'} = $logrotate ? 0 : $in{'logclear'};
|
|
!$miniserv{'logclear'} || $in{'logtime'} =~ /^[1-9][0-9]*$/ ||
|
|
&error(&text('log_ehours', $in{'logtime'}));
|
|
$miniserv{'logtime'} = $in{'logtime'};
|
|
if ($in{'perms_def'}) {
|
|
delete($miniserv{'logperms'});
|
|
}
|
|
else {
|
|
$in{'perms'} =~ /^[0-7]{3,4}$/ || &error($text{'log_eperms'});
|
|
$miniserv{'logperms'} = $in{'perms'};
|
|
}
|
|
if (defined($in{'login'})) {
|
|
if ($in{'login'}) {
|
|
# Create and user login wrapper scripts
|
|
&foreign_require("cron");
|
|
&cron::create_wrapper($record_login_cmd,"","record-login.pl");
|
|
&cron::create_wrapper($record_logout_cmd,"","record-logout.pl");
|
|
&cron::create_wrapper($record_failed_cmd,"","record-failed.pl");
|
|
$miniserv{'login_script'} = $record_login_cmd;
|
|
$miniserv{'logout_script'} = $record_logout_cmd;
|
|
$miniserv{'failed_script'} = $record_failed_cmd;
|
|
}
|
|
else {
|
|
# Stop using
|
|
delete($miniserv{'login_script'});
|
|
delete($miniserv{'logout_script'});
|
|
delete($miniserv{'failed_script'});
|
|
}
|
|
}
|
|
# Save the error destination and matching systemd drop-in when supported.
|
|
if ($journal_changed) {
|
|
&set_miniserv_error_destination(\%miniserv,
|
|
$ENV{'MINISERV_CONFIG'}, "webmin.service",
|
|
$in{'error_journal'});
|
|
}
|
|
else {
|
|
&put_miniserv_config(\%miniserv);
|
|
}
|
|
&unlock_file($ENV{'MINISERV_CONFIG'});
|
|
|
|
# Hand the Miniserv and actions logs to logrotate, or take them back from it
|
|
if ($logrotate) {
|
|
&setup_miniserv_logrotate(\%miniserv, "webmin", [ $webmin_logfile ]);
|
|
}
|
|
elsif ($was_logrotate) {
|
|
&remove_miniserv_logrotate(\%miniserv, [ $webmin_logfile ]);
|
|
}
|
|
|
|
$gconfig{'log'} = $in{'log'};
|
|
$gconfig{'logtime'} = $in{'logtime'};
|
|
$gconfig{'logclear'} = $miniserv{'logclear'};
|
|
$gconfig{'logrotate'} = $logrotate;
|
|
$gconfig{'logusers'} =
|
|
$in{'uall'} ? '' : join(" ", split(/\0/, $in{'users'}));
|
|
$gconfig{'logmodules'} =
|
|
$in{'mall'} ? '' : join(" ", split(/\0/, $in{'modules'}));
|
|
$gconfig{'logsched'} = $in{'logsched'};
|
|
$gconfig{'logfiles'} = $in{'logfiles'};
|
|
$gconfig{'logfullfiles'} = $in{'logfullfiles'};
|
|
$gconfig{'logperms'} = $miniserv{'logperms'};
|
|
!$in{'logfiles'} || &has_command("diff") ||
|
|
&error(&text('log_ediff', "diff"));
|
|
$gconfig{'logsyslog'} = $in{'logsyslog'} if (defined($in{'logsyslog'}));
|
|
&lock_file("$config_directory/config");
|
|
&write_file("$config_directory/config", \%gconfig);
|
|
&unlock_file("$config_directory/config");
|
|
|
|
# Clear links in Virtualmin module if installed
|
|
if ($miniserv_log != $in_log) {
|
|
if (&foreign_available('virtual-server')) {
|
|
&foreign_require("virtual-server");
|
|
&virtual_server::clear_links_cache();
|
|
}
|
|
}
|
|
|
|
# Restart through systemd when stderr needs to be re-attached.
|
|
if ($journal_changed) {
|
|
&restart_miniserv_systemd_service("webmin.service", 2);
|
|
&redirect("");
|
|
}
|
|
else {
|
|
&show_restart_page();
|
|
}
|
|
&webmin_log("log", undef, undef, \%in);
|