25563 Commits

Author SHA1 Message Date
Ilia Ross b0bd9065f6 Fix child ui table borders 2026-07-19 20:37:27 +02:00
Jamie Cameron 1dbdc60058 Add missing xmlrpc-lib.pl to package
https://github.com/webmin/webmin/issues/2797
2026-07-19 09:06:42 -07:00
Ilia Ross dce50a2039 Add missing depends for perl(FindBin) 2.652 2026-07-18 00:42:11 +02:00
Jamie Cameron 72bfd65705 Merge branch 'master' of github.com:webmin/webmin 2026-07-17 15:40:53 -07:00
Jamie Cameron ae1eedda51 Add FindBin as a recommended module 2026-07-17 15:40:46 -07:00
Ilia Ross f1841228ea Fix LVM resizing for expanded partition-backed disks
ⓘ Grow eligible PV partitions into adjacent free space before retrying `pvresize`, and treat unchanged "use all free VG space" LV targets as no-ops.
2026-07-17 20:34:36 +02:00
Jamie Cameron c1d526542f New version bump 2026-07-16 14:13:51 -07:00
Mike Steinmetz b050127ded MM-12032 Fix bond/VLAN/bridge not removed from active list on delete
delete_bifcs.cgi and save_bifc.cgi only called deactivate_interface()
which brings the link down but never removes the virtual device.
Added destroy_interface_device() that does ip link delete for these.

Also had to add bridge creation (ip link add type bridge) because unlike
bond (81d44f8) and VLAN (7761066) that was still missing.

Other fixes in this commit:

debian-linux-lib.pl: bonding opts were single-element arrays causing
trailing spaces in /etc/network/interfaces on every save.

linux-lib.pl: ip link set up/down was gated behind a
bond/vlan/no-ifconfig check but ip addr add runs unconditionally - so
interfaces got an IP but stayed DOWN. Dropped the unnecessary guard.
2026-07-16 15:01:51 +02:00
Ilia Ross d75a823e67 Update changelog
[no-build]
2026-07-16 01:51:49 +02:00
Ilia Ross b748cfb52d Update changelog for 2.652
[no-build]
2026-07-16 01:47:28 +02:00
Ilia Ross 0eaf0ef80d Fix redirect ports and linked-server WebSocket routing
ⓘ Follow up on #2794 by making `redirect_port` work even when `redirect_host` is not set. Keep existing host precedence and correctly handle proxy headers, IPv6 addresses, default ports, and invalid port values.

ⓘ Fix linked-server by keeping the child URL recognizable to the parent, then generating the final WebSocket URL on the same host and port the browser is using. This keeps the connection working with the current Webmin session.
2026-07-15 20:38:41 +02:00
Ilia Ross f220c99a10 Fix ACL tests 2026-07-15 14:06:03 +02:00
Ilia Ross 32e13451ca Merge pull request #2794 from LynYugiri/master
Fix to honor redirect settings for WebSocket URLs
2026-07-15 14:00:06 +02:00
LemoeChun 2ea3723811 Fix to honor redirect settings for WebSocket URLs 2026-07-15 17:27:16 +08:00
Jamie Cameron 0394bb8cde New safe users shouldn't inherit new permissions 2026-07-14 10:53:05 -07:00
Jamie Cameron 5b6b43ac3d Un-trusted users should not be allowed to download non-public URLs 2026-07-14 10:45:05 -07:00
Jamie Cameron e805319233 Root should still be able to download from anywhere 2026-07-14 10:14:09 -07:00
Jamie Cameron f62fd9e23a Merge pull request #2789 from webmin/dev/download-target-check
Add ACL controls for URL download destinations
2026-07-14 10:09:40 -07:00
Ilia Ross f4f3f00808 Fix missing label 2026-07-14 13:02:06 +02:00
Ilia Ross 83d402a081 Update translations 2026-07-14 12:56:53 +02:00
Ilia Ross 7bef448c1d Fix label for clarity 2026-07-14 12:55:42 +02:00
Ilia Ross 18a4d6a6df Fix to clarify Unix authentication mapping behavior
https://github.com/webmin/webmin/issues/2791
2026-07-14 12:46:15 +02:00
Ilia Ross 8f725f63c6 Fix new lines 2026-07-14 02:58:54 +02:00
Ilia Ross 99f35fa38a Fix to move URL download destination controls to global ACL 2026-07-14 02:52:36 +02:00
Ilia Ross 934073532f Fix to use the existing HTTP and FTP mode 7 callback 2026-07-14 02:27:10 +02:00
Ilia Ross a618c2b58e Fix to manually incorporated Jamie's ed3cd51 change 2026-07-14 01:57:26 +02:00
Jamie Cameron ed3cd51e40 Also pass connected FTP address to callback function 2026-07-13 16:34:30 -07:00
Ilia Ross 9dcdca7f1f Merge branch 'master' into dev/download-target-check 2026-07-14 00:58:07 +02:00
Ilia Ross bf3cd03977 Fix to manually incorporated Jamie's 70011c1 change 2026-07-14 00:46:12 +02:00
Jamie Cameron 70011c11c0 Keep track of the remote IP for HTTP connections, and make it available to the callback function 2026-07-13 14:41:52 -07:00
Jamie Cameron 9e7cdc801c Use formal params 2026-07-13 14:20:14 -07:00
Ilia Ross 64f67e63d5 Add regression coverage for warning-free empty values
https://github.com/webmin/webmin/issues/2793
2026-07-13 15:08:13 +02:00
Ilia Ross 4601f268a0 Fix XML-RPC handling of undefined and empty values
ⓘ Normalize undefined and empty XML-RPC values during encoding and parsing, preventing uninitialized-value warnings and uncontrolled error-log growth.

https://github.com/webmin/webmin/issues/2793
2026-07-13 15:07:49 +02:00
Ilia Ross dae0bf373d Fix ACL page elements order and placement 2026-07-13 14:08:25 +02:00
Ilia Ross 1555224592 Fix to refactor download address checks to use callback bundles
ⓘ Extend HTTP and FTP download callbacks with destination validation while preserving legacy tracking callbacks and enforcing SSRF policy across redirects, proxies, caches, and direct/passive sockets.

https://github.com/webmin/webmin/pull/2789#discussion_r3567985773
2026-07-13 13:36:34 +02:00
Ilia Ross f564a3127d Add regression tests previous patch 2026-07-12 23:50:48 +02:00
Ilia Ross 955daa53c6 Fix to use physical ACL restore when supported
ⓘ Detect support for combining `-P` with `setfacl --restore` to prevent acl 2.4.0 security warnings while retaining compatibility with older releases.
2026-07-12 23:50:34 +02:00
Ilia Ross d5b2a174c2 Fix to rely on defaultacl 2026-07-12 19:35:03 +02:00
Ilia Ross 470b2b5533 Fix inet6 tests 2026-07-12 15:09:17 +02:00
Ilia Ross 1ca52c9a97 Add ACL controls for URL download destinations
Block non-public HTTP, HTTPS and FTP destinations by default in File Manager, Mailboxes and Upload and Download, with per-user IP/CIDR exceptions, redirect and proxy protection, cache isolation, and current-ACL enforcement for scheduled jobs.
2026-07-12 14:57:08 +02:00
Ilia Ross 30018091ee Add tests for mailbox_uncompress_folder 2026-07-12 02:23:05 +02:00
Ilia Ross 9751fbbf50 Fix cPanel migration with dangling Maildir symlinks
https://github.com/virtualmin/virtualmin-gpl/issues/1251
2026-07-12 02:22:44 +02:00
Ilia Ross 203a87ff0e Fix to reuse copy helper for ACL-controlled file copies 2026-07-12 01:07:30 +02:00
Ilia Ross 77610666cc Fix live activation of Linux VLAN interfaces
ⓘ Create and detect VLAN devices before applying live configuration, parse live VLANs with their physical parent instead of a virtual alias, normalize persisted dotted VLAN names when the parent device exists, consistently target the real VLAN device across the ip, ifup and vconfig paths, skip recreating existing devices or activating absent disabled ones, and add regression coverage.

https://github.com/webmin/webmin/pull/2785
2026-07-11 13:33:58 +02:00
Ilia Ross 2fb4eb1721 Fix linked-server uploads over partial TLS writes
ⓘ Stream linked-server request bodies in bounded chunks, retry partial SSL writes with byte-safe offsets, detect incomplete forwarding, and add regression coverage.

https://github.com/webmin/webmin/issues/2784
2026-07-10 14:48:47 +02:00
Ilia Ross 27205bf75a Fix Usermin login URL availability check
ⓘ Require a live Usermin miniserv PID before allowing one-time login URL creation, so the feature is only offered when the session backend can actually be used.
2026-07-08 00:48:49 +02:00
Ilia Ross 2fb1a38192 Update changelog 2026-07-08 00:43:32 +02:00
Ilia Ross 113846d243 Fix to use one-time Usermin login URLs for switches
ⓘ Replace the legacy Usermin switch cookie/restart flow with a short-lived `session_login.cgi` handoff, while keeping the old API as a compatibility wrapper.

https://forum.virtualmin.com/t/usermin-2-550-login-from-the-virtualmin-edit-users-page-stopped-working/137491/37?u=ilia
2026-07-08 00:39:47 +02:00
Ilia Ross eadd47e886 Fix to replace with block eval 2026-07-07 23:45:03 +02:00
Ilia Ross c8fb79016c Fix ACL session lookups for HMAC session keys
ⓘ Load Miniserv’s session HMAC key in ACL session helpers so session listing, lookup, and user switching continue to work with HMAC-hashed session DB keys.

https://forum.virtualmin.com/t/usermin-2-550-login-from-the-virtualmin-edit-users-page-stopped-working/137491/37?u=ilia
2026-07-07 23:33:18 +02:00