Commit Graph

1298 Commits

Author SHA1 Message Date
Ilia Ross 2d01675139 Fix reflected XSS in Webmin status messages
* Note: Escape the /webmin/ message parameter, strip restart redirect HTML to plain text, and harden filter_javascript().
2026-05-17 14:32:10 +02:00
Ilia Ross 9dccd2cdce Add comments
[no-build]
2026-05-11 21:16:26 +02:00
Ilia Ross 1645cadc91 Fix stored passphrase file lookup
* Note: Make passphrase lookup use the same fallback path for full fingerprints, key IDs, and legacy generic passphrase files.

https://forum.virtualmin.com/t/usermin-gpg-encryption/136781/8?u=ilia
2026-05-11 21:14:12 +02:00
Joe Cooper 241abfe719 Add trusted_proxies config 2026-05-10 01:19:01 -05:00
Ilia Ross a7afa3a4f6 Update translations 2026-04-24 22:36:48 +02:00
Ilia Ross db17606643 Fix clarify remember-me authentication option label
https://github.com/webmin/webmin/issues/2674
2026-04-24 22:35:03 +02:00
Ilia Ross d567b09d24 Fix to handle Certbot standalone port conflicts
* Note: Add Certbot port-80 warnings and shared runtime checks, while respecting pre-request hooks that may free the port before standalone validation runs.

https://github.com/webmin/webmin/issues/2669#issuecomment-4274711184
2026-04-19 02:00:21 +02:00
Ilia Ross 12069d87af Fix to redirect to SSL edit page with Let's Encrypt tab
https://github.com/webmin/webmin/commit/544703c1b8de8c3b5a2f141efeda808f436e7ef3#r182819336
2026-04-19 00:11:17 +02:00
Ilia Ross 6c211e721c Update translations 2026-04-18 19:50:53 +02:00
Ilia Ross bb39d752a9 Update description text and UX 2026-04-18 19:50:26 +02:00
Ilia Ross ae35b100c2 Update tiny ACME client 2026-04-18 19:35:27 +02:00
Ilia Ross 84c50bba95 Update translations 2026-04-18 19:35:09 +02:00
Ilia Ross 544703c1b8 Add custom ACME server support to Webmin SSL renewal
* Note: Adds support for custom ACME directory URLs in Webmin’s SSL certificate flow, including optional EAB credentials, renewal persistence, and compatibility fixes for saved validation modes.

https://github.com/webmin/webmin/issues/2669
2026-04-18 19:34:03 +02:00
Ilia Ross 44c7b36160 Fix saved LE validation mode handling
https://github.com/webmin/webmin/issues/2669
2026-04-18 14:59:51 +02:00
Ilia Ross 4d680b1ea9 Fix SHA512/yescrypt error messages to reflect crypt() support
https://github.com/webmin/webmin/issues/2656
2026-04-17 14:36:27 +02:00
Ilia Ross a293fff996 Fix to default TOTP QR generation to QRCode::Encoder
Webmin now uses the bundled QRCode::Encoder implementation by default to generate TOTP QR codes locally and inline, without relying on qr.cgi or external services.

This encoder requires Perl 5.24 or newer, so qrencode is no longer included as a recommended package dependency. On older systems where the bundled encoder cannot run, admins can still install qrencode manually to restore QR generation support.

Systems old enough to lack Perl 5.24 are typically already well past their supported security lifecycle, so keeping qrencode preinstalled by default is no longer treated as a packaging requirement. When neither option is available, Webmin falls back cleanly to manual TOTP setup using the shared secret.

https://github.com/webmin/webmin/issues/2667#issuecomment-4247431279

[no-build]
2026-04-16 23:08:00 +02:00
Ilia Ross ac8cbf57f9 Fix to handle HTTPS update sources with outbound SSL fallback 2026-04-10 18:56:41 +02:00
Ilia Ross 3f3a84c830 Fix to normalize URLs (more)
https://github.com/webmin/webmin/issues/2663
2026-04-10 15:27:28 +02:00
Ilia Ross dde3f1642e Fix to normalize URLs
https://github.com/webmin/webmin/issues/2663
2026-04-10 13:45:14 +02:00
Ilia Ross d2b4fa89c5 Fix to match short GPG key IDs to full fingerprints
https://forum.virtualmin.com/t/gpg-encryption-in-usermin/136729/32?u=ilia
2026-03-29 15:20:10 +02:00
Ilia Ross 30f08f73fb Fix to support newer GnuPG passphrase handling
* Note: Use loopback pinentry for decrypt operation and retry decryption with the discovered secret key's stored passphrase on newer GnuPG versions

https://forum.virtualmin.com/t/gpg-encryption-in-usermin/136729/26?u=ilia
2026-03-26 11:48:40 +02:00
Ilia Ross e499b5b3a5 Fix to use loopback pinentry mode for GPG passphrase handling
https://forum.virtualmin.com/t/gpg-encryption-in-usermin/136729/19?u=ilia
2026-03-25 18:30:13 +02:00
Ilia Ross 443cf449eb Fix to use loopback pinentry for GPG decryption
https://forum.virtualmin.com/t/gpg-encryption-in-usermin/136729/19?u=ilia
2026-03-25 12:52:26 +02:00
Ilia Ross bad0d2f821 Fix fields size
[no-build]
2026-03-16 11:22:13 +02:00
Jamie Cameron d467810076 Fix layout of from address field
https://github.com/webmin/webmin/issues/2644
2026-03-15 12:26:43 -07:00
Jamie Cameron cbd96a4176 Make code more readable 2026-03-11 16:43:46 -07:00
Ilia Ross ed17ade510 Fix not to leak 2FA auth secret to logs
https://github.com/webmin/webmin/pull/2638

[no-build]
2026-03-12 01:17:42 +02:00
Ilia Ross d7434c61a2 Fix to show post-save message about 2FA
https://forum.virtualmin.com/t/no-qr-code-displayed-when-selectinc-totp/136703/5
2026-02-28 22:17:11 +02:00
Ilia Ross 2397653d55 Fix IPv6 hostname matching for alwaysresolve access rules
* Note: Fix Miniserv IPv6 hostname resolution and matching used by access control when `alwaysresolve` is enabled:
  1. Correct `to_ip6address()` success handling (before getaddrinfo result was interpreted backwards)
  2. In `ip_match()`, resolve hostnames with `to_ip6address()` for IPv6 clients instead of IPv4-only `to_ipaddress()`
  3. Canonicalize IPv6 addresses before reverse and forward verification to avoid format-based mismatches.
  4. Mirror the IPv6 logic change in "webmin/webmin-lib.pl"

https://forum.virtualmin.com/t/webmin-access-control-for-domain-names-with-ipv6/136661?u=ilia
2026-02-21 13:30:08 +02:00
Ilia Ross c89dc4996f Fix to de-hardcode default temp directory path 2026-02-20 15:16:01 +02:00
Ilia Ross 65ab502176 Add an option to configure RPC timeout 2026-01-08 18:30:41 +02:00
Jamie Cameron e88d16a888 UI for setting real name for from address
https://github.com/webmin/webmin/issues/2600
2025-12-14 15:13:56 -08:00
Jamie Cameron 3e0a08b7ef Merge branch 'master' of github.com:webmin/webmin 2025-11-08 17:18:30 -08:00
Jamie Cameron f2f40f1227 Fix clearing of default email 2025-11-08 17:16:30 -08:00
Ilia Ross 29d100e8eb Add support for displaying theme config link if supported
[no-build]
2025-11-06 21:03:50 +02:00
Jamie Cameron f49f86dc96 Don't even try to look for a BIND zone if it's not installed 2025-11-01 10:49:25 -07:00
Jamie Cameron ef1e9bbf93 Fix a comment 2025-11-01 10:48:07 -07:00
Ilia Ross 178c6198f2 Fix EOL library explosion for OS in development #2121 2025-10-09 16:38:49 +03:00
Ilia Ross d1ee0a5ed6 Fix not to completely forbid password reset without SSL 2025-09-23 23:36:09 +03:00
Jamie Cameron 6b71562abf Auto-select the correct mode when uploading a new cert 2025-09-06 10:08:02 -07:00
Ilia Ross f99f5fbae6 Revert previous commit
https://github.com/webmin/webmin/commit/5ee080d24a52a07040b8cf17b9db2e65cd26d47a#commitcomment-163253013
2025-08-01 11:21:57 +03:00
Ilia Ross 2037af9d25 Add support for configuring WebSocket binding
https://github.com/webmin/webmin/commit/5ee080d24a52a07040b8cf17b9db2e65cd26d47a#commitcomment-163197549
2025-07-31 15:21:33 +03:00
Jamie Cameron 72014ab2d7 Merge pull request #2514 from webmin/dev/option-enforce-ssl
Add the ability to re-enforce SSL connections and enable it by default
2025-07-07 08:53:24 +10:00
Ilia Ross 2d86d8c77a Fix to correctly open ports on contemporary systems 2025-07-06 21:08:18 +03:00
Ilia Ross 0bcbcd94b8 Fix to always send ports disregard of the firewall 2025-07-06 21:05:20 +03:00
Ilia Ross 24cd121642 Update outdated SSL explanations 2025-07-06 20:41:24 +03:00
Ilia Ross 11de78ce51 Add ability to configure SSL enforcement options in UI 2025-07-06 20:24:06 +03:00
Ilia Ross d9a120c760 Fix to remove non-breakable spaces that don't belong in values within parentheses 2025-07-01 14:33:27 +03:00
Ilia Ross af73be4d1e Fix to place forgotten password options higher up for consistency 2025-06-02 13:03:11 +03:00
Ilia Ross 0334d55da1 Update translations 2025-05-30 21:39:30 +03:00