* Setup project-wide prettier * Remove old workspace file * Remove old debugging directives * New top-level .prettierignore * Updated Prettier config settings * Contrubuting guide: Fix for some bad code blocks * Added more ignores * Improved the format script command * printWidth set to 100 * Formatted entire repo (pnpm run format)
8.5 KiB
Contributing to Trigger.dev
Thank you for taking the time to contribute to Trigger.dev. Your involvement is not just welcomed, but we encourage it! 🚀
Please take some time to read this guide to understand contributing best practices for Trigger.dev.
Thank you for helping us make Trigger.dev even better! 🤩
Developing
The development branch is main. This is the branch that all pull
requests should be made against. The changes on the main
branch are tagged into a release monthly.
Prerequisites
- Node.js version >=16.x
- pnpm package manager version 7
- Docker
Setup
-
Clone the repo into a public GitHub repository or fork the repo. If you plan to distribute the code, keep the source code public to comply with the Apache Licence 2.0.
git clone https://github.com/triggerdotdev/trigger.dev.gitIf you are on windows, run the following command on gitbash with admin privileges:
git clone -c core.symlinks=true https://triggerdotdev/trigger.dev.git -
Navigate to the project folder
cd trigger.dev -
Install the required packages using pnpm.
pnpm i -
Create your
.envfilescp .env.example .env && cp packages/database/.env.example packages/database/.env -
Open the root
.envfile and generate a new value forENCRYPTION_KEY:ENCRYPTION_KEYis used to two-way encrypt OAuth access tokens and so you'll probably want to actually generate a unique value, and it must be a random 16 byte hex string. You can generate one with the following command:openssl rand -hex 16Feel free to update
SESSION_SECRETandMAGIC_LINK_SECRETas well using the same method. -
Start Docker. This starts the required services like Postgres. If this is your first time using Docker, consider going through this guide
pnpm run docker -
Migrate the database
pnpm run db:migrate -
Build the app
pnpm run build --filter webapp -
Run the seed script
pnpm run db:seed -
Run the app. See the section below.
Running
-
You can run the app with:
pnpm run dev --filter webappIt should run on port
3030: http://localhost:3030 -
Once the app is running click the magic link button and enter your email.
-
Check your terminal, the magic link email should have printed out as following:
webapp:dev: Log in to Trigger.dev webapp:dev: webapp:dev: Click here to log in with this magic link webapp:dev: [http://localhost:3030/magic?token=U2FsdGVkX18OvB0JxgaswTLCSbaRz%2FY82TN0EZWhSzFyZYwgG%2BIzKVTkeiaOtWfotPw7F8RwFzCHh53aBpMEu%2B%2B%2FItb%2FcJYh89MSjc3Pz92bevoEjqxSQ%2Ff%2BZbks09JOpqlBbYC3FzGWC8vuSVFBlxqLXxteSDLthZSUaC%2BS2LaA%2BJgp%2BLO7hgjAaC2lXbCHrM7MTgTdXOFt7i0Dvvuwz6%2BWY25RnfomZOPqDsyH0xz8Q2rzPTz0Xu53WSXrZ1hd] webapp:dev: webapp:dev: If you didn't try to log in, you can safely ignore this email.Paste the magic link shown in your terminal into your browser to login.
Adding and running migrations
-
Modify packages/database/prisma/schema.prisma file
-
Change directory to the packages/database folder
cd packages/database -
Generate the Prisma client
pnpm run generateThe above updates the prisma client generated into node_modules/.prisma/client folder. This helps with typing of relevant prisma models. It ensures typescript recognizes fields added or removed from a model and type-checks appropriately.
-
Create and apply the migrations
pnpm run db:migrate:devThis creates a migration file and executes the migrations against your database and applies changes to the database schema(s)
-
Commit generated migrations as well as changes to the schema.prisma file
-
If you're using VSCode you may need to restart the Typescript server in the webapp to get updated type inference. Open a TypeScript file, then open the Command Palette (View > Command Palette) and run
TypeScript: Restart TS server.
Testing CLI changes
To test CLI changes, follow the steps below:
- Build the CLI and watch for changes
cd packages/cli
pnpm run dev
-
Open a new Terminal window and run the webapp locally and then create a new project in the dashboard. Copy out the dev API key.
-
Create a new temporary Next.js app in examples directory
pnpm create next-app@latest
Follow the prompts to create a TypeScript project using the App Directory.
- Then once that's finished, add the
@trigger.dev/clito thedevDependenciesof the newly created Next.js app'spackage.jsonfile, like so:
{
"devDependencies": { "@trigger.dev/cli": "workspace:*" }
}
- Open a new terminal window, navigate into the example, and initialize the CLI:
cd examples/your-newly-created-nextjs-project
pnpm i
pnpm exec trigger-cli init
-
When prompted, select
self-hostedand enterlocalhost:3030for your local version of the webapp. When asked for an API key, use the key you copied earlier. -
Run the CLI
pnpm exec trigger-cli dev
-
After running the CLI, start your newly created Next.js project. You should now be able to see the changes.
-
Please remember to delete the temporary project you created after you've tested the changes, and before you raise a PR.
Add sample jobs
The examples/jobs-starter project defines simple jobs you can get started with.
cdintoexamples/jobs-starter- Create a
.env.localfile with the following content, replacing[TRIGGER_DEV_API_KEY]with an actual key:
TRIGGER_API_KEY=[TRIGGER_DEV_API_KEY]
TRIGGER_API_URL=http://localhost:3030
TRIGGER_API_URL is used to configure the URL for your Trigger.dev instance,
where the jobs will be registered.
- Run the
jobs-starterapp:
pnpm dev
- Navigate to your trigger.dev instance (http://localhost:3030), to see the jobs. You can use the test feature to trigger them.
Making a pull request
If you get errors, be sure to fix them before committing.
- Be sure to check the "Allow edits from maintainers" option while creating you PR.
- If your PR refers to or fixes an issue, be sure to add
refs #XXXorfixes #XXXto the PR description. ReplacingXXXwith the respective issue number. See more about Linking a pull request to an issue . - Be sure to fill the PR Template accordingly.
Adding changesets
We use changesets to manage our package versions and changelogs. If you've never used changesets before, first read their guide here.
If you are contributing a change to any packages in this monorepo (anything in either the /packages or /integrations directories), then you will need to add a changeset to your Pull Requests before they can be merged.
To add a changeset, run the following command in the root of the repo
pnpm run changeset:add
Here's an example of creating a patch changeset for the @trigger.dev/github and @trigger.dev/slack packages (click to view):
You will be prompted to select which packages to include in the changeset. Only select the packages that you have made changes for.
Most of the time the changes you'll make are likely to be categorized as patch releases. If you feel like there is the need for a minor or major release of the package based on the changes being made, add the changeset as such and it will be discussed during PR review.
Troubleshooting
EADDRINUSE: address already in use :::3030
When receiving the following error message:
webapp:dev: Error: listen EADDRINUSE: address already in use :::3030
The process running on port 3030 should be destroyed.
- Get the
PIDof the process running on PORT3030lsof -i :3030 - Kill the process
sudo kill -9 <PID>