github-featured/triggerdotdev--trigger.dev

Files

T

Matt Aitken 92233f2e90 Core package and move to @latest (#235 )

* Changeset should ignore the example projects

* Removed note in Contributing instructions about not adding a changeset for internal

* Renamed @trigger.dev/internal to @trigger.dev/core. Set sdk and internal to be ES2020, so we don’t get errors about private identifiers

* Env vars in nextjs-example use square bracket syntax to avoid Turbo Repo errors

* Set the tsconfigs back for core and sdk

* @examples/nextjs compile error with undefined tasks

* Set the example projects to use ES2015 to avoid private modifier complaints

* package-tester example, which will use built packages

* package-tester package.json

* Created a readme for the package-tester

* Added all the packages to package-tester

* Create .env.local.example and readme instructions

* Added name to the package.json

* Upgraded @types/react and @types/react-dom everywhrre, so we can use server actions

* Upgraded @types/react and @types/react-dom everywhrre, so we can use server actions

* Reworked the react package build, so it generates separate files

* The SDK no longer bundles core

* package-tester setup with a server action and react hooks

* Added new SDK methods with logging

* Working tsup settings for client and server

* Explicit react hooks return types

* Added all the hooks for testing

* Added OpenAI step to the job to check types are still ok in integrations

* Get rid of rogue Changeset ignores

* Changeset: @trigger.dev/core is now a separate package

* Exited prerelease mode, added a changeset

* Changed @next to @latest

* Deleted seed.js, this shouldn’t be committed

* Ignore seed.js

* The webapp was importing @trigger.dev/core with a folder path rather package name…

* More webapp imports instead of @trigger.dev/core were a folder path

* Accidentally edited Stripe internal API url in the comment

* Added “sideEffects”: false so @trigger.dev/core is tree shaken by Remix

2023-07-31 18:47:34 +01:00

8.4 KiB

Raw Blame History

Contributing to Trigger.dev

Thank you for taking the time to contribute to Trigger.dev. Your involvement is not just welcomed, but we encourage it! 🚀

Please take some time to read this guide to understand contributing best practices for Trigger.dev.

Thank you for helping us make Trigger.dev even better! 🤩

Developing

The development branch is main. This is the branch that all pull requests should be made against. The changes on the main branch are tagged into a release monthly.

Prerequisites

Node.js version >=16.x
pnpm package manager version 7
Docker

Setup

Clone the repo into a public GitHub repository or fork the repo. If you plan to distribute the code, keep the source code public to comply with the Apache Licence 2.0.
```
git clone https://github.com/triggerdotdev/trigger.dev.git
```
If you are on windows, run the following command on gitbash with admin privileges: git clone -c core.symlinks=true https://triggerdotdev/trigger.dev.git
Navigate to the project folder
```
cd trigger.dev
```
Install the required packages using pnpm.
```
pnpm i
```

Create your .env files

cp .env.example .env && cp packages/database/.env.example packages/database/.env

Open the root .env file and fill in the required values Magic Link:

Both of these secrets should be random strings, which you can easily generate (and copy into your pasteboard) with the following command:
```
openssl rand -hex 16 | pbcopy
```
Then set them here:
```
SESSION_SECRET=<string>
MAGIC_LINK_SECRET=<string>
```
Start Docker. This starts the required services like Postgres. If this is your first time using Docker, consider going through this guide
```
pnpm run docker
```
Migrate the database
```
pnpm run db:migrate
```
Build the app
```
pnpm run build --filter webapp
```
Run the seed script
```
pnpm run db:seed
```
Run the app. See the section below.

Running

You can run the app with:
```
pnpm run dev --filter webapp
```
It should run on port 3030: http://localhost:3030
Once the app is running click the magic link button and enter your email.
Check your terminal, the magic link email should have printed out as following: webapp:dev: Log in to Trigger.dev webapp:dev: webapp:dev: Click here to log in with this magic link webapp:dev: [http://localhost:3030/magic?token=U2FsdGVkX18OvB0JxgaswTLCSbaRz%2FY82TN0EZWhSzFyZYwgG%2BIzKVTkeiaOtWfotPw7F8RwFzCHh53aBpMEu%2B%2B%2FItb%2FcJYh89MSjc3Pz92bevoEjqxSQ%2Ff%2BZbks09JOpqlBbYC3FzGWC8vuSVFBlxqLXxteSDLthZSUaC%2BS2LaA%2BJgp%2BLO7hgjAaC2lXbCHrM7MTgTdXOFt7i0Dvvuwz6%2BWY25RnfomZOPqDsyH0xz8Q2rzPTz0Xu53WSXrZ1hd] webapp:dev: webapp:dev: If you didn't try to log in, you can safely ignore this email.
Paste the magic link shown in your terminal into your browser to login.

Adding and running migrations

Modify packages/database/prisma/schema.prisma file
Change directory to the packages/database folder
```
cd packages/database
```
Generate the Prisma client
```
pnpm run generate
```
The above updates the prisma client generated into node_modules/.prisma/client folder. This helps with typing of relevant prisma models. It ensures typescript recognizes fields added or removed from a model and type-checks appropriately.
Create and apply the migrations
```
pnpm run db:migrate:dev
```
This creates a migration file and executes the migrations against your database and applies changes to the database schema(s)
Commit generated migrations as well as changes to the schema.prisma file
If you're using VSCode you may need to restart the Typescript server in the webapp to get updated type inference. Open a TypeScript file, then open the Command Palette (View > Command Palette) and run TypeScript: Restart TS server.

Testing CLI changes

To test CLI changes, follow the steps below:

Build the CLI and watch for changes
```
cd packages/cli
pnpm run dev
```
Open a new Terminal window and run the webapp locally and then create a new project in the dashboard. Copy out the dev API key.
Create a new temporary Next.js app in examples directory
```
pnpm create next-app@latest
```
Follow the prompts to create a TypeScript project using the App Directory.
Then once that's finished, add the @trigger.dev/cli to the devDependencies of the newly created Next.js app's package.json file, like so:
```
{
   "devDependencies": { "@trigger.dev/cli": "workspace:*" }
}
```

Open a new terminal window, navigate into the example, and initialize the CLI:

cd examples/your-newly-created-nextjs-project
pnpm i
pnpm exec trigger-cli init

When prompted, select self-hosted and enter localhost:3030 for your local version of the webapp. When asked for an API key, use the key you copied earlier.
Run the CLI
```
pnpm exec trigger-cli dev
```
After running the CLI, start your newly created Next.js project. You should now be able to see the changes.
Please remember to delete the temporary project you created after you've tested the changes, and before you raise a PR.

Add sample jobs

The examples/jobs-starter project defines simple jobs you can get started with.

cd into examples/jobs-starter
Create a .env.local file with the following content, replacing [TRIGGER_DEV_API_KEY] with an actual key:
```
TRIGGER_API_KEY=[TRIGGER_DEV_API_KEY]
TRIGGER_API_URL=http://localhost:3030
```
TRIGGER_API_URL is used to configure the URL for your Trigger.dev instance, where the jobs will be registered.
Run the jobs-starter app:
```
pnpm dev
```
Navigate to your trigger.dev instance (http://localhost:3030), to see the jobs. You can use the test feature to trigger them.

Making a pull request

If you get errors, be sure to fix them before committing.

Be sure to check the "Allow edits from maintainers" option while creating you PR.
If your PR refers to or fixes an issue, be sure to add refs #XXX or fixes #XXX to the PR description. Replacing XXX with the respective issue number. See more about Linking a pull request to an issue .
Be sure to fill the PR Template accordingly.

Adding changesets

We use changesets to manage our package versions and changelogs. If you've never used changesets before, first read their guide here.

If you are contributing a change to any packages in this monorepo (anything in either the /packages or /integrations directories), then you will need to add a changeset to your Pull Requests before they can be merged.

To add a changeset, run the following command in the root of the repo

pnpm run changeset:add

Here's an example of creating a patch changeset for the @trigger.dev/github and @trigger.dev/slack packages (click to view):

You will be prompted to select which packages to include in the changeset. Only select the packages that you have made changes for.

Most of the time the changes you'll make are likely to be categorized as patch releases. If you feel like there is the need for a minor or major release of the package based on the changes being made, add the changeset as such and it will be discussed during PR review.

Troubleshooting

EADDRINUSE: address already in use :::3030

When receiving the following error message: webapp:dev: Error: listen EADDRINUSE: address already in use :::3030

The process running on port 3030 should be destroyed.

Get the PID of the process running on PORT 3030
```
lsof -i :3030
```
Kill the process
```
sudo kill -9 <PID>
```

8.4 KiB Raw Blame History