Eric Allam
4dced14ad5
## Summary
Two fixes that together get a fresh-machine setup working from
`CONTRIBUTING.md` end-to-end with no manual workarounds:
### `CONTRIBUTING.md`
- Fix wrong path in the migration walkthrough: `cd packages/database` →
`cd internal-packages/database`. The current path doesn't exist; this
breaks step 2 for every contributor adding a migration.
- Renumber duplicate `4.` steps in **Adding migrations** and the skipped
`5.` in the hello-world **Running** section.
- Combine three sequential `pnpm run build --filter ...` calls into one
(Turbo parallelizes filters): `pnpm run build --filter webapp --filter
trigger.dev --filter @trigger.dev/sdk`.
- Add a `pnpm run db:seed` step after migrate. The seed creates the
local user, `References` org, and reference projects (including
`hello-world` with the stable `proj_rrkpdguyagvsoktglnod`). Removes the
manual instruction to edit the `externalRef` column in Postgres.
- Mention ClickHouse and the ClickHouse migrator alongside
Postgres/Redis in the Docker step (they're already part of `pnpm run
docker`, just invisible in the docs).
- Remove the V1-era **Add sample jobs** section.
`references/job-catalog` no longer exists; the hello-world flow above
replaces it.
### `turbo.json`
Scope `db:seed` to `webapp#db:seed → webapp#build`. The previous
root-level entry queued `build` for every workspace package — including
`references-*`, `docs`, `kubernetes-provider`, `coordinator`, etc. Only
`webapp` actually has a `db:seed` script, so the rest of those builds
were dead weight. Worse: a single broken reference (today,
`references-realtime-hooks-test` failing under Turbopack with
`node:fs/promises`) kills the whole seed pipeline.
After the change, `turbo run db:seed --dry-run` plan drops from 27 tasks
to 20 — only `webapp` and its real transitive workspace deps. Reference
projects no longer block seeding.
## Test plan
- [x] Fresh-machine setup followed end-to-end on a wiped Postgres +
ClickHouse: migrate → seed → build → webapp → CLI login → `trigger dev`
→ triggered `hello-world`, run completed with `{"message":"Hello,
world!"}`.
- [x] `turbo run db:seed --dry-run=json` confirms 20 tasks, all webapp
deps, no reference packages.
- [ ] CI green on the renamed turbo task name.
142 lines
2.3 KiB
JSON
142 lines
2.3 KiB
JSON
{
|
|
"$schema": "https://turborepo.org/schema.json",
|
|
"pipeline": {
|
|
"build": {
|
|
"dependsOn": [
|
|
"^build"
|
|
],
|
|
"outputs": [
|
|
"dist/**",
|
|
"public/build/**",
|
|
"build/**",
|
|
"app/styles/tailwind.css",
|
|
".cache"
|
|
]
|
|
},
|
|
"webapp#start": {
|
|
"dependsOn": [
|
|
"^build"
|
|
],
|
|
"outputs": [
|
|
"public/build/**"
|
|
]
|
|
},
|
|
"start": {
|
|
"dependsOn": [
|
|
"^build"
|
|
],
|
|
"outputs": [
|
|
"public/build/**"
|
|
]
|
|
},
|
|
"db:generate": {
|
|
"cache": false
|
|
},
|
|
"db:migrate:deploy": {
|
|
"cache": false
|
|
},
|
|
"webapp#db:seed": {
|
|
"cache": false,
|
|
"dependsOn": [
|
|
"webapp#build"
|
|
]
|
|
},
|
|
"db:studio": {
|
|
"cache": false
|
|
},
|
|
"db:populate": {
|
|
"cache": false
|
|
},
|
|
"dev": {
|
|
"cache": false,
|
|
"dependsOn": [
|
|
"^build"
|
|
]
|
|
},
|
|
"i:dev": {
|
|
"cache": false
|
|
},
|
|
"generate": {
|
|
"dependsOn": [
|
|
"^generate"
|
|
]
|
|
},
|
|
"lint": {
|
|
"outputs": []
|
|
},
|
|
"docker:build": {
|
|
"outputs": [],
|
|
"cache": false
|
|
},
|
|
"test": {
|
|
"dependsOn": [
|
|
"^build"
|
|
],
|
|
"outputs": []
|
|
},
|
|
"test:dev": {
|
|
"outputs": [],
|
|
"cache": false
|
|
},
|
|
"test:e2e:dev": {
|
|
"dependsOn": [
|
|
"^build"
|
|
],
|
|
"outputs": [],
|
|
"cache": false
|
|
},
|
|
"test:e2e:ci": {
|
|
"dependsOn": [
|
|
"^build"
|
|
],
|
|
"outputs": []
|
|
},
|
|
"typecheck": {
|
|
"dependsOn": [
|
|
"^build"
|
|
],
|
|
"outputs": []
|
|
},
|
|
"check-exports": {
|
|
"dependsOn": [
|
|
"^build"
|
|
],
|
|
"outputs": []
|
|
},
|
|
"clean": {
|
|
"cache": false
|
|
},
|
|
"clean:sourcemaps": {
|
|
"cache": false
|
|
},
|
|
"storybook": {
|
|
"cache": false
|
|
}
|
|
},
|
|
"globalDependencies": [
|
|
".env"
|
|
],
|
|
"globalEnv": [
|
|
"NODE_ENV",
|
|
"REMIX_APP_PORT",
|
|
"CI",
|
|
"DATABASE_URL",
|
|
"DIRECT_URL",
|
|
"SESSION_SECRET",
|
|
"APP_ORIGIN",
|
|
"LOGIN_ORIGIN",
|
|
"POSTHOG_PROJECT_KEY",
|
|
"MAGIC_LINK_SECRET",
|
|
"AUTH_GITHUB_CLIENT_ID",
|
|
"AUTH_GITHUB_CLIENT_SECRET",
|
|
"FROM_EMAIL",
|
|
"REPLY_TO_EMAIL",
|
|
"RESEND_API_KEY",
|
|
"DEBUG",
|
|
"TRIGGER_LOG_LEVEL",
|
|
"TRIGGER_API_KEY",
|
|
"TRIGGER_API_URL",
|
|
"APP_ENV",
|
|
"APP_LOG_LEVEL"
|
|
]
|
|
} |