Chris Arderne
19908436b8
## Summary Speeds up webapp test jobs by balancing measured work across runners, reducing repeated container setup, and ensuring test workers release shutdown resources promptly. Unit tests run across 24 duration-aware shards, while E2E tests run across two balanced shards. ## Design `RunEngine` shutdown now closes processing resources before support resources, continues cleanup if one close fails, and reuses one shutdown promise for concurrent callers. Redis workers clear completed shutdown deadlines so finished tests no longer wait on idle timers. Container-heavy suites are split only where it improves parallelism, and repeated replication and engine fixtures are consolidated where one end-to-end case provides coverage. Timing weights are refreshed for all affected files. Dependency installation overlaps container pulls, and both workflows use WarpBuild's Node setup action.
84 lines
2.8 KiB
TypeScript
84 lines
2.8 KiB
TypeScript
import { describe, expect, vi } from "vitest";
|
|
|
|
vi.mock("~/db.server", () => ({
|
|
prisma: {},
|
|
$replica: {},
|
|
runOpsNewPrisma: {},
|
|
runOpsLegacyPrisma: {},
|
|
runOpsNewReplica: {},
|
|
runOpsLegacyReplica: {},
|
|
}));
|
|
vi.mock("~/v3/runOpsMigration/splitMode.server", () => ({ isSplitEnabled: async () => false }));
|
|
vi.mock("~/services/platform.v3.server", async (importOriginal) => {
|
|
const actual = (await importOriginal()) as Record<string, unknown>;
|
|
return {
|
|
...actual,
|
|
getEntitlement: vi.fn(),
|
|
};
|
|
});
|
|
|
|
import { setupAuthenticatedEnvironment } from "@internal/run-engine/tests";
|
|
import { assertNonNullable, containerTest } from "@internal/testcontainers";
|
|
import { trace } from "@opentelemetry/api";
|
|
import { IdempotencyKeyConcern } from "~/runEngine/concerns/idempotencyKeys.server";
|
|
import { DefaultQueueManager } from "~/runEngine/concerns/queues.server";
|
|
import { RunEngineTriggerTaskService } from "./triggerTask.server";
|
|
import {
|
|
buildEngine,
|
|
CapturingParentRunValidator,
|
|
MockPayloadProcessor,
|
|
MockTraceEventConcern,
|
|
} from "./triggerTask.server.test.helpers";
|
|
|
|
vi.setConfig({ testTimeout: 60_000 });
|
|
|
|
const NUL = String.fromCharCode(0);
|
|
|
|
function buildService(engine: any, prisma: any) {
|
|
return new RunEngineTriggerTaskService({
|
|
engine,
|
|
prisma,
|
|
payloadProcessor: new MockPayloadProcessor(),
|
|
queueConcern: new DefaultQueueManager(prisma, engine),
|
|
idempotencyKeyConcern: new IdempotencyKeyConcern(prisma, engine, new MockTraceEventConcern()),
|
|
validator: new CapturingParentRunValidator(),
|
|
traceEventConcern: new MockTraceEventConcern(),
|
|
tracer: trace.getTracer("test", "0.0.0"),
|
|
metadataMaximumSize: 1024 * 1024 * 1,
|
|
});
|
|
}
|
|
|
|
describe("RunEngineTriggerTaskService null-byte sanitization", () => {
|
|
containerTest(
|
|
"sanitizes NUL-containing idempotency and debounce keys before the jsonb insert",
|
|
async ({ prisma, redisOptions }) => {
|
|
const engine = buildEngine(prisma, redisOptions);
|
|
|
|
try {
|
|
const environment = await setupAuthenticatedEnvironment(prisma, "PRODUCTION");
|
|
const service = buildService(engine, prisma);
|
|
|
|
const result = await service.call({
|
|
taskId: "nul-keys-task",
|
|
environment,
|
|
body: {
|
|
payload: { kind: "nul-keys" },
|
|
options: {
|
|
idempotencyKey: "a".repeat(64),
|
|
idempotencyKeyOptions: { key: `acme${NUL}inc`, scope: "run" },
|
|
debounce: { key: `grp${NUL}1`, delay: "1s" },
|
|
},
|
|
},
|
|
});
|
|
assertNonNullable(result);
|
|
|
|
const row = await prisma.taskRun.findUniqueOrThrow({ where: { id: result.run.id } });
|
|
expect(row.idempotencyKeyOptions).toEqual({ key: "acmeinc", scope: "run" });
|
|
expect(row.debounce).toMatchObject({ key: "grp1", delay: "1s" });
|
|
} finally {
|
|
await engine.quit();
|
|
}
|
|
}
|
|
);
|
|
});
|