Chris Arderne
c7861be520
Once this is merged, oxlint is at a pretty sensible baseline. **Enable `no-unused-vars`, `typescript/consistent-type-imports`, and `import/no-duplicates` lint rules** Turns on three previously-disabled oxlint rules across the monorepo and fixes all violations: - **`no-unused-vars`** – enabled as an error with standard ignore patterns: unused function arguments are ignored by default (`args: "none"`), variables/caught errors/destructured array elements prefixed with `_` are allowed, and rest siblings are permitted. - **`typescript/consistent-type-imports`** – enforced as an error; all type-only imports now use the `import type` syntax. - **`import/no-duplicates`** – enforced as an error; duplicate import statements from the same module have been merged. The remaining commits clean up the violations found across the codebase: removing unused variables/imports/type aliases, adding `_` prefixes to intentionally unused bindings, fixing duplicate imports, and converting value imports to `import type` where appropriate.
70 lines
2.0 KiB
TypeScript
70 lines
2.0 KiB
TypeScript
import { type IOPacket, packetRequiresOffloading, tryCatch } from "@trigger.dev/core/v3";
|
|
import type { AuthenticatedEnvironment } from "~/services/apiAuth.server";
|
|
import { env } from "~/env.server";
|
|
import { uploadPacketToObjectStore } from "~/v3/objectStore.server";
|
|
import { logger } from "~/services/logger.server";
|
|
import { ServiceValidationError } from "~/v3/services/common.server";
|
|
|
|
function packetExtensionForDataType(dataType: string): string {
|
|
switch (dataType) {
|
|
case "application/json":
|
|
case "application/super+json":
|
|
return "json";
|
|
case "text/plain":
|
|
return "txt";
|
|
default:
|
|
return "txt";
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Offloads large waitpoint completion payloads to object store (same threshold and
|
|
* upload path pattern as DefaultPayloadProcessor). Object key prefix should use the
|
|
* waitpoint friendly id folder, e.g. `${WaitpointId.toFriendlyId(internalId)}/token`.
|
|
* Replaces no-op conditionallyExportPacket usage in webapp routes where apiClientManager is unset.
|
|
*/
|
|
export async function processWaitpointCompletionPacket(
|
|
packet: IOPacket,
|
|
environment: AuthenticatedEnvironment,
|
|
pathPrefix: string
|
|
): Promise<IOPacket> {
|
|
if (!packet.data) {
|
|
return packet;
|
|
}
|
|
|
|
const { needsOffloading, size: _size } = packetRequiresOffloading(
|
|
packet,
|
|
env.TASK_PAYLOAD_OFFLOAD_THRESHOLD
|
|
);
|
|
|
|
if (!needsOffloading) {
|
|
return packet;
|
|
}
|
|
|
|
const filename = `${pathPrefix}.${packetExtensionForDataType(packet.dataType)}`;
|
|
|
|
const [uploadError, uploadedFilename] = await tryCatch(
|
|
uploadPacketToObjectStore(
|
|
filename,
|
|
packet.data,
|
|
packet.dataType,
|
|
environment,
|
|
env.OBJECT_STORE_DEFAULT_PROTOCOL
|
|
)
|
|
);
|
|
|
|
if (uploadError) {
|
|
logger.error("Failed to upload large waitpoint to object store", {
|
|
error: uploadError,
|
|
filename,
|
|
environmentId: environment.id,
|
|
});
|
|
throw new ServiceValidationError("Failed to upload large waitpoint to object store", 500);
|
|
}
|
|
|
|
return {
|
|
data: uploadedFilename!,
|
|
dataType: "application/store",
|
|
};
|
|
}
|