Daniel Sutton
bc01f6ea3a
## Summary
During `trigger()` worker-queue resolution, `getWorkerQueue` wrapped any
error from `getDefaultWorkerGroupForProject` into a client-facing
`ServiceValidationError` (HTTP 422) carrying `error.message`. That
method runs `project.findFirst` on the **writer**; when the writer is
unreachable Prisma throws a connection error (P1001) whose message
includes the database host, and that raw message was returned to the API
client and surfaced in the run view via the SDK's `TriggerApiError`.
It also mis-classifies a transient outage: a 422 is not retried by the
SDK, so triggers failed permanently instead of riding out a brief writer
blip.
## Design
This is the only place on the trigger path that folds a *caught* error's
message into a client-facing error — every other DB failure on the path
propagates to the route's generic 500 handler (scrubbed, and retried by
the SDK). So the fix is local:
- Add `isInfrastructureError()` — true for Prisma connection-level
failures (the DB-unreachable family: P1001/P1002/P1008/P1017, plus the
init/panic/unknown client error classes), false for query/validation
errors (e.g. P2002).
- At the wrap site, rethrow infrastructure errors so they reach the
generic 500 handler (no raw message, and retryable). Genuine domain
failures (e.g. "Project not found.") still become a 422.
Only P1001 ("can't reach database server") has been observed in
practice; the rest of the connection family is included as same-class
forward-proofing.
## Test plan
- [x] Unit: `isInfrastructureError` classifies a P1001 (incl. the Prisma
6.x `PrismaClientKnownRequestError` shape) and init errors as
infrastructure; P2002 and a plain `Error` as not
- [x] `getWorkerQueue` rethrows a P1001 unchanged instead of wrapping it
in a `ServiceValidationError`; still wraps a domain failure as a
`ServiceValidationError` — RED on current code, GREEN after
- [ ] (optional) toxiproxy e2e: trigger with the writer cut → HTTP 500
generic body, no DB host in the response
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
33 lines
1.4 KiB
TypeScript
33 lines
1.4 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { Prisma } from "@trigger.dev/database";
|
|
import { isInfrastructureError } from "../app/utils/prismaErrors.js";
|
|
|
|
describe("isInfrastructureError", () => {
|
|
it("treats a P1001 'can't reach database server' (KnownRequestError) as infrastructure", () => {
|
|
// Prisma 6.x reports P1001 as a PrismaClientKnownRequestError with code P1001 —
|
|
// this is the exact production shape that leaked the RDS hostname to a customer.
|
|
const err = new Prisma.PrismaClientKnownRequestError(
|
|
"Invalid `prisma.project.findFirst()` invocation: Can't reach database server at host:5432",
|
|
{ code: "P1001", clientVersion: "6.14.0" }
|
|
);
|
|
expect(isInfrastructureError(err)).toBe(true);
|
|
});
|
|
|
|
it("treats a PrismaClientInitializationError as infrastructure", () => {
|
|
const err = new Prisma.PrismaClientInitializationError("init failed", "6.14.0");
|
|
expect(isInfrastructureError(err)).toBe(true);
|
|
});
|
|
|
|
it("does NOT treat a query/validation error (P2002 unique constraint) as infrastructure", () => {
|
|
const err = new Prisma.PrismaClientKnownRequestError("Unique constraint failed", {
|
|
code: "P2002",
|
|
clientVersion: "6.14.0",
|
|
});
|
|
expect(isInfrastructureError(err)).toBe(false);
|
|
});
|
|
|
|
it("does NOT treat a plain domain Error as infrastructure", () => {
|
|
expect(isInfrastructureError(new Error("Project not found."))).toBe(false);
|
|
});
|
|
});
|