nicktrn
b570586899
The cancel button was missing from the runs list for runs in `DEQUEUED` status. The runs list gates the button on `run.isCancellable`, which goes through `isCancellableRunStatus` -> `CANCELLABLE_RUN_STATUSES` = `NON_FINAL_RUN_STATUSES`. `DEQUEUED` was never added to that list when it was introduced in the run engine. The single run page uses a separate check (`!run.isFinished`, i.e. the inverse of `FINAL_RUN_STATUSES`), so cancellation already worked there - only the list was affected. Adding `DEQUEUED` to `NON_FINAL_RUN_STATUSES` also flips `isCrashableRunStatus` and `isFailableRunStatus`, but: - The crash path is the right behaviour - a `DEQUEUED` run (worker has claimed but not yet executing) can legitimately crash before `EXECUTING`, same as `PENDING`/`DELAYED` already do. - The fail path (`failedTaskRun.server.ts`) is only reached from V1 code paths (marqs consumers, v1 heartbeat handler). `DEQUEUED` is a V2-engine-only status, so V1 consumers never see it. When cancelling a `DEQUEUED` run the execution snapshot goes to `PENDING_CANCEL` (worker must ack) but `TaskRun.status` flips to `CANCELED` immediately - the UI reflects cancellation without waiting for the worker. Added an integration test in `run-engine/src/engine/tests/cancelling.test.ts` covering the full trigger -> dequeue -> cancel -> worker-ack flow. ## Stall safety The stall recovery path (PENDING_EXECUTING heartbeat miss -> nack-and-requeue -> back to QUEUED) lives entirely inside `@internal/run-engine` and never touches the webapp's `taskStatus.ts` helpers - the engine has zero imports from `~/v3/taskStatus` and doesn't know `CrashTaskRunService` / `FailedTaskRunService` exist. A stalled DEQUEUED run still goes back to the queue for retry; this change cannot cause stalls to crash or fail. The only realistic impact is the intended UI fix - the theoretical V1 crash/fail branches for DEQUEUED are unreachable in practice because V1 runs never have DEQUEUED status.
136 lines
4.2 KiB
TypeScript
136 lines
4.2 KiB
TypeScript
import type { TaskRunAttemptStatus, TaskRunStatus } from "@trigger.dev/database";
|
|
|
|
export const FINAL_RUN_STATUSES = [
|
|
"CANCELED",
|
|
"INTERRUPTED",
|
|
"COMPLETED_SUCCESSFULLY",
|
|
"COMPLETED_WITH_ERRORS",
|
|
"SYSTEM_FAILURE",
|
|
"CRASHED",
|
|
"EXPIRED",
|
|
"TIMED_OUT",
|
|
] satisfies TaskRunStatus[];
|
|
|
|
export type FINAL_RUN_STATUSES = (typeof FINAL_RUN_STATUSES)[number];
|
|
|
|
export const NON_FINAL_RUN_STATUSES = [
|
|
"DELAYED",
|
|
"PENDING",
|
|
"PENDING_VERSION",
|
|
"WAITING_FOR_DEPLOY",
|
|
"DEQUEUED",
|
|
"EXECUTING",
|
|
"WAITING_TO_RESUME",
|
|
"RETRYING_AFTER_FAILURE",
|
|
"PAUSED",
|
|
] satisfies TaskRunStatus[];
|
|
|
|
export type NON_FINAL_RUN_STATUSES = (typeof NON_FINAL_RUN_STATUSES)[number];
|
|
|
|
export const PENDING_STATUSES = [
|
|
"PENDING",
|
|
"PENDING_VERSION",
|
|
"WAITING_FOR_DEPLOY",
|
|
] satisfies TaskRunStatus[];
|
|
|
|
export type PENDING_STATUSES = (typeof PENDING_STATUSES)[number];
|
|
|
|
export const FINAL_ATTEMPT_STATUSES = [
|
|
"FAILED",
|
|
"CANCELED",
|
|
"COMPLETED",
|
|
] satisfies TaskRunAttemptStatus[];
|
|
|
|
export type FINAL_ATTEMPT_STATUSES = (typeof FINAL_ATTEMPT_STATUSES)[number];
|
|
|
|
export const NON_FINAL_ATTEMPT_STATUSES = [
|
|
"PENDING",
|
|
"EXECUTING",
|
|
"PAUSED",
|
|
] satisfies TaskRunAttemptStatus[];
|
|
|
|
export type NON_FINAL_ATTEMPT_STATUSES = (typeof NON_FINAL_ATTEMPT_STATUSES)[number];
|
|
|
|
export const FAILED_RUN_STATUSES = [
|
|
"INTERRUPTED",
|
|
"COMPLETED_WITH_ERRORS",
|
|
"SYSTEM_FAILURE",
|
|
"CRASHED",
|
|
"TIMED_OUT",
|
|
] satisfies TaskRunStatus[];
|
|
|
|
export type FAILED_RUN_STATUSES = (typeof FAILED_RUN_STATUSES)[number];
|
|
|
|
export const FATAL_RUN_STATUSES = ["SYSTEM_FAILURE", "CRASHED"] satisfies TaskRunStatus[];
|
|
|
|
export type FATAL_RUN_STATUSES = (typeof FAILED_RUN_STATUSES)[number];
|
|
|
|
export const CANCELLABLE_RUN_STATUSES = NON_FINAL_RUN_STATUSES;
|
|
export const CANCELLABLE_ATTEMPT_STATUSES = NON_FINAL_ATTEMPT_STATUSES;
|
|
|
|
export const CRASHABLE_RUN_STATUSES = NON_FINAL_RUN_STATUSES;
|
|
export const CRASHABLE_ATTEMPT_STATUSES = NON_FINAL_ATTEMPT_STATUSES;
|
|
|
|
export const FAILABLE_RUN_STATUSES = NON_FINAL_RUN_STATUSES;
|
|
|
|
export const FREEZABLE_RUN_STATUSES: TaskRunStatus[] = ["EXECUTING", "RETRYING_AFTER_FAILURE"];
|
|
export const FREEZABLE_ATTEMPT_STATUSES: TaskRunAttemptStatus[] = ["EXECUTING", "FAILED"];
|
|
|
|
export const RESTORABLE_RUN_STATUSES: TaskRunStatus[] = ["WAITING_TO_RESUME"];
|
|
export const RESTORABLE_ATTEMPT_STATUSES: TaskRunAttemptStatus[] = ["PAUSED"];
|
|
|
|
export function isFinalRunStatus(status: TaskRunStatus): boolean {
|
|
return FINAL_RUN_STATUSES.includes(status);
|
|
}
|
|
export function isFinalAttemptStatus(status: TaskRunAttemptStatus): boolean {
|
|
return FINAL_ATTEMPT_STATUSES.includes(status);
|
|
}
|
|
|
|
export function isFailedRunStatus(status: TaskRunStatus): boolean {
|
|
return FAILED_RUN_STATUSES.includes(status);
|
|
}
|
|
|
|
export function isFatalRunStatus(status: TaskRunStatus): boolean {
|
|
return FATAL_RUN_STATUSES.includes(status);
|
|
}
|
|
|
|
export function isCancellableRunStatus(status: TaskRunStatus): boolean {
|
|
return CANCELLABLE_RUN_STATUSES.includes(status);
|
|
}
|
|
export function isCancellableAttemptStatus(status: TaskRunAttemptStatus): boolean {
|
|
return CANCELLABLE_ATTEMPT_STATUSES.includes(status);
|
|
}
|
|
|
|
export function isPendingRunStatus(status: TaskRunStatus): boolean {
|
|
return PENDING_STATUSES.includes(status);
|
|
}
|
|
|
|
export function isCrashableRunStatus(status: TaskRunStatus): boolean {
|
|
return CRASHABLE_RUN_STATUSES.includes(status);
|
|
}
|
|
export function isCrashableAttemptStatus(status: TaskRunAttemptStatus): boolean {
|
|
return CRASHABLE_ATTEMPT_STATUSES.includes(status);
|
|
}
|
|
|
|
export function isFailableRunStatus(status: TaskRunStatus): boolean {
|
|
return FAILABLE_RUN_STATUSES.includes(status);
|
|
}
|
|
|
|
export function isFreezableRunStatus(status: TaskRunStatus): boolean {
|
|
return FREEZABLE_RUN_STATUSES.includes(status);
|
|
}
|
|
export function isFreezableAttemptStatus(status: TaskRunAttemptStatus): boolean {
|
|
return FREEZABLE_ATTEMPT_STATUSES.includes(status);
|
|
}
|
|
|
|
export function isRestorableRunStatus(status: TaskRunStatus): boolean {
|
|
return RESTORABLE_RUN_STATUSES.includes(status);
|
|
}
|
|
export function isRestorableAttemptStatus(status: TaskRunAttemptStatus): boolean {
|
|
return RESTORABLE_ATTEMPT_STATUSES.includes(status);
|
|
}
|
|
|
|
export function shouldIdempotencyKeyBeCleared(status: TaskRunStatus): boolean {
|
|
return isFailedRunStatus(status) || status === "EXPIRED";
|
|
}
|