Chris Arderne
c7861be520
Once this is merged, oxlint is at a pretty sensible baseline. **Enable `no-unused-vars`, `typescript/consistent-type-imports`, and `import/no-duplicates` lint rules** Turns on three previously-disabled oxlint rules across the monorepo and fixes all violations: - **`no-unused-vars`** – enabled as an error with standard ignore patterns: unused function arguments are ignored by default (`args: "none"`), variables/caught errors/destructured array elements prefixed with `_` are allowed, and rest siblings are permitted. - **`typescript/consistent-type-imports`** – enforced as an error; all type-only imports now use the `import type` syntax. - **`import/no-duplicates`** – enforced as an error; duplicate import statements from the same module have been merged. The remaining commits clean up the violations found across the codebase: removing unused variables/imports/type aliases, adding `_` prefixes to intentionally unused bindings, fixing duplicate imports, and converting value imports to `import type` where appropriate.
55 lines
1.6 KiB
TypeScript
55 lines
1.6 KiB
TypeScript
import { BaseService } from "./baseService.server";
|
|
import { logger } from "~/services/logger.server";
|
|
import { isFatalRunStatus } from "../taskStatus";
|
|
import type { TaskRunInternalError } from "@trigger.dev/core/v3";
|
|
import { TaskRunErrorCodes } from "@trigger.dev/core/v3";
|
|
import { FinalizeTaskRunService } from "./finalizeTaskRun.server";
|
|
|
|
export type UpdateFatalRunErrorServiceOptions = {
|
|
reason?: string;
|
|
exitCode?: number;
|
|
logs?: string;
|
|
errorCode?: TaskRunInternalError["code"];
|
|
};
|
|
|
|
export class UpdateFatalRunErrorService extends BaseService {
|
|
public async call(runId: string, options?: UpdateFatalRunErrorServiceOptions) {
|
|
const opts = {
|
|
reason: "Worker crashed",
|
|
...options,
|
|
};
|
|
|
|
logger.debug("UpdateFatalRunErrorService.call", { runId, opts });
|
|
|
|
const taskRun = await this.runStore.findRun({ id: runId }, this._prisma);
|
|
|
|
if (!taskRun) {
|
|
logger.error("[UpdateFatalRunErrorService] Task run not found", { runId });
|
|
return;
|
|
}
|
|
|
|
if (!isFatalRunStatus(taskRun.status)) {
|
|
logger.warn("[UpdateFatalRunErrorService] Task run is not in a fatal state", {
|
|
runId,
|
|
status: taskRun.status,
|
|
});
|
|
|
|
return;
|
|
}
|
|
|
|
logger.debug("[UpdateFatalRunErrorService] Updating crash error", { runId, options });
|
|
|
|
const finalizeService = new FinalizeTaskRunService();
|
|
await finalizeService.call({
|
|
id: taskRun.id,
|
|
status: "CRASHED",
|
|
error: {
|
|
type: "INTERNAL_ERROR",
|
|
code: opts.errorCode ?? TaskRunErrorCodes.TASK_RUN_CRASHED,
|
|
message: opts.reason,
|
|
stackTrace: opts.logs,
|
|
},
|
|
});
|
|
}
|
|
}
|