5ba8557a51
## Summary v3 (the engine that ran the SDK v3 era, internally `RunEngineVersion.V1`) is end-of-life. Following the removal of the v3 execution apps ([#4194](https://github.com/triggerdotdev/trigger.dev/pull/4194)) and the legacy dev websocket ([#4198](https://github.com/triggerdotdev/trigger.dev/pull/4198)), this removes the remaining v3 execution stack from the server. Clients still on v3 (an old SDK or CLI that has not upgraded) keep getting a clear "upgrade to v4" response. Triggers, batch triggers, reschedules, and deploys that resolve to v3 are rejected with a graceful 4xx pointing at the migration guide, never a 5xx, so a stale client cannot affect server health. Self-hosted instances still running v3 should stay on the 4.5.x release line until they migrate. ## What is removed - The MarQS queue and its shared/dev queue consumers. - The v3 socket.io namespaces (coordinator, provider, shared-queue) and the v3 run lifecycle services (attempt, checkpoint, and batch-resume). - The graphile-worker background job system; all live jobs already run on `@trigger.dev/redis-worker`. - The `DEPRECATE_V3_ENABLED` flag: v3 is now rejected unconditionally, so the flag is gone. - Unused v3 exports from `@trigger.dev/core` (the `v3/zodNamespace` subpath and the legacy socket message catalogs) and the now-dead MarQS environment variables. ## What stays The v4 engine is untouched. The graceful v3 rejection boundary stays, `determineEngineVersion` still detects a v3 project so it can reject it, and the batch service plus batch-completion worker stay for current clients. Live queue concurrency limits and metrics now read from the v4 run engine instead of MarQS, and a brand-new dev environment now defaults to v4. ## Dependency cleanup Removes webapp dependencies left unused by this change: `seedrandom` and `semver` (only the removed v3 code used them) plus a set that was already dead, their orphaned `@types` packages, and two dead files. Adds a `knip:deps` script and a `knip.json` config so unused dependencies can be found the same way going forward.
101 lines
2.9 KiB
TypeScript
101 lines
2.9 KiB
TypeScript
import { logger } from "~/services/logger.server";
|
|
import { BaseService } from "./baseService.server";
|
|
import { commonWorker } from "../commonWorker.server";
|
|
import { PerformDeploymentAlertsService } from "./alerts/performDeploymentAlerts.server";
|
|
import { type PrismaClientOrTransaction } from "~/db.server";
|
|
import { DeploymentService } from "./deployment.server";
|
|
import { recordDeploymentOutcome } from "./recordDeploymentOutcome.server";
|
|
|
|
export class TimeoutDeploymentService extends BaseService {
|
|
public async call(id: string, fromStatus: string, errorMessage: string) {
|
|
const deployment = await this._prisma.workerDeployment.findFirst({
|
|
where: {
|
|
id,
|
|
},
|
|
include: {
|
|
environment: {
|
|
include: {
|
|
project: true,
|
|
},
|
|
},
|
|
},
|
|
});
|
|
|
|
if (!deployment) {
|
|
logger.error(`No worker deployment with this ID: ${id}`);
|
|
return;
|
|
}
|
|
|
|
if (deployment.status !== fromStatus) {
|
|
// Race: timeout job fired after the deployment moved out of the
|
|
// expected state (already deployed/failed). System handles it by
|
|
// returning early — not an error.
|
|
logger.warn("Deployment is not in the correct state to be timed out", {
|
|
currentStatus: deployment.status,
|
|
fromStatus,
|
|
});
|
|
return;
|
|
}
|
|
|
|
const timedOutDeployment = await this._prisma.workerDeployment.update({
|
|
where: {
|
|
id: deployment.id,
|
|
},
|
|
data: {
|
|
status: "TIMED_OUT",
|
|
failedAt: new Date(),
|
|
errorData: { message: errorMessage, name: "TimeoutError" },
|
|
},
|
|
});
|
|
|
|
recordDeploymentOutcome({
|
|
status: "TIMED_OUT",
|
|
deploymentFriendlyId: deployment.friendlyId,
|
|
organizationId: deployment.environment.project.organizationId,
|
|
projectId: deployment.environment.projectId,
|
|
environmentId: deployment.environmentId,
|
|
environmentType: deployment.environment.type,
|
|
reason: errorMessage,
|
|
});
|
|
|
|
const deploymentService = new DeploymentService();
|
|
await deploymentService
|
|
.appendToEventLog(deployment.environment.project, timedOutDeployment, [
|
|
{
|
|
type: "finalized",
|
|
data: {
|
|
result: "timed_out",
|
|
message: errorMessage,
|
|
},
|
|
},
|
|
])
|
|
.orTee((error) => {
|
|
logger.error("Failed to append timed out deployment event to event log", { error });
|
|
});
|
|
|
|
await PerformDeploymentAlertsService.enqueue(deployment.id);
|
|
}
|
|
|
|
static async enqueue(
|
|
deploymentId: string,
|
|
fromStatus: string,
|
|
errorMessage: string,
|
|
runAt: Date
|
|
) {
|
|
await commonWorker.enqueue({
|
|
id: `timeoutDeployment:${deploymentId}`,
|
|
job: "v3.timeoutDeployment",
|
|
payload: {
|
|
deploymentId,
|
|
fromStatus,
|
|
errorMessage,
|
|
},
|
|
availableAt: runAt,
|
|
});
|
|
}
|
|
|
|
static async dequeue(deploymentId: string, tx?: PrismaClientOrTransaction) {
|
|
await commonWorker.ack(`timeoutDeployment:${deploymentId}`);
|
|
}
|
|
}
|