From fc473105e301f9d75bc1239d7ba93bf0fa483157 Mon Sep 17 00:00:00 2001 From: Matt Aitken Date: Wed, 27 Mar 2024 14:08:13 +0000 Subject: [PATCH] =?UTF-8?q?Better=20error=20messages=20if=20you=20haven?= =?UTF-8?q?=E2=80=99t=20set=20the=20API=20URL=20or=20SECRET=20for=20the=20?= =?UTF-8?q?v3=20client?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/trigger-sdk/src/v3/shared.ts | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/packages/trigger-sdk/src/v3/shared.ts b/packages/trigger-sdk/src/v3/shared.ts index db65d84f7..3ac436f57 100644 --- a/packages/trigger-sdk/src/v3/shared.ts +++ b/packages/trigger-sdk/src/v3/shared.ts @@ -214,7 +214,7 @@ export function createTask( const apiClient = apiClientManager.client; if (!apiClient) { - throw new Error("API client is not initialized"); + throw apiClientMissingError(); } const taskMetadata = runtime.getTaskMetadata(params.id); @@ -273,7 +273,7 @@ export function createTask( const apiClient = apiClientManager.client; if (!apiClient) { - throw new Error("API client is not initialized"); + throw apiClientMissingError(); } const taskMetadata = runtime.getTaskMetadata(params.id); @@ -343,7 +343,7 @@ export function createTask( const apiClient = apiClientManager.client; if (!apiClient) { - throw new Error("API client is not initialized"); + throw apiClientMissingError(); } const taskMetadata = runtime.getTaskMetadata(params.id); @@ -414,7 +414,7 @@ export function createTask( const apiClient = apiClientManager.client; if (!apiClient) { - throw new Error("API client is not initialized"); + throw apiClientMissingError(); } const taskMetadata = runtime.getTaskMetadata(params.id); @@ -558,3 +558,17 @@ async function handleTaskRunExecutionResult( }; } } + +function apiClientMissingError() { + const hasBaseUrl = !!apiClientManager.baseURL; + const hasAccessToken = !!apiClientManager.accessToken; + if (!hasBaseUrl && !hasAccessToken) { + return `You need to set the TRIGGER_API_URL and TRIGGER_SECRET_KEY environment variables.`; + } else if (!hasBaseUrl) { + return `You need to set the TRIGGER_API_URL environment variable.`; + } else if (!hasAccessToken) { + return `You need to set the TRIGGER_SECRET_KEY environment variable.`; + } + + return `Unknown error`; +}