From dad56aa791ae06def759c1edb6c08b5d70928291 Mon Sep 17 00:00:00 2001 From: nicktrn <55853254+nicktrn@users.noreply.github.com> Date: Fri, 26 Apr 2024 22:37:37 +0100 Subject: [PATCH] control forced checkpoint simulation via env var --- apps/coordinator/src/index.ts | 6 +++++- apps/docker-provider/src/index.ts | 7 ++++++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/apps/coordinator/src/index.ts b/apps/coordinator/src/index.ts index dff8c38b3..84574e069 100644 --- a/apps/coordinator/src/index.ts +++ b/apps/coordinator/src/index.ts @@ -20,6 +20,10 @@ const HTTP_SERVER_PORT = Number(process.env.HTTP_SERVER_PORT || 8020); const NODE_NAME = process.env.NODE_NAME || "coordinator"; const DEFAULT_RETRY_DELAY_THRESHOLD_IN_MS = 30_000; +const FORCE_CHECKPOINT_SIMULATION = ["1", "true"].includes( + process.env.FORCE_CHECKPOINT_SIMULATION ?? "true" +); + const REGISTRY_HOST = process.env.REGISTRY_HOST || "localhost:5000"; const CHECKPOINT_PATH = process.env.CHECKPOINT_PATH || "/checkpoints"; const REGISTRY_TLS_VERIFY = process.env.REGISTRY_TLS_VERIFY === "false" ? "false" : "true"; @@ -319,7 +323,7 @@ class Checkpointer { class TaskCoordinator { #httpServer: ReturnType; - #checkpointer = new Checkpointer({ forceSimulate: true }); + #checkpointer = new Checkpointer({ forceSimulate: FORCE_CHECKPOINT_SIMULATION }); #prodWorkerNamespace: ZodNamespace< typeof ProdWorkerToCoordinatorMessages, diff --git a/apps/docker-provider/src/index.ts b/apps/docker-provider/src/index.ts index 08c29ad12..5e25ddb43 100644 --- a/apps/docker-provider/src/index.ts +++ b/apps/docker-provider/src/index.ts @@ -14,9 +14,14 @@ import { randomUUID } from "node:crypto"; const MACHINE_NAME = process.env.MACHINE_NAME || "local"; const COORDINATOR_PORT = process.env.COORDINATOR_PORT || 8020; const COORDINATOR_HOST = process.env.COORDINATOR_HOST || "127.0.0.1"; + const OTEL_EXPORTER_OTLP_ENDPOINT = process.env.OTEL_EXPORTER_OTLP_ENDPOINT || "http://0.0.0.0:4318"; +const FORCE_CHECKPOINT_SIMULATION = ["1", "true"].includes( + process.env.FORCE_CHECKPOINT_SIMULATION ?? "true" +); + const logger = new SimpleLogger(`[${MACHINE_NAME}]`); type InitializeReturn = { @@ -293,7 +298,7 @@ class DockerTaskOperations implements TaskOperations { } const provider = new ProviderShell({ - tasks: new DockerTaskOperations({ forceSimulate: true }), + tasks: new DockerTaskOperations({ forceSimulate: FORCE_CHECKPOINT_SIMULATION }), type: "docker", });