From d622aba86d9c45cc528732c85f687c9943da302e Mon Sep 17 00:00:00 2001 From: Eric Allam Date: Wed, 12 Feb 2025 14:03:48 +0000 Subject: [PATCH] Fix missing logs on child runs by using the root task run createdAt if it exists (#1697) --- apps/webapp/app/presenters/v3/RunPresenter.server.ts | 3 ++- apps/webapp/app/presenters/v3/SpanPresenter.server.ts | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/apps/webapp/app/presenters/v3/RunPresenter.server.ts b/apps/webapp/app/presenters/v3/RunPresenter.server.ts index 6b8d7a432..347ea49af 100644 --- a/apps/webapp/app/presenters/v3/RunPresenter.server.ts +++ b/apps/webapp/app/presenters/v3/RunPresenter.server.ts @@ -47,6 +47,7 @@ export class RunPresenter { friendlyId: true, taskIdentifier: true, spanId: true, + createdAt: true, }, }, runtimeEnvironment: { @@ -111,7 +112,7 @@ export class RunPresenter { const traceSummary = await eventRepository.getTraceSummary( getTaskEventStoreTableForRun(run), run.traceId, - run.createdAt, + run.rootTaskRun?.createdAt ?? run.createdAt, run.completedAt ?? undefined ); if (!traceSummary) { diff --git a/apps/webapp/app/presenters/v3/SpanPresenter.server.ts b/apps/webapp/app/presenters/v3/SpanPresenter.server.ts index 726651695..010efcba1 100644 --- a/apps/webapp/app/presenters/v3/SpanPresenter.server.ts +++ b/apps/webapp/app/presenters/v3/SpanPresenter.server.ts @@ -135,6 +135,7 @@ export class SpanPresenter extends BasePresenter { taskIdentifier: true, friendlyId: true, spanId: true, + createdAt: true, }, }, parentTaskRun: { @@ -211,7 +212,7 @@ export class SpanPresenter extends BasePresenter { getTaskEventStoreTableForRun(run), spanId, run.traceId, - run.createdAt, + run.rootTaskRun?.createdAt ?? run.createdAt, run.completedAt ?? undefined );