From 893cd8fbb8be946596df123bd4ddca2b60b6455e Mon Sep 17 00:00:00 2001
From: Eric Allam <eallam@icloud.com>
Date: Tue, 18 Aug 2026 14:03:13 +0100
Subject: [PATCH] fix(webapp): don't coerce empty smart-column values to 0 in
 number/duration columns

Number(null)/Number("")/Number([])/Number(false) are all a finite 0, so an empty value showed a misleading 0 (or 0ms). Only coerce actual numbers and non-empty numeric strings; anything else falls back to its raw rendering.
---
 .../app/components/runs/v3/smartColumnCell.tsx    | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/apps/webapp/app/components/runs/v3/smartColumnCell.tsx b/apps/webapp/app/components/runs/v3/smartColumnCell.tsx
index f23623058..57850bbeb 100644
--- a/apps/webapp/app/components/runs/v3/smartColumnCell.tsx
+++ b/apps/webapp/app/components/runs/v3/smartColumnCell.tsx
@@ -21,14 +21,25 @@ function stringifySmartValue(value: unknown): string {
   }
 }
 
+/**
+ * Coerce to a finite number only from an actual number or a non-empty numeric
+ * string. Returns NaN for null/boolean/empty-string/array/object so those fall
+ * back to their raw rendering instead of coercing to a misleading 0.
+ */
+function toFiniteNumber(value: unknown): number {
+  if (typeof value === "number") return value;
+  if (typeof value === "string" && value.trim().length > 0) return Number(value);
+  return NaN;
+}
+
 function renderSmartValue(value: unknown, displayAs: SmartColumnDef["displayAs"]): React.ReactNode {
   switch (displayAs) {
     case "number": {
-      const n = typeof value === "number" ? value : Number(value);
+      const n = toFiniteNumber(value);
       return Number.isFinite(n) ? n.toLocaleString() : stringifySmartValue(value);
     }
     case "duration": {
-      const n = typeof value === "number" ? value : Number(value);
+      const n = toFiniteNumber(value);
       return Number.isFinite(n)
         ? formatDurationMilliseconds(n, { style: "short" })
         : stringifySmartValue(value);