From 7e57f1f3dddb2ff1d1cc90e040986e929c7ddf35 Mon Sep 17 00:00:00 2001
From: Alexandre Costa <costasalexandre511@gmail.com>
Date: Fri, 3 Nov 2023 08:10:26 -0300
Subject: [PATCH] [TRI-1449] Display warning message when duplicate job IDs are
 detected (#699)

* add warning message when duplicate job IDs are detected

* fix warning message for duplicated job IDs in defineJob

* Create bright-buckets-bow.md

---------

Co-authored-by: Eric Allam <eric@trigger.dev>
---
 .changeset/bright-buckets-bow.md          |  5 +++++
 packages/trigger-sdk/package.json         |  1 +
 packages/trigger-sdk/src/triggerClient.ts | 10 ++++++++++
 3 files changed, 16 insertions(+)
 create mode 100644 .changeset/bright-buckets-bow.md

diff --git a/.changeset/bright-buckets-bow.md b/.changeset/bright-buckets-bow.md
new file mode 100644
index 000000000..f9a33470b
--- /dev/null
+++ b/.changeset/bright-buckets-bow.md
@@ -0,0 +1,5 @@
+---
+"@trigger.dev/sdk": patch
+---
+
+[TRI-1449] Display warning message when duplicate job IDs are detected
diff --git a/packages/trigger-sdk/package.json b/packages/trigger-sdk/package.json
index 5397b9011..a39403f43 100644
--- a/packages/trigger-sdk/package.json
+++ b/packages/trigger-sdk/package.json
@@ -28,6 +28,7 @@
     "@trigger.dev/core": "workspace:^2.2.4",
     "@trigger.dev/core-backend": "workspace:^2.2.4",
     "chalk": "^5.2.0",
+    "colorette": "^2.0.20",
     "cronstrue": "^2.21.0",
     "debug": "^4.3.4",
     "evt": "^2.4.13",
diff --git a/packages/trigger-sdk/src/triggerClient.ts b/packages/trigger-sdk/src/triggerClient.ts
index 3477549ec..e015cbcde 100644
--- a/packages/trigger-sdk/src/triggerClient.ts
+++ b/packages/trigger-sdk/src/triggerClient.ts
@@ -33,6 +33,7 @@ import {
   SourceMetadataV2,
   StatusUpdate,
 } from "@trigger.dev/core";
+import { yellow } from "colorette";
 import { ApiClient } from "./apiClient";
 import {
   AutoYieldExecutionError,
@@ -480,6 +481,15 @@ export class TriggerClient {
     TIntegrations extends Record<string, TriggerIntegration> = {},
     TOutput extends any = any,
   >(options: JobOptions<TTrigger, TIntegrations, TOutput>) {
+    
+    const existingRegisteredJob = this.#registeredJobs[options.id];
+    
+    if (existingRegisteredJob) {
+      console.warn(
+        yellow(`[@trigger.dev/sdk] Warning: The Job "${existingRegisteredJob.id}" you're attempting to define has already been defined. Please assign a different ID to the job.`)
+      );
+    }
+    
     return new Job<TTrigger, TIntegrations, TOutput>(this, options);
   }