From 690b308feae28b2e5f23fd0b9ca69be5b04da31b Mon Sep 17 00:00:00 2001 From: Matt Aitken Date: Tue, 7 Nov 2023 10:52:55 +0000 Subject: [PATCH] =?UTF-8?q?verifyRequestSignature=20=E2=80=93=20added=20an?= =?UTF-8?q?=20error=20if=20the=20passed=20in=20secret=20is=20undefined=20o?= =?UTF-8?q?r=20empty?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/trigger-sdk/src/security.ts | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/packages/trigger-sdk/src/security.ts b/packages/trigger-sdk/src/security.ts index 456b275ed..663437d6b 100644 --- a/packages/trigger-sdk/src/security.ts +++ b/packages/trigger-sdk/src/security.ts @@ -19,6 +19,13 @@ export async function verifyRequestSignature({ supported. */ algorithm: "sha256"; }): Promise { + if (!secret) { + return { + success: false, + reason: "Missing secret – you've probably not set an environment variable.", + }; + } + const headerValue = request.headers.get(headerName); if (!headerValue) { return { success: false, reason: "Missing header" };