From 6327be82de27079ead121a005efb8d2f8c9e9d8f Mon Sep 17 00:00:00 2001
From: nicktrn <55853254+nicktrn@users.noreply.github.com>
Date: Tue, 24 Sep 2024 19:42:50 +0100
Subject: [PATCH] skip retrying on invalid block errors

---
 .../v3/services/alerts/deliverAlert.server.ts | 50 +++++++++++++------
 1 file changed, 36 insertions(+), 14 deletions(-)

diff --git a/apps/webapp/app/v3/services/alerts/deliverAlert.server.ts b/apps/webapp/app/v3/services/alerts/deliverAlert.server.ts
index c388a5cc8..702be6819 100644
--- a/apps/webapp/app/v3/services/alerts/deliverAlert.server.ts
+++ b/apps/webapp/app/v3/services/alerts/deliverAlert.server.ts
@@ -73,6 +73,8 @@ type FoundAlert = Prisma.Result<
   >;
 };
 
+class SkipRetryError extends Error {}
+
 export class DeliverAlertService extends BaseService {
   public async call(alertId: string) {
     const alert: FoundAlert | null = await this._prisma.projectAlert.findFirst({
@@ -136,22 +138,34 @@ export class DeliverAlertService extends BaseService {
       alert.failedAttempt = finishedAttempt;
     }
 
-    switch (alert.channel.type) {
-      case "EMAIL": {
-        await this.#sendEmail(alert);
-        break;
+    try {
+      switch (alert.channel.type) {
+        case "EMAIL": {
+          await this.#sendEmail(alert);
+          break;
+        }
+        case "SLACK": {
+          await this.#sendSlack(alert);
+          break;
+        }
+        case "WEBHOOK": {
+          await this.#sendWebhook(alert);
+          break;
+        }
+        default: {
+          assertNever(alert.channel.type);
+        }
       }
-      case "SLACK": {
-        await this.#sendSlack(alert);
-        break;
-      }
-      case "WEBHOOK": {
-        await this.#sendWebhook(alert);
-        break;
-      }
-      default: {
-        assertNever(alert.channel.type);
+    } catch (error) {
+      if (error instanceof SkipRetryError) {
+        logger.error("[DeliverAlert] Skipping retry", {
+          reason: error.message,
+        });
+
+        return;
       }
+
+      throw error;
     }
 
     await this._prisma.projectAlert.update({
@@ -1012,6 +1026,14 @@ export class DeliverAlertService extends BaseService {
           message,
         });
 
+        if (error.data.error === "invalid_blocks") {
+          logger.error("[DeliverAlert] Slack invalid blocks", {
+            error,
+          });
+
+          throw new SkipRetryError("Slack invalid blocks");
+        }
+
         throw new Error("Slack platform error");
       }