Fixed issue with workflow runs not completing when the run function returned undefined or null

.changeset/dry-beds-double.md

@@ -0,0 +1,5 @@
+---
+"@trigger.dev/sdk": patch
+---
+
+Fixed issue with workflow runs not completing when the run function returned undefined or null

apps/webapp/app/models/workflowRun.server.ts

@@ -80,10 +80,10 @@ export async function failWorkflowRun(
 }
 
 export async function completeWorkflowRun(
-  output: string,
   runId: string,
   apiKey: string,
-  timestamp: string
+  timestamp: string,
+  output?: string | null
 ) {
   const workflowRun = await findWorkflowRunScopedToApiKey(runId, apiKey);
 
@@ -104,6 +104,9 @@ export async function completeWorkflowRun(
       },
     });
 
+    const parsedOutput =
+      typeof output === "string" ? JSON.parse(output) : undefined;
+
     await tx.workflowRunStep.upsert({
       where: {
         runId_idempotencyKey: {
@@ -115,7 +118,7 @@ export async function completeWorkflowRun(
         runId,
         idempotencyKey: "output",
         type: "OUTPUT",
-        output: JSON.parse(output),
+        output: parsedOutput === null ? undefined : parsedOutput,
         context: {},
         startedAt: new Date(),
         finishedAt: new Date(),

apps/webapp/app/services/messageBroker.server.ts

@@ -187,10 +187,10 @@ function createCommandSubscriber() {
       },
       WORKFLOW_RUN_COMPLETE: async (id, data, properties) => {
         await completeWorkflowRun(
-          data.output,
           properties["x-workflow-run-id"],
           properties["x-api-key"],
-          properties["x-timestamp"]
+          properties["x-timestamp"],
+          data.output
         );
 
         return true;

packages/internal-bridge/src/schemas/server.ts

@@ -81,7 +81,7 @@ export const ServerRPCSchema = {
   COMPLETE_WORKFLOW_RUN: {
     request: z.object({
       runId: z.string(),
-      output: z.string(),
+      output: z.string().optional(),
       timestamp: z.string(),
     }),
     response: z.boolean(),

packages/internal-bridge/src/zodRPC.ts

@@ -1,6 +1,7 @@
 import { z, ZodError } from "zod";
 import { createHash } from "node:crypto";
 import { IConnection } from "./types";
+import { Logger } from "./logger";
 
 export const RPCMessageSchema = z.object({
   id: z.string(),
@@ -45,6 +46,7 @@ export class ZodRPC<
   #receiver: ReceiverSchema;
   #handlers: ZodRPCHandlers<ReceiverSchema>;
   #pendingCalls = new Map<string, onResponseCallback>();
+  #logger: Logger = new Logger("ZodRPC");
 
   constructor(options: ZodRPCOptions<SenderSchema, ReceiverSchema>) {
     this.#connection = options.connection;
@@ -73,7 +75,7 @@ export class ZodRPC<
         await this.#onResponse(data);
       }
     } catch (err) {
-      console.error(err);
+      this.#logger.error(err);
     }
   }
 
@@ -82,14 +84,12 @@ export class ZodRPC<
       await this.#handleCall(message);
     } catch (callError) {
       if (callError instanceof ZodError) {
-        console.error(
-          `[ZodRPC][foobar] Received invalid call:\n${JSON.stringify(
-            message
-          )}: `,
+        this.#logger.error(
+          `[ZodRPC] Received invalid call:\n${JSON.stringify(message)}: `,
           callError.errors
         );
       } else {
-        console.error(
+        this.#logger.error(
           `[ZodRPC] Error handling call:\n${JSON.stringify(message)}: `,
           callError
         );
@@ -102,12 +102,12 @@ export class ZodRPC<
       await this.#handleResponse(message);
     } catch (callError) {
       if (callError instanceof ZodError) {
-        console.error(
+        this.#logger.error(
           `[ZodRPC] Received invalid response\n\n${JSON.stringify(message)}: `,
           callError.flatten()
         );
       } else {
-        console.error(
+        this.#logger.error(
           `[ZodRPC] Error handling response\n\n${JSON.stringify(message)}: `,
           callError
         );
@@ -153,6 +153,8 @@ export class ZodRPC<
       throw new Error(`There is no method for ${message.methodName}`);
     }
 
+    this.#logger.debug("Received call", { message });
+
     // struggling to get real inference here
     const inputs = method.request.parse(message.data);
 
@@ -169,7 +171,7 @@ export class ZodRPC<
     try {
       await this.#connection.send(preparedResponseText);
     } catch (err) {
-      console.error("Failed sending response", preparedResponseText, err);
+      this.#logger.error("Failed sending response", preparedResponseText, err);
     }
 
     return;

packages/internal-platform/src/messages/schemas/workflowRuns.ts

@@ -5,7 +5,7 @@ import { WorkflowSendRunEventPropertiesSchema } from "../sharedSchemas";
 export const commands = {
   WORKFLOW_RUN_COMPLETE: {
     data: z.object({
-      output: z.string(),
+      output: z.string().optional(),
     }),
     properties: WorkflowSendRunEventPropertiesSchema,
   },