From 54db582e5ca5c796e089287dec14ccdf178c7e6a Mon Sep 17 00:00:00 2001
From: nicktrn <55853254+nicktrn@users.noreply.github.com>
Date: Thu, 1 May 2025 09:17:56 +0100
Subject: [PATCH] improve QUEUED_EXECUTING test

---
 .../src/entryPoints/managed/snapshot.test.ts   | 18 ++++--------------
 1 file changed, 4 insertions(+), 14 deletions(-)

diff --git a/packages/cli-v3/src/entryPoints/managed/snapshot.test.ts b/packages/cli-v3/src/entryPoints/managed/snapshot.test.ts
index 18e93b049..256db83cf 100644
--- a/packages/cli-v3/src/entryPoints/managed/snapshot.test.ts
+++ b/packages/cli-v3/src/entryPoints/managed/snapshot.test.ts
@@ -1,10 +1,11 @@
 import { SnapshotManager } from "./snapshot.js";
 import { ConsoleRunLogger } from "./logger.js";
-import { RunExecutionData, TaskRunExecutionStatus, TaskRunStatus } from "@trigger.dev/core/v3";
+import { RunExecutionData, TaskRunExecutionStatus } from "@trigger.dev/core/v3";
 import { setTimeout } from "timers/promises";
+import { isCI } from "std-env";
 
 describe("SnapshotManager", () => {
-  const mockLogger = new ConsoleRunLogger();
+  const mockLogger = new ConsoleRunLogger({ print: !isCI });
   const mockSnapshotHandler = vi.fn();
   const mockSuspendableHandler = vi.fn();
 
@@ -94,22 +95,13 @@ describe("SnapshotManager", () => {
     // Reset mocks
     vi.clearAllMocks();
 
-    // This should also work with QUEUED_EXECUTING
-    await manager.setSuspendable(false);
-    expect(manager.suspendable).toBe(false);
-
-    // Update the snapshot to QUEUED_EXECUTING
+    // Transitioning to QUEUED_EXECUTING should call the handler again
     await manager.handleSnapshotChange(
       createRunExecutionData({
         snapshotId: "snapshot-3",
         executionStatus: "QUEUED_EXECUTING",
       })
     );
-    expect(mockSuspendableHandler).not.toHaveBeenCalled();
-
-    // Set suspendable to true and check that the handler is called
-    await manager.setSuspendable(true);
-    expect(manager.suspendable).toBe(true);
     expect(mockSuspendableHandler).toHaveBeenCalledWith({
       id: "snapshot-3",
       status: "QUEUED_EXECUTING",
@@ -444,8 +436,6 @@ describe("SnapshotManager", () => {
       }
     }
 
-    console.log(manager.queueLength);
-
     await Promise.all(promises);
 
     // Verify handler execution exclusivity