From 4ace3a4bb7870b1d4e590ac1ad742841d416b7b6 Mon Sep 17 00:00:00 2001 From: nicktrn <55853254+nicktrn@users.noreply.github.com> Date: Fri, 3 May 2024 14:29:07 +0100 Subject: [PATCH] add missing ack on checkpoint creation service failure --- apps/webapp/app/v3/services/completeAttempt.server.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/apps/webapp/app/v3/services/completeAttempt.server.ts b/apps/webapp/app/v3/services/completeAttempt.server.ts index ec4bc6e35..b2d5dfe94 100644 --- a/apps/webapp/app/v3/services/completeAttempt.server.ts +++ b/apps/webapp/app/v3/services/completeAttempt.server.ts @@ -56,6 +56,8 @@ export class CompleteAttemptService extends BaseService { }, }); + // No attempt, so there's no message to ACK + return "COMPLETED"; } @@ -142,6 +144,8 @@ export class CompleteAttemptService extends BaseService { env ); + // The cancel service handles ACK + return "COMPLETED"; } @@ -226,6 +230,8 @@ export class CompleteAttemptService extends BaseService { }, }); + await marqs?.acknowledgeMessage(taskRunAttempt.taskRunId); + return "COMPLETED"; }