From 36397d0cb128e1dfaa627359f4bf8a367184160e Mon Sep 17 00:00:00 2001
From: Matt Aitken <matt@mattaitken.com>
Date: Tue, 10 Sep 2024 14:52:32 +0100
Subject: [PATCH] =?UTF-8?q?Added=20more=20logging=20when=20finalizing=20ru?=
 =?UTF-8?q?ns=20and=20when=20messages=20don=E2=80=99t=20exist=20in=20marqs?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 apps/webapp/app/v3/marqs/index.server.ts          | 15 +++++++++++++++
 .../app/v3/services/createCheckpoint.server.ts    | 12 ++++++++++--
 .../app/v3/services/finalizeTaskRun.server.ts     |  4 ++--
 3 files changed, 27 insertions(+), 4 deletions(-)

diff --git a/apps/webapp/app/v3/marqs/index.server.ts b/apps/webapp/app/v3/marqs/index.server.ts
index 94acfffe5..5ebe087e8 100644
--- a/apps/webapp/app/v3/marqs/index.server.ts
+++ b/apps/webapp/app/v3/marqs/index.server.ts
@@ -414,6 +414,10 @@ export class MarQS {
         const message = await this.readMessage(messageId);
 
         if (!message) {
+          logger.log(`[${this.name}].acknowledgeMessage() message not found`, {
+            messageId,
+            service: this.name,
+          });
           return;
         }
 
@@ -553,6 +557,11 @@ export class MarQS {
         const message = await this.readMessage(messageId);
 
         if (!message) {
+          logger.log(`[${this.name}].releaseConcurrency() message not found`, {
+            messageId,
+            releaseForRun,
+            service: this.name,
+          });
           return;
         }
 
@@ -641,6 +650,12 @@ export class MarQS {
         const message = await this.readMessage(messageId);
 
         if (!message) {
+          logger.log(`[${this.name}].nackMessage() message not found`, {
+            messageId,
+            retryAt,
+            updates,
+            service: this.name,
+          });
           return;
         }
 
diff --git a/apps/webapp/app/v3/services/createCheckpoint.server.ts b/apps/webapp/app/v3/services/createCheckpoint.server.ts
index b7189716b..8f8479f71 100644
--- a/apps/webapp/app/v3/services/createCheckpoint.server.ts
+++ b/apps/webapp/app/v3/services/createCheckpoint.server.ts
@@ -176,9 +176,17 @@ export class CreateCheckpointService extends BaseService {
           const result = await resumeService.call({ id: attempt.taskRunId });
 
           if (result.success) {
-            logger.log("CreateCheckpointService: Resumed dependent parents", result);
+            logger.log("CreateCheckpointService: Resumed dependent parents", {
+              result,
+              attempt,
+              checkpointEvent,
+            });
           } else {
-            logger.error("CreateCheckpointService: Failed to resume dependent parents", result);
+            logger.error("CreateCheckpointService: Failed to resume dependent parents", {
+              result,
+              attempt,
+              checkpointEvent,
+            });
           }
 
           return {
diff --git a/apps/webapp/app/v3/services/finalizeTaskRun.server.ts b/apps/webapp/app/v3/services/finalizeTaskRun.server.ts
index 6a42549a8..f86b9fd00 100644
--- a/apps/webapp/app/v3/services/finalizeTaskRun.server.ts
+++ b/apps/webapp/app/v3/services/finalizeTaskRun.server.ts
@@ -75,9 +75,9 @@ export class FinalizeTaskRunService extends BaseService {
     const result = await resumeService.call({ id: run.id });
 
     if (result.success) {
-      logger.log("FinalizeTaskRunService: Resumed dependent parents", { result });
+      logger.log("FinalizeTaskRunService: Resumed dependent parents", { result, run });
     } else {
-      logger.error("FinalizeTaskRunService: Failed to resume dependent parents", { result });
+      logger.error("FinalizeTaskRunService: Failed to resume dependent parents", { result, run });
     }
 
     //enqueue alert