From 2d84b7cdc41ba9c9e10fbccbddb00219b6486aa0 Mon Sep 17 00:00:00 2001 From: nicktrn <55853254+nicktrn@users.noreply.github.com> Date: Fri, 18 Oct 2024 00:34:40 +0100 Subject: [PATCH] prevent uncancellable checkpoints --- apps/coordinator/src/checkpointer.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/apps/coordinator/src/checkpointer.ts b/apps/coordinator/src/checkpointer.ts index f1b55fa06..bf82a6702 100644 --- a/apps/coordinator/src/checkpointer.ts +++ b/apps/coordinator/src/checkpointer.ts @@ -436,7 +436,10 @@ export class Checkpointer { this.#logger.error("Error during cleanup", { ...metadata, error }); } - this.#abortControllers.delete(runId); + // Ensure only the current controller is removed + if (this.#abortControllers.get(runId) === controller) { + this.#abortControllers.delete(runId); + } controller.signal.removeEventListener("abort", onAbort); };