From 28050adbcb075decf604c3997da24f682cf812ca Mon Sep 17 00:00:00 2001
From: nicktrn <55853254+nicktrn@users.noreply.github.com>
Date: Sun, 15 Sep 2024 14:08:09 +0100
Subject: [PATCH] lint and action updates

---
 .github/workflows/e2e.yml            | 6 +++---
 .github/workflows/pr_checks.yml      | 7 +++----
 .github/workflows/publish-docker.yml | 6 ++++--
 .github/workflows/publish-infra.yml  | 7 ++++---
 .github/workflows/release.yml        | 5 ++---
 .github/workflows/typecheck.yml      | 6 ++++--
 .github/workflows/unit-tests.yml     | 9 +++++----
 7 files changed, 25 insertions(+), 21 deletions(-)

diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
index 905b4991c..edef353d2 100644
--- a/.github/workflows/e2e.yml
+++ b/.github/workflows/e2e.yml
@@ -1,4 +1,5 @@
 name: "E2E"
+
 on:
   workflow_call:
     inputs:
@@ -7,6 +8,7 @@ on:
         default: webapp
         required: false
         type: string
+
 jobs:
   cli-v3:
     name: "🧪 CLI v3 tests (${{ matrix.os }} - ${{ matrix.package-manager }})"
@@ -19,7 +21,7 @@ jobs:
         package-manager: ["npm", "pnpm", "yarn"]
     steps:
       - name: ⬇️ Checkout repo
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
@@ -50,5 +52,3 @@ jobs:
         shell: bash
         run: |
           LOG=debug PM=${{ matrix.package-manager }} pnpm --filter trigger.dev run test:e2e
-
-
diff --git a/.github/workflows/pr_checks.yml b/.github/workflows/pr_checks.yml
index e57984327..298c0766f 100644
--- a/.github/workflows/pr_checks.yml
+++ b/.github/workflows/pr_checks.yml
@@ -30,12 +30,11 @@ jobs:
   preview-release:
     name: Preview Release
     needs: [typecheck, units, e2e]
-    if: |
-      github.repository == 'triggerdotdev/trigger.dev'
+    if: github.repository == 'triggerdotdev/trigger.dev'
     runs-on: buildjet-8vcpu-ubuntu-2204
     steps:
       - name: ⬇️ Checkout repo
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
@@ -56,5 +55,5 @@ jobs:
       - name: 🏗️ Build
         run: pnpm run build --filter "@trigger.dev/*" --filter "trigger.dev"
 
-      - name: ⚡ publish preview release
+      - name: ⚡ Publish preview release
         run: npx pkg-pr-new publish --no-template $(ls -d ./packages/*)
diff --git a/.github/workflows/publish-docker.yml b/.github/workflows/publish-docker.yml
index 688b1d25d..cd0bc3f4c 100644
--- a/.github/workflows/publish-docker.yml
+++ b/.github/workflows/publish-docker.yml
@@ -1,6 +1,8 @@
 name: "🐳 Publish Docker"
+
 on:
   workflow_call:
+
 jobs:
   publish:
     runs-on: ubuntu-latest
@@ -14,7 +16,7 @@ jobs:
         uses: depot/setup-action@v1
 
       - name: ⬇️ Checkout repo
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           submodules: recursive
 
@@ -59,7 +61,7 @@ jobs:
           echo "IMAGE_TAGS=${image_tags}" >> "$GITHUB_OUTPUT"
 
       - name: 🐙 Login to GitHub Container Registry
-        uses: docker/login-action@v2
+        uses: docker/login-action@v3
         with:
           registry: ghcr.io
           username: ${{ github.repository_owner }}
diff --git a/.github/workflows/publish-infra.yml b/.github/workflows/publish-infra.yml
index 1a3486b01..ca9dd885d 100644
--- a/.github/workflows/publish-infra.yml
+++ b/.github/workflows/publish-infra.yml
@@ -42,7 +42,8 @@ jobs:
     env:
       DOCKER_BUILDKIT: "1"
     steps:
-      - uses: actions/checkout@v4
+      - name: ⬇️ Checkout git repo
+        uses: actions/checkout@v4
 
       - name: Generate image reference
         id: prep
@@ -80,11 +81,11 @@ jobs:
           fi
           echo "IMAGE_TAG=${image_tag}" >> "$GITHUB_OUTPUT"
 
-      - name: Set up Docker Buildx
+      - name: 🐋 Set up Docker Buildx
         uses: docker/setup-buildx-action@v3
 
       # ..to avoid rate limits when pulling images
-      - name: Login to DockerHub
+      - name: 🐳 Login to DockerHub
         uses: docker/login-action@v3
         with:
           username: ${{ secrets.DOCKERHUB_USERNAME }}
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index c196ddfb6..2a10f8c38 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -14,8 +14,7 @@ jobs:
   release:
     name: 🦋 Changesets Release
     runs-on: buildjet-8vcpu-ubuntu-2204
-    if: |
-      github.repository == 'triggerdotdev/trigger.dev'
+    if: github.repository == 'triggerdotdev/trigger.dev'
     outputs:
       published_packages: ${{ steps.changesets.outputs.publishedPackages }}
       published: ${{ steps.changesets.outputs.published }}
@@ -24,7 +23,7 @@ jobs:
         uses: styfle/cancel-workflow-action@0.11.0
 
       - name: ⬇️ Checkout repo
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
diff --git a/.github/workflows/typecheck.yml b/.github/workflows/typecheck.yml
index afc5cf03a..921e9bd34 100644
--- a/.github/workflows/typecheck.yml
+++ b/.github/workflows/typecheck.yml
@@ -1,13 +1,15 @@
 name: "ʦ TypeScript"
+
 on:
   workflow_call:
+
 jobs:
   typecheck:
     runs-on: buildjet-8vcpu-ubuntu-2204
 
     steps:
       - name: ⬇️ Checkout repo
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
@@ -30,6 +32,6 @@ jobs:
 
       - name: 🔎 Type check
         run: pnpm run typecheck
-      
+
       - name: 🔎 Check exports
         run: pnpm run check-exports
diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml
index 111c3b037..863c5fcde 100644
--- a/.github/workflows/unit-tests.yml
+++ b/.github/workflows/unit-tests.yml
@@ -1,13 +1,15 @@
 name: "🧪 Unit Tests"
+
 on:
   workflow_call:
+
 jobs:
   unitTests:
     name: "🧪 Unit Tests"
     runs-on: buildjet-8vcpu-ubuntu-2204
     steps:
       - name: ⬇️ Checkout repo
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
@@ -25,6 +27,5 @@ jobs:
       - name: 📥 Download deps
         run: pnpm install --frozen-lockfile
 
-      - name: Run Unit Tests
-        run: |
-          pnpm run test
+      - name: 🧪 Run Unit Tests
+        run: pnpm run test