From 18bd7f4623632982cfcb014eb45b0f23280f1770 Mon Sep 17 00:00:00 2001 From: nicktrn <55853254+nicktrn@users.noreply.github.com> Date: Wed, 20 Mar 2024 14:38:21 +0000 Subject: [PATCH] exit process after checkpointing --- apps/coordinator/src/index.ts | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/apps/coordinator/src/index.ts b/apps/coordinator/src/index.ts index 385f0b2a8..45d72023c 100644 --- a/apps/coordinator/src/index.ts +++ b/apps/coordinator/src/index.ts @@ -502,9 +502,12 @@ class TaskCoordinator { reason: { type: "RETRYING_AFTER_FAILURE", attemptNumber: execution.attempt.number, + // TODO: attach completion data here }, }); + // TODO: replace this with + // callback({ didCheckpoint: true, shouldExit: false }); confirmCompletion({ didCheckpoint: true, shouldExit: false }); }); @@ -537,6 +540,12 @@ class TaskCoordinator { return; } + if (!checkpoint.docker) { + socket.emit("REQUEST_EXIT", { + version: "v1", + }); + } + this.#platformSocket?.send("CHECKPOINT_CREATED", { version: "v1", attemptId: socket.data.attemptId, @@ -573,6 +582,12 @@ class TaskCoordinator { return; } + if (!checkpoint.docker) { + socket.emit("REQUEST_EXIT", { + version: "v1", + }); + } + this.#platformSocket?.send("CHECKPOINT_CREATED", { version: "v1", attemptId: socket.data.attemptId, @@ -609,6 +624,12 @@ class TaskCoordinator { return; } + if (!checkpoint.docker) { + socket.emit("REQUEST_EXIT", { + version: "v1", + }); + } + this.#platformSocket?.send("CHECKPOINT_CREATED", { version: "v1", attemptId: socket.data.attemptId,