From 0ed93a748eed0962be7ee61c72b706d6415ccc5c Mon Sep 17 00:00:00 2001 From: Eric Allam Date: Tue, 18 Jun 2024 11:48:30 +0100 Subject: [PATCH] v3: Remove aggressive otel flush timeouts in dev/prod --- .changeset/mighty-parrots-sin.md | 5 +++++ packages/core/src/v3/otel/tracingSDK.ts | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 .changeset/mighty-parrots-sin.md diff --git a/.changeset/mighty-parrots-sin.md b/.changeset/mighty-parrots-sin.md new file mode 100644 index 000000000..8f2e5db9d --- /dev/null +++ b/.changeset/mighty-parrots-sin.md @@ -0,0 +1,5 @@ +--- +"@trigger.dev/core": patch +--- + +v3: Remove aggressive otel flush timeouts in dev/prod diff --git a/packages/core/src/v3/otel/tracingSDK.ts b/packages/core/src/v3/otel/tracingSDK.ts index ce2b20f10..23bc8b1f6 100644 --- a/packages/core/src/v3/otel/tracingSDK.ts +++ b/packages/core/src/v3/otel/tracingSDK.ts @@ -119,7 +119,7 @@ export class TracingSDK { .merge(new Resource(envResourceAttributes)); const traceProvider = new NodeTracerProvider({ - forceFlushTimeoutMillis: config.forceFlushTimeoutMillis ?? 500, + forceFlushTimeoutMillis: config.forceFlushTimeoutMillis, resource: commonResources, spanLimits: { attributeCountLimit: OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT, @@ -133,7 +133,7 @@ export class TracingSDK { const spanExporter = new OTLPTraceExporter({ url: `${config.url}/v1/traces`, - timeoutMillis: config.forceFlushTimeoutMillis ?? 1000, + timeoutMillis: config.forceFlushTimeoutMillis, }); traceProvider.addSpanProcessor(