github-featured/strukto-ai--mirage
2
0
Fork 0
Code Issues Pull Requests Deployments Models Agent Notes Packages Projects Releases Wiki Activity

fix(gate): see exported and quoted rename maps, and selftest the patterns

Browse Source 
The rename gate matched only lines beginning with `const` and only bare
object keys, so `export const S3_BROWSER_RENAME` -- added in the same
change -- was invisible to it, as were `'api_key': 'apiKey'` and a
camelCase map name. A gate blind to a form in use is worse than no gate:
it reports success over the blind spot.

The const pattern now allows an `export` prefix and matches the name
case-insensitively; the pair pattern accepts a bare or quoted key in
either quote style. Sweeping the repo again with the wider patterns finds
nothing new, so the original sweep was complete.

`--selftest` carries one fixture per declaration form in use plus the
negatives, and runs ahead of the scan in CI. It fails on the old patterns
(4 of 10 cases) and passes on these.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
bytecii
2026-08-20 06:20:14 -07:00
parent ca89dc5970
commit 3f42dbaf6c
2 changed files with 77 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/pre-commit.yml
+7 -1
View File
@@ -98,8 +98,14 @@ jobs:
# configuration -- it is a second place for one fact to be wrong, and it
# buries the handful that are real overrides (`endpoint_url`, `timeout`,
# `aws_profile`) in a wall of noise. 95 had accumulated.
# --selftest first: the gate's own patterns are what it trusts, and the
# first version matched neither `export const` nor a quoted key, so it
# reported success over a blind spot. The fixtures cover every
# declaration form in use.
- name: Redundant config renames
run: ./python/.venv/bin/python scripts/check_normalize_renames.py
run: |
./python/.venv/bin/python scripts/check_normalize_renames.py --selftest
./python/.venv/bin/python scripts/check_normalize_renames.py
# The docs build parses frontmatter as YAML and stops on the first page
# it cannot read, so an unquoted description holding ": " fails the
scripts/check_normalize_renames.py
+70 -5
View File
@@ -10,12 +10,20 @@ TS_SRC = [
REPO / "typescript/packages/node/src",
REPO / "typescript/packages/browser/src",
]
# `normalizeFields(input, {rename: {...}})` and the shared `const RENAME`
# maps the S3-alias families feed it.
# `normalizeFields(input, {rename: {...}})` and the shared rename-map
# constants the S3-alias families feed it. The declaration matters as much
# as the map: `export const`, a type annotation between the name and the
# `=`, and a camelCase name are all forms in use, and a pattern that misses
# one lets a redundant entry through in silence -- which is exactly what
# `export const S3_BROWSER_RENAME` did to the first version of this gate.
RENAME_PROP_RE = re.compile(r"rename:\s*\{([^{}]*)\}", re.S)
RENAME_CONST_RE = re.compile(r"^const \w*RENAME\w*[^=\n]*=\s*\{([^{}]*)\}",
re.M | re.S)
PAIR_RE = re.compile(r"([A-Za-z0-9_]+)\s*:\s*'([A-Za-z0-9_]+)'")
RENAME_CONST_RE = re.compile(
r"^(?:export\s+)?const\s+\w*rename\w*[^=\n]*=\s*\{([^{}]*)\}",
re.M | re.S | re.I)
# The key may be bare or quoted (either style); the value is a string
# literal, so it is always quoted.
PAIR_RE = re.compile(
r"""['"]?([A-Za-z0-9_]+)['"]?\s*:\s*['"]([A-Za-z0-9_]+)['"]""")
SNAKE_RE = re.compile(r"_([a-z0-9])")
@@ -64,6 +72,61 @@ def source_files() -> list[Path]:
return sorted(out)
# One fixture per declaration form the codebase actually uses, plus the
# negatives. The first version of this gate matched only lines beginning
# with `const` and only bare keys, so `export const S3_BROWSER_RENAME` --
# added in the same change -- was invisible to it. A pattern this gate
# cannot see is worse than no gate: it reports success over a blind spot.
SELFTEST_CASES: tuple[tuple[str, str, bool], ...] = (
("a bare const map",
"const RENAME: Record<string, string> = {\n api_key: 'apiKey',\n}\n",
True),
("an exported const map",
"export const S3_RENAME: Record<string, string> = {\n"
" api_key: 'apiKey',\n}\n", True),
("a camelCase map name", "const renameMap = {\n api_key: 'apiKey',\n}\n",
True),
("a single-quoted key", "normalizeFields(input, {\n rename: {\n"
" 'api_key': 'apiKey',\n },\n})\n", True),
("a double-quoted key", 'normalizeFields(input, {\n rename: {\n'
' "api_key": "apiKey",\n },\n})\n', True),
("an inline rename property",
"normalizeFields(input, {\n rename: { api_key: 'apiKey' },\n})\n", True),
("a multi-line rename property", "normalizeFields(input, {\n rename: {\n"
" board_ids: 'boardIds',\n },\n})\n", True),
("a load-bearing override", "normalizeFields(input, {\n"
" rename: { endpoint_url: 'endpoint' },\n})\n", False),
("load-bearing overrides in a const",
"export const R = {\n timeout: 'timeoutMs',\n"
" aws_profile: 'profile',\n path_style: 'forcePathStyle',\n}\n", False),
("an object that is not a rename map", "const opts = { mode: 'fast' }\n",
False),
)
def selftest() -> int:
"""Prove the gate can see every declaration form before trusting it.
Returns:
0 when every fixture is classified as expected.
"""
failures = 0
for name, source, expected in SELFTEST_CASES:
found = bool(redundant_pairs(source))
if found == expected:
print(f" ok {name}")
continue
failures += 1
want = "flagged" if expected else "ignored"
print(f" FAIL {name}: should be {want}, was not")
if failures:
print(f"\n{failures} selftest case(s) failed; the gate is blind to "
"a form in use.")
return 1
print(f"\nselftest OK: {len(SELFTEST_CASES)} declaration forms covered")
return 0
def main() -> int:
"""Fail when a rename map restates what `snakeToCamel` already does.
@@ -76,6 +139,8 @@ def main() -> int:
Returns:
0 when every surviving rename entry is a real override.
"""
if "--selftest" in sys.argv[1:]:
return selftest()
offenders: list[tuple[Path, list[tuple[str, str]]]] = []
for path in source_files():
if path.name == "normalize.test.ts":