6bf8bebf51
CI / Test and Build (push) Failing after 1s
CI / Migrate Dev DB (push) Has been skipped
CI / Migrate DB (push) Has been skipped
CodeQL / Analyze actions (push) Has been cancelled
CodeQL / Analyze javascript-typescript (push) Has been cancelled
CI / Detect Version (push) Has been cancelled
CI / Detect Desktop Changes (push) Has been cancelled
CI / Build AMD64 (blacksmith-2vcpu-ubuntu-2404, ./docker/cron.Dockerfile, ubuntu-latest, ghcr.io/simstudioai/cron) (push) Has been cancelled
CI / Build AMD64 (blacksmith-2vcpu-ubuntu-2404, ./docker/db.Dockerfile, ECR_MIGRATIONS, ubuntu-latest, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build AMD64 (blacksmith-4vcpu-ubuntu-2404, ./docker/pii.Dockerfile, ECR_PII, ubuntu-latest, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build AMD64 (blacksmith-4vcpu-ubuntu-2404, ./docker/realtime.Dockerfile, ECR_REALTIME, ubuntu-latest, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Build AMD64 (blacksmith-8vcpu-ubuntu-2404, ./docker/app.Dockerfile, ECR_APP, linux-x64-8-core, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (blacksmith-4vcpu-ubuntu-2404-arm, ./docker/cron.Dockerfile, ubuntu-24.04-arm, ghcr.io/simstudioai/cron) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (blacksmith-4vcpu-ubuntu-2404-arm, ./docker/db.Dockerfile, ubuntu-24.04-arm, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (blacksmith-4vcpu-ubuntu-2404-arm, ./docker/pii.Dockerfile, ubuntu-24.04-arm, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (blacksmith-4vcpu-ubuntu-2404-arm, ./docker/realtime.Dockerfile, ubuntu-24.04-arm, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (blacksmith-8vcpu-ubuntu-2404-arm, ./docker/app.Dockerfile, linux-arm64-8-core, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Check Docs Changes (push) Has been cancelled
Publish CLI Package / publish-npm (push) Has been cancelled
Publish Python SDK / publish-pypi (push) Has been cancelled
CI / Deploy Trigger.dev (Dev) (push) Has been cancelled
Helm Chart / Lint, test, and validate chart (push) Has been cancelled
Helm Chart / Chart version bumped (push) Has been cancelled
Publish TypeScript SDK / publish-npm (push) Has been cancelled
CI / Build Dev ECR (blacksmith-8vcpu-ubuntu-2404, ./docker/app.Dockerfile, ECR_APP, linux-x64-8-core) (push) Has been cancelled
CI / Promote Images (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/cron) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Build Dev ECR (blacksmith-2vcpu-ubuntu-2404, ./docker/db.Dockerfile, ECR_MIGRATIONS, ubuntu-latest) (push) Has been cancelled
CI / Build Dev ECR (blacksmith-4vcpu-ubuntu-2404, ./docker/pii.Dockerfile, ECR_PII, ubuntu-latest) (push) Has been cancelled
CI / Build Dev ECR (blacksmith-4vcpu-ubuntu-2404, ./docker/realtime.Dockerfile, ECR_REALTIME, ubuntu-latest) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Process Docs (push) Has been cancelled
CI / Create GitHub Release (push) Has been cancelled
CI / Check Desktop Signing Secrets (push) Has been cancelled
CI / Desktop Release (push) Has been cancelled
CI / Create Desktop Prerelease (push) Has been cancelled
CI / Desktop Prerelease Build (push) Has been cancelled
CI / Publish Desktop Prerelease (push) Has been cancelled
CI / Prune Desktop Prereleases (push) Has been cancelled
Helm Chart / Install on kind and run helm test (push) Has been cancelled
317 lines
11 KiB
TypeScript
317 lines
11 KiB
TypeScript
/**
|
|
* @vitest-environment node
|
|
*/
|
|
import { dbChainMockFns, resetDbChainMock } from '@sim/testing'
|
|
import { afterAll, beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
const { mockChangeWorkspaceStoragePayerInTx } = vi.hoisted(() => ({
|
|
mockChangeWorkspaceStoragePayerInTx: vi.fn(),
|
|
}))
|
|
|
|
vi.mock('@/lib/billing/storage/payer-transfer', () => ({
|
|
changeWorkspaceStoragePayerInTx: mockChangeWorkspaceStoragePayerInTx,
|
|
}))
|
|
|
|
import {
|
|
listAccessibleWorkspaceRowsForUser,
|
|
reassignBilledAccountForUser,
|
|
reassignWorkflowOwnershipForWorkspaceMemberRemovalTx,
|
|
} from '@/lib/workspaces/utils'
|
|
|
|
afterAll(() => {
|
|
resetDbChainMock()
|
|
})
|
|
|
|
function createMockChain(finalResult: unknown) {
|
|
const chain: any = {}
|
|
chain.then = vi.fn().mockImplementation((resolve: any) => resolve(finalResult))
|
|
chain.from = vi.fn().mockReturnValue(chain)
|
|
chain.where = vi.fn().mockReturnValue(chain)
|
|
chain.innerJoin = vi.fn().mockReturnValue(chain)
|
|
chain.limit = vi.fn().mockReturnValue(chain)
|
|
chain.orderBy = vi.fn().mockReturnValue(chain)
|
|
return chain
|
|
}
|
|
|
|
function createSelectChain(result: unknown) {
|
|
const limit = vi.fn().mockResolvedValue(result)
|
|
const where = vi.fn().mockReturnValue({ limit })
|
|
const from = vi.fn().mockReturnValue({
|
|
where: vi.fn().mockResolvedValue(result),
|
|
limit,
|
|
})
|
|
|
|
return { from, where, limit }
|
|
}
|
|
|
|
function createGroupedSelectChain(result: unknown) {
|
|
const groupBy = vi.fn().mockResolvedValue(result)
|
|
const where = vi.fn().mockReturnValue({ groupBy })
|
|
const from = vi.fn().mockReturnValue({ where })
|
|
|
|
return { from, where, groupBy }
|
|
}
|
|
|
|
function createUpdateChain(result: unknown) {
|
|
const returning = vi.fn().mockResolvedValue(result)
|
|
const where = vi.fn().mockReturnValue({ returning })
|
|
const set = vi.fn().mockReturnValue({ where })
|
|
|
|
return { set, where, returning }
|
|
}
|
|
|
|
describe('reassignBilledAccountForUser', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
resetDbChainMock()
|
|
})
|
|
|
|
it('routes each resolved workspace through the payer helper in its own transaction', async () => {
|
|
const updateChain = createUpdateChain([])
|
|
const tx = {
|
|
update: vi.fn().mockReturnValue(updateChain),
|
|
}
|
|
dbChainMockFns.select.mockReturnValueOnce(
|
|
createMockChain([
|
|
{ id: 'workspace-personal', ownerId: 'owner-1', organizationId: null },
|
|
{ id: 'workspace-org', ownerId: 'owner-2', organizationId: 'org-1' },
|
|
])
|
|
)
|
|
dbChainMockFns.transaction.mockImplementation(
|
|
async (callback: (transaction: typeof tx) => Promise<unknown>) => callback(tx)
|
|
)
|
|
|
|
const result = await reassignBilledAccountForUser('departing-user')
|
|
|
|
expect(dbChainMockFns.transaction).toHaveBeenCalledTimes(2)
|
|
expect(mockChangeWorkspaceStoragePayerInTx).toHaveBeenNthCalledWith(1, tx, {
|
|
workspaceId: 'workspace-personal',
|
|
organizationId: null,
|
|
billedAccountUserId: 'owner-1',
|
|
expectedCurrentPayer: {
|
|
organizationId: null,
|
|
billedAccountUserId: 'departing-user',
|
|
},
|
|
})
|
|
expect(mockChangeWorkspaceStoragePayerInTx).toHaveBeenNthCalledWith(2, tx, {
|
|
workspaceId: 'workspace-org',
|
|
organizationId: 'org-1',
|
|
billedAccountUserId: 'owner-2',
|
|
expectedCurrentPayer: {
|
|
organizationId: 'org-1',
|
|
billedAccountUserId: 'departing-user',
|
|
},
|
|
})
|
|
expect(updateChain.set).toHaveBeenCalledTimes(2)
|
|
expect(updateChain.set).toHaveBeenCalledWith({ updatedAt: expect.any(Date) })
|
|
expect(result).toEqual({
|
|
reassigned: [
|
|
{ workspaceId: 'workspace-personal', newBilledAccountUserId: 'owner-1' },
|
|
{ workspaceId: 'workspace-org', newBilledAccountUserId: 'owner-2' },
|
|
],
|
|
unresolved: [],
|
|
})
|
|
})
|
|
|
|
it('preserves the admin fallback and unresolved behavior', async () => {
|
|
const updateChain = createUpdateChain([])
|
|
const tx = {
|
|
update: vi.fn().mockReturnValue(updateChain),
|
|
}
|
|
dbChainMockFns.select
|
|
.mockReturnValueOnce(
|
|
createMockChain([
|
|
{ id: 'workspace-admin', ownerId: 'departing-user', organizationId: null },
|
|
{ id: 'workspace-unresolved', ownerId: 'departing-user', organizationId: null },
|
|
])
|
|
)
|
|
.mockReturnValueOnce(createMockChain([{ userId: 'admin-1' }]))
|
|
.mockReturnValueOnce(createMockChain([]))
|
|
dbChainMockFns.transaction.mockImplementation(
|
|
async (callback: (transaction: typeof tx) => Promise<unknown>) => callback(tx)
|
|
)
|
|
|
|
const result = await reassignBilledAccountForUser('departing-user')
|
|
|
|
expect(mockChangeWorkspaceStoragePayerInTx).toHaveBeenCalledTimes(1)
|
|
expect(mockChangeWorkspaceStoragePayerInTx).toHaveBeenCalledWith(
|
|
tx,
|
|
expect.objectContaining({
|
|
workspaceId: 'workspace-admin',
|
|
billedAccountUserId: 'admin-1',
|
|
})
|
|
)
|
|
expect(result).toEqual({
|
|
reassigned: [{ workspaceId: 'workspace-admin', newBilledAccountUserId: 'admin-1' }],
|
|
unresolved: ['workspace-unresolved'],
|
|
})
|
|
})
|
|
|
|
it('stops the loop and propagates payer-transfer errors', async () => {
|
|
const updateChain = createUpdateChain([])
|
|
const tx = {
|
|
update: vi.fn().mockReturnValue(updateChain),
|
|
}
|
|
dbChainMockFns.select.mockReturnValueOnce(
|
|
createMockChain([
|
|
{ id: 'workspace-1', ownerId: 'owner-1', organizationId: null },
|
|
{ id: 'workspace-2', ownerId: 'owner-2', organizationId: null },
|
|
])
|
|
)
|
|
dbChainMockFns.transaction.mockImplementation(
|
|
async (callback: (transaction: typeof tx) => Promise<unknown>) => callback(tx)
|
|
)
|
|
mockChangeWorkspaceStoragePayerInTx.mockRejectedValueOnce(new Error('payer transfer failed'))
|
|
|
|
await expect(reassignBilledAccountForUser('departing-user')).rejects.toThrow(
|
|
'payer transfer failed'
|
|
)
|
|
|
|
expect(dbChainMockFns.transaction).toHaveBeenCalledTimes(1)
|
|
expect(mockChangeWorkspaceStoragePayerInTx).toHaveBeenCalledTimes(1)
|
|
expect(tx.update).not.toHaveBeenCalled()
|
|
})
|
|
})
|
|
|
|
describe('reassignWorkflowOwnershipForWorkspaceMemberRemovalTx', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
resetDbChainMock()
|
|
})
|
|
|
|
it('reassigns departing member workflows to the workspace billed account', async () => {
|
|
const workspaceSelect = createSelectChain([
|
|
{ id: 'workspace-1', billedAccountUserId: 'billed-1' },
|
|
])
|
|
const workflowCountSelect = createGroupedSelectChain([
|
|
{ workspaceId: 'workspace-1', workflowCount: 2 },
|
|
])
|
|
const workflowUpdate = createUpdateChain([])
|
|
const tx = {
|
|
select: vi.fn().mockReturnValueOnce(workspaceSelect).mockReturnValueOnce(workflowCountSelect),
|
|
update: vi.fn().mockReturnValue(workflowUpdate),
|
|
}
|
|
|
|
const result = await reassignWorkflowOwnershipForWorkspaceMemberRemovalTx({
|
|
tx: tx as any,
|
|
workspaceIds: ['workspace-1'],
|
|
departingUserId: 'departing-1',
|
|
})
|
|
|
|
expect(tx.update).toHaveBeenCalledTimes(1)
|
|
expect(workflowUpdate.set).toHaveBeenCalledWith(
|
|
expect.objectContaining({ updatedAt: expect.any(Date) })
|
|
)
|
|
expect(result).toEqual({
|
|
reassigned: [{ workspaceId: 'workspace-1', newWorkflowUserId: 'billed-1', workflowCount: 2 }],
|
|
unresolved: [],
|
|
})
|
|
})
|
|
|
|
it('marks a workspace unresolved when the departing member is the billed account', async () => {
|
|
const workspaceSelect = createSelectChain([
|
|
{ id: 'workspace-1', billedAccountUserId: 'departing-1' },
|
|
])
|
|
const workflowCountSelect = createGroupedSelectChain([
|
|
{ workspaceId: 'workspace-1', workflowCount: 1 },
|
|
])
|
|
const tx = {
|
|
select: vi.fn().mockReturnValueOnce(workspaceSelect).mockReturnValueOnce(workflowCountSelect),
|
|
update: vi.fn(),
|
|
}
|
|
|
|
const result = await reassignWorkflowOwnershipForWorkspaceMemberRemovalTx({
|
|
tx: tx as any,
|
|
workspaceIds: ['workspace-1'],
|
|
departingUserId: 'departing-1',
|
|
})
|
|
|
|
expect(tx.update).not.toHaveBeenCalled()
|
|
expect(result).toEqual({ reassigned: [], unresolved: ['workspace-1'] })
|
|
})
|
|
|
|
it('does not mark a workspace unresolved when the departing billing account owns no workflows', async () => {
|
|
const workspaceSelect = createSelectChain([
|
|
{ id: 'workspace-1', billedAccountUserId: 'departing-1' },
|
|
])
|
|
const workflowCountSelect = createGroupedSelectChain([])
|
|
const tx = {
|
|
select: vi.fn().mockReturnValueOnce(workspaceSelect).mockReturnValueOnce(workflowCountSelect),
|
|
update: vi.fn(),
|
|
}
|
|
|
|
const result = await reassignWorkflowOwnershipForWorkspaceMemberRemovalTx({
|
|
tx: tx as any,
|
|
workspaceIds: ['workspace-1'],
|
|
departingUserId: 'departing-1',
|
|
})
|
|
|
|
expect(tx.update).not.toHaveBeenCalled()
|
|
expect(result).toEqual({ reassigned: [], unresolved: [] })
|
|
})
|
|
|
|
it('marks a workspace unresolved when no billed account is configured', async () => {
|
|
const workspaceSelect = createSelectChain([{ id: 'workspace-1', billedAccountUserId: null }])
|
|
const workflowCountSelect = createGroupedSelectChain([
|
|
{ workspaceId: 'workspace-1', workflowCount: 1 },
|
|
])
|
|
const tx = {
|
|
select: vi.fn().mockReturnValueOnce(workspaceSelect).mockReturnValueOnce(workflowCountSelect),
|
|
update: vi.fn(),
|
|
}
|
|
|
|
const result = await reassignWorkflowOwnershipForWorkspaceMemberRemovalTx({
|
|
tx: tx as any,
|
|
workspaceIds: ['workspace-1'],
|
|
departingUserId: 'departing-1',
|
|
})
|
|
|
|
expect(tx.update).not.toHaveBeenCalled()
|
|
expect(result).toEqual({ reassigned: [], unresolved: ['workspace-1'] })
|
|
})
|
|
})
|
|
|
|
describe('listAccessibleWorkspaceRowsForUser', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
resetDbChainMock()
|
|
})
|
|
|
|
it('elevates an org admin to admin on an org workspace where they hold a lower explicit grant', async () => {
|
|
const orgWorkspace = { id: 'ws-1', name: 'Shared', ownerId: 'owner-x', organizationId: 'org-1' }
|
|
|
|
dbChainMockFns.select
|
|
.mockReturnValueOnce(createMockChain([{ workspace: orgWorkspace, permissionType: 'write' }]))
|
|
.mockReturnValueOnce(createMockChain([{ organizationId: 'org-1', role: 'admin' }]))
|
|
.mockReturnValueOnce(createMockChain([orgWorkspace]))
|
|
|
|
const rows = await listAccessibleWorkspaceRowsForUser('user-1', 'active')
|
|
|
|
expect(rows).toEqual([{ workspace: orgWorkspace, permissionType: 'admin' }])
|
|
})
|
|
|
|
it('keeps a lower explicit grant on a workspace owned by a different organization', async () => {
|
|
const externalWorkspace = {
|
|
id: 'ws-ext',
|
|
name: 'External',
|
|
ownerId: 'owner-y',
|
|
organizationId: 'org-2',
|
|
}
|
|
const orgWorkspace = { id: 'ws-1', name: 'Shared', ownerId: 'owner-x', organizationId: 'org-1' }
|
|
|
|
dbChainMockFns.select
|
|
.mockReturnValueOnce(
|
|
createMockChain([{ workspace: externalWorkspace, permissionType: 'write' }])
|
|
)
|
|
.mockReturnValueOnce(createMockChain([{ organizationId: 'org-1', role: 'admin' }]))
|
|
.mockReturnValueOnce(createMockChain([orgWorkspace]))
|
|
|
|
const rows = await listAccessibleWorkspaceRowsForUser('user-1', 'active')
|
|
|
|
expect(rows).toEqual([
|
|
{ workspace: externalWorkspace, permissionType: 'write' },
|
|
{ workspace: orgWorkspace, permissionType: 'admin' },
|
|
])
|
|
})
|
|
})
|