6bf8bebf51
CI / Test and Build (push) Failing after 1s
CI / Migrate Dev DB (push) Has been skipped
CI / Migrate DB (push) Has been skipped
CodeQL / Analyze actions (push) Has been cancelled
CodeQL / Analyze javascript-typescript (push) Has been cancelled
CI / Detect Version (push) Has been cancelled
CI / Detect Desktop Changes (push) Has been cancelled
CI / Build AMD64 (blacksmith-2vcpu-ubuntu-2404, ./docker/cron.Dockerfile, ubuntu-latest, ghcr.io/simstudioai/cron) (push) Has been cancelled
CI / Build AMD64 (blacksmith-2vcpu-ubuntu-2404, ./docker/db.Dockerfile, ECR_MIGRATIONS, ubuntu-latest, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build AMD64 (blacksmith-4vcpu-ubuntu-2404, ./docker/pii.Dockerfile, ECR_PII, ubuntu-latest, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build AMD64 (blacksmith-4vcpu-ubuntu-2404, ./docker/realtime.Dockerfile, ECR_REALTIME, ubuntu-latest, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Build AMD64 (blacksmith-8vcpu-ubuntu-2404, ./docker/app.Dockerfile, ECR_APP, linux-x64-8-core, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (blacksmith-4vcpu-ubuntu-2404-arm, ./docker/cron.Dockerfile, ubuntu-24.04-arm, ghcr.io/simstudioai/cron) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (blacksmith-4vcpu-ubuntu-2404-arm, ./docker/db.Dockerfile, ubuntu-24.04-arm, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (blacksmith-4vcpu-ubuntu-2404-arm, ./docker/pii.Dockerfile, ubuntu-24.04-arm, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (blacksmith-4vcpu-ubuntu-2404-arm, ./docker/realtime.Dockerfile, ubuntu-24.04-arm, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (blacksmith-8vcpu-ubuntu-2404-arm, ./docker/app.Dockerfile, linux-arm64-8-core, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Check Docs Changes (push) Has been cancelled
Publish CLI Package / publish-npm (push) Has been cancelled
Publish Python SDK / publish-pypi (push) Has been cancelled
CI / Deploy Trigger.dev (Dev) (push) Has been cancelled
Helm Chart / Lint, test, and validate chart (push) Has been cancelled
Helm Chart / Chart version bumped (push) Has been cancelled
Publish TypeScript SDK / publish-npm (push) Has been cancelled
CI / Build Dev ECR (blacksmith-8vcpu-ubuntu-2404, ./docker/app.Dockerfile, ECR_APP, linux-x64-8-core) (push) Has been cancelled
CI / Promote Images (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/cron) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Build Dev ECR (blacksmith-2vcpu-ubuntu-2404, ./docker/db.Dockerfile, ECR_MIGRATIONS, ubuntu-latest) (push) Has been cancelled
CI / Build Dev ECR (blacksmith-4vcpu-ubuntu-2404, ./docker/pii.Dockerfile, ECR_PII, ubuntu-latest) (push) Has been cancelled
CI / Build Dev ECR (blacksmith-4vcpu-ubuntu-2404, ./docker/realtime.Dockerfile, ECR_REALTIME, ubuntu-latest) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Process Docs (push) Has been cancelled
CI / Create GitHub Release (push) Has been cancelled
CI / Check Desktop Signing Secrets (push) Has been cancelled
CI / Desktop Release (push) Has been cancelled
CI / Create Desktop Prerelease (push) Has been cancelled
CI / Desktop Prerelease Build (push) Has been cancelled
CI / Publish Desktop Prerelease (push) Has been cancelled
CI / Prune Desktop Prereleases (push) Has been cancelled
Helm Chart / Install on kind and run helm test (push) Has been cancelled
73 lines
2.4 KiB
TypeScript
73 lines
2.4 KiB
TypeScript
/**
|
|
* @vitest-environment node
|
|
*/
|
|
import { Readable } from 'stream'
|
|
import type { SFTPWrapper } from 'ssh2'
|
|
import { describe, expect, it, vi } from 'vitest'
|
|
import { isPayloadSizeLimitError } from '@/lib/core/utils/stream-limits'
|
|
import { MAX_SFTP_READ_BYTES, readSftpFileCapped } from '@/app/api/tools/sftp/utils'
|
|
|
|
/**
|
|
* Builds a fake SFTP wrapper whose read stream emits `chunkCount` chunks of
|
|
* `chunkSize` bytes — the shape of a malicious server that understates the
|
|
* file size in its stat reply and then streams unbounded data.
|
|
*/
|
|
function fakeSftp(chunkSize: number, chunkCount: number) {
|
|
let emitted = 0
|
|
const stream = new Readable({
|
|
read() {
|
|
if (emitted >= chunkCount) {
|
|
this.push(null)
|
|
return
|
|
}
|
|
emitted++
|
|
this.push(Buffer.alloc(chunkSize, 0x41))
|
|
},
|
|
})
|
|
const createReadStream = vi.fn(() => stream)
|
|
return { sftp: { createReadStream } as unknown as SFTPWrapper, stream, createReadStream }
|
|
}
|
|
|
|
describe('readSftpFileCapped', () => {
|
|
it('resolves with the full contents when under the cap', async () => {
|
|
const { sftp, createReadStream } = fakeSftp(4, 3)
|
|
|
|
const buffer = await readSftpFileCapped(sftp, '/file', 1024, 'file')
|
|
|
|
expect(buffer.toString()).toBe('A'.repeat(12))
|
|
expect(createReadStream).toHaveBeenCalledWith('/file')
|
|
})
|
|
|
|
it('rejects and destroys the stream once received bytes exceed the cap', async () => {
|
|
const { sftp, stream } = fakeSftp(8, 1_000_000)
|
|
|
|
await expect(readSftpFileCapped(sftp, '/bomb', 16, 'file')).rejects.toSatisfy(
|
|
isPayloadSizeLimitError
|
|
)
|
|
expect(stream.destroyed).toBe(true)
|
|
})
|
|
|
|
it('enforces the cap on actual bytes even when the file was reported as tiny', async () => {
|
|
const { sftp, stream } = fakeSftp(1024, 1_000_000)
|
|
|
|
await expect(readSftpFileCapped(sftp, '/bomb', 4096, 'file')).rejects.toThrow(
|
|
/exceeds maximum size of 4096 bytes/
|
|
)
|
|
expect(stream.destroyed).toBe(true)
|
|
})
|
|
|
|
it('survives the late stream error ssh2 emits when the channel closes after an abort', async () => {
|
|
const { sftp, stream } = fakeSftp(8, 1_000_000)
|
|
|
|
await expect(readSftpFileCapped(sftp, '/bomb', 16, 'file')).rejects.toSatisfy(
|
|
isPayloadSizeLimitError
|
|
)
|
|
|
|
expect(() => stream.emit('error', new Error('No response from server'))).not.toThrow()
|
|
})
|
|
|
|
it('caps remote reads at 50MB', () => {
|
|
expect(MAX_SFTP_READ_BYTES).toBe(50 * 1024 * 1024)
|
|
})
|
|
})
|