6bf8bebf51
CI / Test and Build (push) Failing after 1s
CI / Migrate Dev DB (push) Has been skipped
CI / Migrate DB (push) Has been skipped
CodeQL / Analyze actions (push) Has been cancelled
CodeQL / Analyze javascript-typescript (push) Has been cancelled
CI / Detect Version (push) Has been cancelled
CI / Detect Desktop Changes (push) Has been cancelled
CI / Build AMD64 (blacksmith-2vcpu-ubuntu-2404, ./docker/cron.Dockerfile, ubuntu-latest, ghcr.io/simstudioai/cron) (push) Has been cancelled
CI / Build AMD64 (blacksmith-2vcpu-ubuntu-2404, ./docker/db.Dockerfile, ECR_MIGRATIONS, ubuntu-latest, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build AMD64 (blacksmith-4vcpu-ubuntu-2404, ./docker/pii.Dockerfile, ECR_PII, ubuntu-latest, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build AMD64 (blacksmith-4vcpu-ubuntu-2404, ./docker/realtime.Dockerfile, ECR_REALTIME, ubuntu-latest, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Build AMD64 (blacksmith-8vcpu-ubuntu-2404, ./docker/app.Dockerfile, ECR_APP, linux-x64-8-core, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (blacksmith-4vcpu-ubuntu-2404-arm, ./docker/cron.Dockerfile, ubuntu-24.04-arm, ghcr.io/simstudioai/cron) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (blacksmith-4vcpu-ubuntu-2404-arm, ./docker/db.Dockerfile, ubuntu-24.04-arm, ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (blacksmith-4vcpu-ubuntu-2404-arm, ./docker/pii.Dockerfile, ubuntu-24.04-arm, ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (blacksmith-4vcpu-ubuntu-2404-arm, ./docker/realtime.Dockerfile, ubuntu-24.04-arm, ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Build ARM64 (GHCR Only) (blacksmith-8vcpu-ubuntu-2404-arm, ./docker/app.Dockerfile, linux-arm64-8-core, ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Check Docs Changes (push) Has been cancelled
Publish CLI Package / publish-npm (push) Has been cancelled
Publish Python SDK / publish-pypi (push) Has been cancelled
CI / Deploy Trigger.dev (Dev) (push) Has been cancelled
Helm Chart / Lint, test, and validate chart (push) Has been cancelled
Helm Chart / Chart version bumped (push) Has been cancelled
Publish TypeScript SDK / publish-npm (push) Has been cancelled
CI / Build Dev ECR (blacksmith-8vcpu-ubuntu-2404, ./docker/app.Dockerfile, ECR_APP, linux-x64-8-core) (push) Has been cancelled
CI / Promote Images (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/cron) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/migrations) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/pii) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/realtime) (push) Has been cancelled
CI / Build Dev ECR (blacksmith-2vcpu-ubuntu-2404, ./docker/db.Dockerfile, ECR_MIGRATIONS, ubuntu-latest) (push) Has been cancelled
CI / Build Dev ECR (blacksmith-4vcpu-ubuntu-2404, ./docker/pii.Dockerfile, ECR_PII, ubuntu-latest) (push) Has been cancelled
CI / Build Dev ECR (blacksmith-4vcpu-ubuntu-2404, ./docker/realtime.Dockerfile, ECR_REALTIME, ubuntu-latest) (push) Has been cancelled
CI / Create GHCR Manifests (ghcr.io/simstudioai/simstudio) (push) Has been cancelled
CI / Process Docs (push) Has been cancelled
CI / Create GitHub Release (push) Has been cancelled
CI / Check Desktop Signing Secrets (push) Has been cancelled
CI / Desktop Release (push) Has been cancelled
CI / Create Desktop Prerelease (push) Has been cancelled
CI / Desktop Prerelease Build (push) Has been cancelled
CI / Publish Desktop Prerelease (push) Has been cancelled
CI / Prune Desktop Prereleases (push) Has been cancelled
Helm Chart / Install on kind and run helm test (push) Has been cancelled
122 lines
4.1 KiB
TypeScript
122 lines
4.1 KiB
TypeScript
/**
|
|
* @vitest-environment node
|
|
*/
|
|
import { resetEnvFlagsMock, setEnvFlags } from '@sim/testing'
|
|
import { afterAll, beforeEach, describe, expect, it, vi } from 'vitest'
|
|
|
|
const { mockDnsLookup } = vi.hoisted(() => ({
|
|
mockDnsLookup: vi.fn(),
|
|
}))
|
|
|
|
vi.mock('dns/promises', () => ({
|
|
default: { lookup: mockDnsLookup },
|
|
}))
|
|
|
|
import { validateConnectServerUrl } from '@/app/api/tools/onepassword/utils'
|
|
|
|
afterAll(resetEnvFlagsMock)
|
|
|
|
describe('validateConnectServerUrl', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
setEnvFlags({ isHosted: false })
|
|
})
|
|
|
|
it('rejects a non-URL string', async () => {
|
|
await expect(validateConnectServerUrl('not a url')).rejects.toThrow('is not a valid URL')
|
|
})
|
|
|
|
describe('hosted deployment', () => {
|
|
beforeEach(() => {
|
|
setEnvFlags({ isHosted: true })
|
|
})
|
|
|
|
it.each([
|
|
['loopback', 'http://127.0.0.1:8080'],
|
|
['RFC1918 10.x', 'http://10.0.0.5'],
|
|
['RFC1918 192.168.x', 'http://192.168.1.1:8443'],
|
|
['RFC1918 172.16.x', 'http://172.16.0.9'],
|
|
['link-local metadata', 'http://169.254.169.254'],
|
|
['IPv4-mapped IPv6 private', 'http://[::ffff:10.0.0.1]'],
|
|
['IPv6 loopback', 'http://[::1]'],
|
|
])('blocks %s', async (_label, url) => {
|
|
await expect(validateConnectServerUrl(url)).rejects.toThrow(
|
|
'cannot point to a private or reserved IP address'
|
|
)
|
|
})
|
|
|
|
it('allows a public IP literal', async () => {
|
|
await expect(validateConnectServerUrl('https://8.8.8.8')).resolves.toBe('8.8.8.8')
|
|
})
|
|
|
|
it('blocks a hostname that resolves to a private IP', async () => {
|
|
mockDnsLookup.mockResolvedValue([{ address: '10.1.2.3', family: 4 }])
|
|
await expect(validateConnectServerUrl('https://connect.internal')).rejects.toThrow(
|
|
'cannot point to a private or reserved IP address'
|
|
)
|
|
})
|
|
|
|
it('allows a hostname that resolves to a public IP', async () => {
|
|
mockDnsLookup.mockResolvedValue([{ address: '93.184.216.34', family: 4 }])
|
|
await expect(validateConnectServerUrl('https://connect.example.com')).resolves.toBe(
|
|
'93.184.216.34'
|
|
)
|
|
})
|
|
|
|
it('prefers the IPv4 address for a dual-stack host (avoids unreachable IPv6 pin)', async () => {
|
|
mockDnsLookup.mockResolvedValue([
|
|
{ address: '2606:4700::6810:85e5', family: 6 },
|
|
{ address: '93.184.216.34', family: 4 },
|
|
])
|
|
await expect(validateConnectServerUrl('https://connect.example.com')).resolves.toBe(
|
|
'93.184.216.34'
|
|
)
|
|
})
|
|
|
|
it('pins the sole IPv6 address for an IPv6-only host', async () => {
|
|
mockDnsLookup.mockResolvedValue([{ address: '2606:4700::6810:85e5', family: 6 }])
|
|
await expect(validateConnectServerUrl('https://connect.example.com')).resolves.toBe(
|
|
'2606:4700::6810:85e5'
|
|
)
|
|
})
|
|
})
|
|
|
|
describe('self-hosted deployment', () => {
|
|
beforeEach(() => {
|
|
setEnvFlags({ isHosted: false })
|
|
})
|
|
|
|
it.each([
|
|
['loopback', 'http://127.0.0.1:8080', '127.0.0.1'],
|
|
['RFC1918 10.x', 'http://10.0.0.5', '10.0.0.5'],
|
|
['RFC1918 192.168.x', 'http://192.168.1.1:8443', '192.168.1.1'],
|
|
])('allows %s (private Connect server)', async (_label, url, expected) => {
|
|
await expect(validateConnectServerUrl(url)).resolves.toBe(expected)
|
|
})
|
|
|
|
it('still blocks link-local metadata', async () => {
|
|
await expect(validateConnectServerUrl('http://169.254.169.254')).rejects.toThrow(
|
|
'cannot point to a link-local address'
|
|
)
|
|
})
|
|
|
|
it('still blocks IPv6 link-local', async () => {
|
|
await expect(validateConnectServerUrl('http://[fe80::1]')).rejects.toThrow(
|
|
'cannot point to a link-local address'
|
|
)
|
|
})
|
|
|
|
it('allows a hostname that resolves to a private IP', async () => {
|
|
mockDnsLookup.mockResolvedValue([{ address: '10.1.2.3', family: 4 }])
|
|
await expect(validateConnectServerUrl('https://connect.internal')).resolves.toBe('10.1.2.3')
|
|
})
|
|
})
|
|
|
|
it('rejects when DNS resolution fails', async () => {
|
|
mockDnsLookup.mockRejectedValue(new Error('ENOTFOUND'))
|
|
await expect(validateConnectServerUrl('https://nope.invalid')).rejects.toThrow(
|
|
'could not be resolved'
|
|
)
|
|
})
|
|
})
|