Alexandre Catarino
8bcd588602
Regression Tests / build (push) Has been cancelled
Python Virtual Environments / build (push) Has been cancelled
Benchmarks / build (push) Has been cancelled
Build & Test Lean / build (push) Has been cancelled
Research Regression Tests / build (push) Has been cancelled
Fixes EquityFillModel.FillModel ( #7005 )
...
* Adds Unit Tests
The `LimitFill` method should not fill using `QuoteBar` or `Tick` with `TickType.Quote` type.
Adds missing test for tick data (`TickType.Trade`).
* Fixes EquityFillModel.FillModel
Use `Tick` with `TickType.Trade` or `TradeBar` information to fill limit orders.
* Update Regression Test Expected Statistics
The regression tests changed because of different fills.
The `ExtendedMarketTradingRegressionAlgorithm` has different number of trades because of an extra fill on the 4th order generated by TradeBar with a Low lower than than the QuoteBar.Ask Low:
> 20230222 13:56:24.251 TRACE:: Log: Time: 10/10/2013 12:01:00 OrderID: 4 EventID: 2 Symbol: SPY Status: Filled Quantity: 10 FillQuantity: 10 FillPrice: 143.8998 USD
> asset.Cache.GetData<QuoteBar>().ToString()
"SPY: Bid: O: 144.2457 Bid: H: 144.2629 Bid: **L: 144.2457** Bid: C: 144.2629 Ask: O: 144.2543 Ask: H: 144.2889 Ask: **L: 144.2543** Ask: C: 144.2889 "
> asset.Cache.GetData<TradeBar>().ToString()
"SPY: O: 144.2543 H: 144.4532 **L: 143.4156** C: 144.2716 V: 75423"
* Improves Tick Resolution Unit Test
* Fixes Tick Resolution Case Handling
`master` only considers the latest trade, missing possible fills in the batch of trades.
* Adds Unit Test for Gap
See https://github.com/QuantConnect/Lean/issues/963
* Addresses Fill Optimistic Assumption
If we have a bar that gaps in our favor, we accept the limit price to avoid optimitic fills.
* Fixes Regression Tests
All regression tests with limit orders have worst performance after we remove the optimitic assumption, and use the limit price instead.
2023-02-24 10:35:34 -03:00
..
2022-09-19 13:17:18 -03:00
2022-09-16 17:32:28 -03:00
2022-09-07 21:32:51 -03:00
2022-08-18 18:35:49 -03:00
2022-09-02 12:33:50 -03:00
2022-09-02 12:33:50 -03:00
2023-01-16 16:10:07 -03:00
2022-12-06 14:30:40 -03:00
2023-01-16 16:10:07 -03:00
2023-02-24 10:14:55 -03:00
2022-09-02 12:33:50 -03:00
2022-12-06 14:30:40 -03:00
2023-02-24 10:14:55 -03:00
2022-07-01 12:20:45 -03:00
2023-01-16 16:10:07 -03:00
2023-01-16 16:10:07 -03:00
2023-02-24 10:14:55 -03:00
2023-02-09 19:25:27 -03:00
2023-02-09 19:25:27 -03:00
2022-07-01 12:20:45 -03:00
2023-01-16 16:10:07 -03:00
2023-01-16 16:10:07 -03:00
2023-01-16 16:10:07 -03:00
2023-01-16 16:10:07 -03:00
2022-09-02 12:33:50 -03:00
2022-09-02 12:33:50 -03:00
2022-09-02 12:33:50 -03:00
2023-01-16 16:10:07 -03:00
2022-09-02 12:33:50 -03:00
2023-01-16 16:10:07 -03:00
2023-01-16 16:10:07 -03:00
2023-02-16 17:35:10 -03:00
2023-02-16 17:35:10 -03:00
2023-02-16 17:35:10 -03:00
2023-02-16 17:35:10 -03:00
2023-02-16 17:35:10 -03:00
2022-09-19 13:16:54 -03:00
2022-09-19 13:16:54 -03:00
2022-08-15 10:52:07 -03:00
2022-08-15 10:52:07 -03:00
2023-01-06 17:58:43 -03:00
2022-08-15 10:52:07 -03:00
2022-12-06 14:30:40 -03:00
2022-12-06 14:30:40 -03:00
2022-12-06 14:30:40 -03:00
2022-08-15 10:52:07 -03:00
2023-01-06 17:58:43 -03:00
2022-08-15 10:52:07 -03:00
2023-02-16 17:35:10 -03:00
2023-02-16 17:35:10 -03:00
2022-06-02 17:31:38 -03:00
2022-06-02 17:31:38 -03:00
2022-08-15 10:52:07 -03:00
2023-01-06 17:58:43 -03:00
2023-01-13 18:02:25 -03:00
2023-01-06 17:58:43 -03:00
2023-01-13 18:02:25 -03:00
2023-01-13 18:02:25 -03:00
2023-02-13 16:01:30 -03:00
2023-01-16 16:10:07 -03:00
2023-01-16 16:10:07 -03:00
2022-09-02 12:33:50 -03:00
2022-09-02 12:33:50 -03:00
2023-01-16 16:10:07 -03:00
2023-01-16 16:10:07 -03:00
2023-02-14 20:09:59 -03:00
2023-01-26 18:22:34 -08:00
2023-01-16 21:11:08 -03:00
2022-08-17 10:23:40 -03:00
2023-02-09 19:25:27 -03:00
2023-02-09 19:25:27 -03:00
2022-09-07 14:53:05 -03:00
2022-09-07 14:53:05 -03:00
2022-09-07 14:53:05 -03:00
2023-02-20 16:21:37 -03:00
2023-02-06 07:57:55 -08:00
2022-06-28 15:11:04 -03:00
2022-06-03 19:47:39 -03:00
2023-02-24 10:14:55 -03:00
2023-02-13 15:56:48 -03:00
2023-02-16 17:35:10 -03:00
2023-01-16 16:10:07 -03:00
2023-01-16 16:10:07 -03:00
2023-02-16 17:35:10 -03:00
2023-01-16 16:10:07 -03:00
2023-01-16 16:10:07 -03:00
2022-09-16 17:32:28 -03:00
2023-01-03 18:37:00 -03:00
2022-08-17 10:39:57 -07:00
2022-08-17 10:39:57 -07:00
2023-02-24 10:14:55 -03:00
2023-01-16 16:10:07 -03:00
2022-09-07 21:32:51 -03:00
2023-02-16 17:35:10 -03:00
2023-02-24 10:35:34 -03:00
2023-02-24 10:14:55 -03:00
2022-08-18 10:56:44 -03:00
2023-01-16 16:10:07 -03:00
2023-01-16 16:10:07 -03:00
2023-01-16 16:10:07 -03:00
2023-01-16 16:10:07 -03:00
2022-10-14 15:13:59 -03:00
2022-12-06 14:30:40 -03:00
2022-12-06 14:30:40 -03:00
2022-12-06 14:30:40 -03:00
2022-12-06 14:30:40 -03:00
2022-08-18 18:35:49 -03:00
2022-08-18 18:35:49 -03:00
2023-01-16 16:10:07 -03:00
2022-12-06 14:30:40 -03:00
2022-12-06 14:30:40 -03:00
2022-12-06 14:30:40 -03:00
2022-12-06 14:30:40 -03:00
2022-12-06 14:30:40 -03:00
2022-12-06 14:30:40 -03:00
2022-12-06 14:30:40 -03:00
2023-01-16 16:10:07 -03:00
2022-08-18 10:56:44 -03:00
2023-01-16 16:10:07 -03:00
2022-08-11 18:45:00 -03:00
2022-05-31 10:03:56 -03:00
2022-08-30 19:03:11 -03:00
2022-07-05 13:14:08 -03:00
2023-01-16 16:10:07 -03:00
2023-01-16 16:10:07 -03:00
2023-01-16 16:10:07 -03:00
2023-02-09 16:06:12 -03:00
2023-02-09 16:07:00 -03:00
2023-02-09 16:07:43 -03:00
2023-02-09 16:10:14 -03:00
2023-02-16 17:35:10 -03:00
2023-02-10 10:42:07 -03:00
2023-02-02 12:33:17 -08:00
2023-02-16 17:35:10 -03:00
2023-02-16 17:35:10 -03:00
2023-02-16 17:35:10 -03:00
2023-02-02 12:26:34 -08:00
2023-02-10 10:42:40 -03:00
2023-02-10 10:44:47 -03:00
2023-02-16 17:35:10 -03:00
2023-02-16 17:35:10 -03:00
2023-02-16 17:35:10 -03:00
2023-02-16 17:35:10 -03:00
2023-02-16 17:35:10 -03:00
2023-02-16 17:35:10 -03:00
2023-02-10 13:12:13 -03:00
2023-02-16 17:35:10 -03:00
2023-01-09 14:21:16 -03:00
2023-02-24 10:35:34 -03:00
2022-06-08 10:35:47 -03:00
2022-09-02 12:33:50 -03:00
2022-09-07 14:53:05 -03:00
2022-12-08 19:46:58 -03:00
2022-12-08 19:46:58 -03:00
2022-09-02 12:33:50 -03:00
2022-08-04 11:20:11 -03:00
2022-06-15 13:47:00 -03:00
2023-02-06 13:50:59 -08:00
2023-02-14 12:09:27 -03:00
2023-02-20 19:50:24 -03:00
2022-06-20 14:24:12 -03:00
2022-06-20 14:24:12 -03:00
2023-01-16 16:10:07 -03:00
2022-12-06 14:30:40 -03:00
2022-12-08 19:46:58 -03:00
2023-01-16 16:10:07 -03:00
2022-08-15 10:52:07 -03:00
2022-12-06 14:30:40 -03:00
2022-12-06 14:30:40 -03:00
2023-01-16 16:10:07 -03:00
2022-10-14 15:13:59 -03:00
2022-12-08 19:46:58 -03:00
2022-12-06 14:30:40 -03:00
2022-11-17 13:35:42 -03:00
2023-01-16 16:10:07 -03:00
2023-01-16 16:10:07 -03:00
2023-02-16 17:35:10 -03:00
2023-02-16 17:35:10 -03:00
2023-01-16 16:10:07 -03:00
2023-01-16 16:10:07 -03:00
2023-02-16 17:35:10 -03:00
2023-02-16 17:35:10 -03:00
2022-08-15 10:52:07 -03:00
2023-01-16 16:10:07 -03:00
2022-08-15 10:52:07 -03:00
2022-06-10 11:24:09 -03:00
2023-02-24 10:14:55 -03:00
2022-08-15 10:52:07 -03:00
2023-02-24 10:20:01 -03:00
2022-08-30 19:03:11 -03:00
2022-06-20 15:14:44 -03:00
2023-02-23 12:11:01 -03:00
2022-09-07 14:53:05 -03:00
2022-08-26 12:23:31 -03:00
2022-08-15 10:52:07 -03:00
2023-02-24 10:35:34 -03:00
2023-02-24 10:14:55 -03:00
2023-02-14 18:19:25 -03:00
2023-01-10 13:03:00 -03:00
2022-06-17 18:27:06 -03:00
2023-01-16 16:10:07 -03:00
2022-08-15 10:52:07 -03:00
2023-02-24 10:14:55 -03:00
2022-08-30 19:03:11 -03:00
2023-02-24 10:35:34 -03:00
2022-11-07 17:46:46 -03:00
2022-06-21 10:05:27 -03:00
2023-02-24 10:14:55 -03:00
2023-01-06 17:58:43 -03:00
2023-02-09 10:46:02 -03:00
2022-08-17 10:39:57 -07:00
2023-02-24 10:14:55 -03:00
2022-07-15 13:05:06 -03:00
2022-07-15 13:05:06 -03:00
2022-07-15 13:05:06 -03:00
2023-01-16 16:10:07 -03:00
2022-09-02 12:33:50 -03:00
2022-05-31 10:03:56 -03:00
2022-07-15 13:05:06 -03:00
2022-07-15 13:05:06 -03:00
2022-07-15 13:05:06 -03:00
2022-07-15 13:05:06 -03:00
2022-07-15 13:05:06 -03:00
2022-07-15 13:05:06 -03:00
2022-07-15 13:05:06 -03:00
2022-10-14 15:13:59 -03:00
2022-10-14 15:13:59 -03:00
2022-07-15 13:05:06 -03:00
2022-07-15 13:05:06 -03:00
2022-07-15 13:05:06 -03:00
2022-07-15 13:05:06 -03:00
2023-02-24 10:14:55 -03:00