Files
quantconnect--lean/Common/Orders/UpdateOrderRequest.cs
T
Aaron Janeiro Stone 643e8754ed Feature 5162 - LimitIfTouched Orders (#5164)
* Adds LimitIfTouched order.

TODO:
-- Add tests.
-- Add into existing regression algorithms.
-- Refactors (?)

* Fixes

- Remove unrequired space changes
- Fix EquityFillModel min/max limit price fill
- Add TriggerPrice for UpdateOrderRequest.

Quote info used w.r.t. comparing against Limit prices for LIT

FillModel.cs implementation is fixed to use quotes when comparing against set limit prices.
Also changes test implementations to assert which of quotes/trade-bars are being used

Reviewer-suggested fixes
------------
Merge remote-tracking branch 'origin/limiftouched' into limiftouched
Styling
Adds missing null check for quotebar
Styling
Adds missing null check for quotebar
Merge remote-tracking branch 'origin/limiftouched' into limiftouched
High/Low w.r.t. trigger price for determining if TriggerTouched changed to Current price
https://github.com/QuantConnect/Lean/pull/5164/files/0462ad668a5fe65e771122165f36c72d56b92df6#r569832380
fill fixes:
FillModel.cs: Fills exactly at the limit
EquityFillModel.cs: https://www1.interactivebrokers.com/en/index.php?f=608
Equity fill now uses quotebars
Revert - use new constructor which emulates former SubmitOrderRequest
Style changes
Reverts order model to original by means if new constructor
High/Low w.r.t. trigger price for determining if TriggerTouched changed to Current price
https://github.com/QuantConnect/Lean/pull/5164/files/0462ad668a5fe65e771122165f36c72d56b92df6#r569832380
fill fixes:
FillModel.cs: Fills exactly at the limit
EquityFillModel.cs: https://www1.interactivebrokers.com/en/index.php?f=608
Equity fill now uses quotebars
Revert - use new constructor which emulates former SubmitOrderRequest
Style changes
Reverts order model to original by means if new constructor
Merge commit 'bf4c96d2a055ea808fa4293662528c11a89b72c7'

* Suggested style fixes

* Review fixes
-------------------
- Suggested style fixes
- Changes LIT regression to better incorporate order modifications
- TODO: orderlisthash must be fixed
Fixed LIT regression algo
-----------------------
- Includes asserts in OnOrderEvent

* Fix OrderListHash

OrderListHash -> -292689487

* Re-adds quote nullchecks

* EquityFillModelTests fixes asserts

* Reordering FillModel.cs

* Fixes quote logic, adds methods in FillModel.cs

* Refactoring + LIT regression fixes
-- revert unneeded changes

* Fixes list hash

* Rebase -- catch up upstream

* OrderListHash fix

* Various fixes by reviewer

* Final requested changes

* tagged time -> utcinvariant

* Fixes listorderhash

* Time changed to UtcTime.ToString(DateFormat.US, CultureInfo.InvariantCulture)

* Adds Python LimitIfTouchedRegressionAlgorithm

* adds LimitIfTouchedRegressionAlgorithm.py

* adds LimitIfTouchedRegressionAlgorithm.py

* Minor changes to LIT regression algorithms

Co-authored-by: Martin Molinero <martin.molinero1@gmail.com>
2021-02-15 10:29:51 -03:00

100 lines
3.7 KiB
C#

/*
* QUANTCONNECT.COM - Democratizing Finance, Empowering Individuals.
* Lean Algorithmic Trading Engine v2.0. Copyright 2014 QuantConnect Corporation.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
using System;
using System.Collections.Generic;
using static QuantConnect.StringExtensions;
namespace QuantConnect.Orders
{
/// <summary>
/// Defines a request to update an order's values
/// </summary>
public class UpdateOrderRequest : OrderRequest
{
/// <summary>
/// Gets <see cref="Orders.OrderRequestType.Update"/>
/// </summary>
public override OrderRequestType OrderRequestType
{
get { return OrderRequestType.Update; }
}
/// <summary>
/// Gets the new quantity of the order, null to not change the quantity
/// </summary>
public decimal? Quantity { get; private set; }
/// <summary>
/// Gets the new limit price of the order, null to not change the limit price
/// </summary>
public decimal? LimitPrice { get; private set; }
/// <summary>
/// Gets the new stop price of the order, null to not change the stop price
/// </summary>
public decimal? StopPrice { get; private set; }
/// <summary>
/// Gets the new trigger price of the order, null to not change the trigger price
/// </summary>
public decimal? TriggerPrice { get; private set; }
/// <summary>
/// Initializes a new instance of the <see cref="UpdateOrderRequest"/> class
/// </summary>
/// <param name="time">The time the request was submitted</param>
/// <param name="orderId">The order id to be updated</param>
/// <param name="fields">The fields defining what should be updated</param>
public UpdateOrderRequest(DateTime time, int orderId, UpdateOrderFields fields)
: base(time, orderId, fields.Tag)
{
Quantity = fields.Quantity;
LimitPrice = fields.LimitPrice;
StopPrice = fields.StopPrice;
TriggerPrice = fields.TriggerPrice;
}
/// <summary>
/// Returns a string that represents the current object.
/// </summary>
/// <returns>
/// A string that represents the current object.
/// </returns>
/// <filterpriority>2</filterpriority>
public override string ToString()
{
var updates = new List<string>();
if (Quantity.HasValue)
{
updates.Add(Invariant($"Quantity: {Quantity.Value}"));
}
if (LimitPrice.HasValue)
{
updates.Add(Invariant($"LimitPrice: {LimitPrice.Value.SmartRounding()}"));
}
if (StopPrice.HasValue)
{
updates.Add(Invariant($"StopPrice: {StopPrice.Value.SmartRounding()}"));
}
if (TriggerPrice.HasValue)
{
updates.Add(Invariant($"TriggerPrice: {TriggerPrice.Value.SmartRounding()}"));
}
return Invariant($"{Time} UTC: Update Order: ({OrderId}) - {string.Join(", ", updates)} {Tag} Status: {Status}");
}
}
}