Files
quantconnect--lean/Algorithm.CSharp/PortfolioRebalanceOnSecurityChangesRegressionAlgorithm.cs
T
Alexandre Catarino fd76171604
Regression Tests / build (push) Has been cancelled
Benchmarks / build (push) Has been cancelled
Build & Test Lean / build (push) Has been cancelled
Research Regression Tests / build (push) Has been cancelled
Python Virtual Environments / build (push) Has been cancelled
Expire Instead of Clear Insights In Base PCM In OnSecuritiesChanged (#7251)
* Expire Instead of Clear Insights In Base PCM In OnSecuritiesChanged

* Fixes Regression Test

The regression was incorrect because `_removedSymbols` didn't retain the removed symbols from previous `OnSecuritiesChanged` calls, and the algorithm relances once per month. E.g. On day 1, SPY and FB were removed, on day 3 AAPL and IBM were removed and `removedSymbols` would only include AAPL and IBM.

We should hve fixed this problem before with:

```csharp
if (_removedSymbols == null) _removedSymbols = new List<Symbol>();
_removedSymbols.AddRange(changes.RemovedSecurities.Select(x => x.Symbol));
```

However the change to use Expire fixes the issue.

* Removes Unused List of Removed Symbols
2023-05-18 11:20:17 -03:00

150 lines
6.1 KiB
C#

/*
* QUANTCONNECT.COM - Democratizing Finance, Empowering Individuals.
* Lean Algorithmic Trading Engine v2.0. Copyright 2014 QuantConnect Corporation.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
using System;
using System.Collections.Generic;
using System.Linq;
using QuantConnect.Algorithm.Framework.Alphas;
using QuantConnect.Algorithm.Framework.Execution;
using QuantConnect.Algorithm.Framework.Portfolio;
using QuantConnect.Algorithm.Framework.Selection;
using QuantConnect.Orders;
using QuantConnect.Interfaces;
namespace QuantConnect.Algorithm.CSharp
{
/// <summary>
/// Regression algorithm testing portfolio construction model control over rebalancing,
/// when setting 'PortfolioConstructionModel.RebalanceOnSecurityChanges' to false, see GH 4075.
/// </summary>
public class PortfolioRebalanceOnSecurityChangesRegressionAlgorithm : QCAlgorithm, IRegressionAlgorithmDefinition
{
private int _generatedInsightsCount;
private Dictionary<Symbol, DateTime> _lastOrderFilled;
/// <summary>
/// Initialise the data and resolution required, as well as the cash and start-end dates for your algorithm. All algorithms must initialized.
/// </summary>
public override void Initialize()
{
UniverseSettings.Resolution = Resolution.Daily;
SetStartDate(2015, 1, 1);
SetEndDate(2017, 1, 1);
Settings.RebalancePortfolioOnSecurityChanges = false;
Settings.RebalancePortfolioOnInsightChanges = false;
SetUniverseSelection(new CustomUniverseSelectionModel("CustomUniverseSelectionModel",
time =>
{
if (new[] { DayOfWeek.Friday, DayOfWeek.Thursday }.Contains(time.DayOfWeek))
{
return new List<string> { "FB", "SPY" };
}
return new List<string> { "AAPL", "IBM" };
}
));
SetAlpha(new ConstantAlphaModel(InsightType.Price, InsightDirection.Up, TimeSpan.FromMinutes(20), 0.025, null));
SetPortfolioConstruction(new EqualWeightingPortfolioConstructionModel(
time => time.AddDays(30)));
SetExecution(new ImmediateExecutionModel());
_lastOrderFilled = new Dictionary<Symbol, DateTime>();
InsightsGenerated += (_, e) => _generatedInsightsCount += e.Insights.Length;
}
public override void OnOrderEvent(OrderEvent orderEvent)
{
if (orderEvent.Status == OrderStatus.Submitted)
{
DateTime lastOrderFilled;
if (_lastOrderFilled.TryGetValue(orderEvent.Symbol, out lastOrderFilled))
{
if (UtcTime - lastOrderFilled < TimeSpan.FromDays(30))
{
throw new Exception($"{UtcTime} {orderEvent.Symbol} {UtcTime - lastOrderFilled}");
}
}
_lastOrderFilled[orderEvent.Symbol] = UtcTime;
Debug($"{orderEvent}");
}
}
public override void OnEndOfAlgorithm()
{
if (Insights.Count == _generatedInsightsCount)
{
// The number of insights is modified by the Portfolio Construction Model,
// since it removes expired insights and insights from removed securities
throw new Exception($"The number of insights in the insight manager should be different of the number of all insights generated ({_generatedInsightsCount})");
}
}
/// <summary>
/// This is used by the regression test system to indicate if the open source Lean repository has the required data to run this algorithm.
/// </summary>
public bool CanRunLocally { get; } = true;
/// <summary>
/// This is used by the regression test system to indicate which languages this algorithm is written in.
/// </summary>
public Language[] Languages { get; } = { Language.CSharp };
/// <summary>
/// Data Points count of all timeslices of algorithm
/// </summary>
public long DataPoints => 5500;
/// <summary>
/// Data Points count of the algorithm history
/// </summary>
public int AlgorithmHistoryDataPoints => 0;
/// <summary>
/// This is used by the regression test system to indicate what the expected statistics are from running the algorithm
/// </summary>
public Dictionary<string, string> ExpectedStatistics => new Dictionary<string, string>
{
{"Total Trades", "74"},
{"Average Win", "2.37%"},
{"Average Loss", "-2.26%"},
{"Compounding Annual Return", "-4.832%"},
{"Drawdown", "29.700%"},
{"Expectancy", "-0.089"},
{"Net Profit", "-9.431%"},
{"Sharpe Ratio", "-0.176"},
{"Probabilistic Sharpe Ratio", "2.229%"},
{"Loss Rate", "56%"},
{"Win Rate", "44%"},
{"Profit-Loss Ratio", "1.05"},
{"Alpha", "-0.064"},
{"Beta", "0.768"},
{"Annual Standard Deviation", "0.139"},
{"Annual Variance", "0.019"},
{"Information Ratio", "-0.709"},
{"Tracking Error", "0.108"},
{"Treynor Ratio", "-0.032"},
{"Total Fees", "$262.70"},
{"Estimated Strategy Capacity", "$54000000.00"},
{"Lowest Capacity Asset", "IBM R735QTJ8XC9X"},
{"Portfolio Turnover", "5.05%"},
{"OrderListHash", "f8384f12fbcd59d3ad6e70bf86c97cbf"}
};
}
}