8bcd588602
Regression Tests / build (push) Has been cancelled
Python Virtual Environments / build (push) Has been cancelled
Benchmarks / build (push) Has been cancelled
Build & Test Lean / build (push) Has been cancelled
Research Regression Tests / build (push) Has been cancelled
* Adds Unit Tests The `LimitFill` method should not fill using `QuoteBar` or `Tick` with `TickType.Quote` type. Adds missing test for tick data (`TickType.Trade`). * Fixes EquityFillModel.FillModel Use `Tick` with `TickType.Trade` or `TradeBar` information to fill limit orders. * Update Regression Test Expected Statistics The regression tests changed because of different fills. The `ExtendedMarketTradingRegressionAlgorithm` has different number of trades because of an extra fill on the 4th order generated by TradeBar with a Low lower than than the QuoteBar.Ask Low: > 20230222 13:56:24.251 TRACE:: Log: Time: 10/10/2013 12:01:00 OrderID: 4 EventID: 2 Symbol: SPY Status: Filled Quantity: 10 FillQuantity: 10 FillPrice: 143.8998 USD > asset.Cache.GetData<QuoteBar>().ToString() "SPY: Bid: O: 144.2457 Bid: H: 144.2629 Bid: **L: 144.2457** Bid: C: 144.2629 Ask: O: 144.2543 Ask: H: 144.2889 Ask: **L: 144.2543** Ask: C: 144.2889 " > asset.Cache.GetData<TradeBar>().ToString() "SPY: O: 144.2543 H: 144.4532 **L: 143.4156** C: 144.2716 V: 75423" * Improves Tick Resolution Unit Test * Fixes Tick Resolution Case Handling `master` only considers the latest trade, missing possible fills in the batch of trades. * Adds Unit Test for Gap See https://github.com/QuantConnect/Lean/issues/963 * Addresses Fill Optimistic Assumption If we have a bar that gaps in our favor, we accept the limit price to avoid optimitic fills. * Fixes Regression Tests All regression tests with limit orders have worst performance after we remove the optimitic assumption, and use the limit price instead.
156 lines
6.2 KiB
C#
156 lines
6.2 KiB
C#
/*
|
|
* QUANTCONNECT.COM - Democratizing Finance, Empowering Individuals.
|
|
* Lean Algorithmic Trading Engine v2.0. Copyright 2014 QuantConnect Corporation.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using QuantConnect.Data;
|
|
using QuantConnect.Data.Market;
|
|
using QuantConnect.Interfaces;
|
|
|
|
namespace QuantConnect.Algorithm.CSharp
|
|
{
|
|
/// <summary>
|
|
/// This regression test algorithm reproduces issue https://github.com/QuantConnect/Lean/issues/4834
|
|
/// fixed in PR https://github.com/QuantConnect/Lean/pull/4836
|
|
/// Adjusted data of fill forward bars should use original scale factor
|
|
/// </summary>
|
|
public class ScaledFillForwardDataRegressionAlgorithm : QCAlgorithm, IRegressionAlgorithmDefinition
|
|
{
|
|
private TradeBar _lastRealBar;
|
|
private Symbol _twx;
|
|
public override void Initialize()
|
|
{
|
|
SetStartDate(2014, 6, 5);
|
|
SetEndDate(2014, 6, 9);
|
|
|
|
_twx = AddEquity("TWX", Resolution.Minute, extendedMarketHours: true).Symbol;
|
|
Schedule.On(DateRules.EveryDay(_twx), TimeRules.Every(TimeSpan.FromHours(1)), PlotPrice);
|
|
}
|
|
|
|
private void PlotPrice()
|
|
{
|
|
Plot($"{_twx}", "Ask", Securities[_twx].AskPrice);
|
|
Plot($"{_twx}", "Bid", Securities[_twx].BidPrice);
|
|
Plot($"{_twx}", "Price", Securities[_twx].Price);
|
|
Plot("Portfolio.TPV", "Value", Portfolio.TotalPortfolioValue);
|
|
}
|
|
|
|
public override void OnData(Slice data)
|
|
{
|
|
var current = data.Bars.FirstOrDefault().Value;
|
|
if (current != null)
|
|
{
|
|
if (Time == new DateTime(2014, 06, 09, 4, 1, 0) && !Portfolio.Invested)
|
|
{
|
|
if (!current.IsFillForward)
|
|
{
|
|
throw new Exception($"Was expecting a first fill forward bar {Time}");
|
|
}
|
|
|
|
// trade on the first bar after a factor price scale change. +10 so we fill ASAP. Limit so it fills in extended market hours
|
|
LimitOrder(_twx, 1000, _lastRealBar.Close + 10);
|
|
}
|
|
|
|
if (_lastRealBar == null || !current.IsFillForward)
|
|
{
|
|
_lastRealBar = current;
|
|
}
|
|
else if (_lastRealBar.Close != current.Close)
|
|
{
|
|
throw new Exception($"FillForwarded data point at {Time} was scaled. Actual: {current.Close}; Expected: {_lastRealBar.Close}");
|
|
}
|
|
}
|
|
}
|
|
|
|
public override void OnEndOfAlgorithm()
|
|
{
|
|
if (_lastRealBar == null)
|
|
{
|
|
throw new Exception($"Not all expected data points were received.");
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// This is used by the regression test system to indicate if the open source Lean repository has the required data to run this algorithm.
|
|
/// </summary>
|
|
public bool CanRunLocally { get; } = true;
|
|
|
|
/// <summary>
|
|
/// This is used by the regression test system to indicate which languages this algorithm is written in.
|
|
/// </summary>
|
|
public Language[] Languages { get; } = { Language.CSharp };
|
|
|
|
/// <summary>
|
|
/// Data Points count of all timeslices of algorithm
|
|
/// </summary>
|
|
public long DataPoints => 5507;
|
|
|
|
/// <summary>
|
|
/// Data Points count of the algorithm history
|
|
/// </summary>
|
|
public int AlgorithmHistoryDataPoints => 0;
|
|
|
|
/// <summary>
|
|
/// This is used by the regression test system to indicate what the expected statistics are from running the algorithm
|
|
/// </summary>
|
|
public Dictionary<string, string> ExpectedStatistics => new Dictionary<string, string>
|
|
{
|
|
{"Total Trades", "1"},
|
|
{"Average Win", "0%"},
|
|
{"Average Loss", "0%"},
|
|
{"Compounding Annual Return", "-99.928%"},
|
|
{"Drawdown", "9.700%"},
|
|
{"Expectancy", "0"},
|
|
{"Net Profit", "-9.142%"},
|
|
{"Sharpe Ratio", "-1.374"},
|
|
{"Probabilistic Sharpe Ratio", "1.216%"},
|
|
{"Loss Rate", "0%"},
|
|
{"Win Rate", "0%"},
|
|
{"Profit-Loss Ratio", "0"},
|
|
{"Alpha", "-2.46"},
|
|
{"Beta", "3.385"},
|
|
{"Annual Standard Deviation", "0.726"},
|
|
{"Annual Variance", "0.527"},
|
|
{"Information Ratio", "-1.984"},
|
|
{"Tracking Error", "0.72"},
|
|
{"Treynor Ratio", "-0.295"},
|
|
{"Total Fees", "$5.00"},
|
|
{"Estimated Strategy Capacity", "$23000.00"},
|
|
{"Lowest Capacity Asset", "AOL R735QTJ8XC9X"},
|
|
{"Fitness Score", "0.102"},
|
|
{"Kelly Criterion Estimate", "0"},
|
|
{"Kelly Criterion Probability Value", "0"},
|
|
{"Sortino Ratio", "79228162514264337593543950335"},
|
|
{"Return Over Maximum Drawdown", "-10.93"},
|
|
{"Portfolio Turnover", "0.201"},
|
|
{"Total Insights Generated", "0"},
|
|
{"Total Insights Closed", "0"},
|
|
{"Total Insights Analysis Completed", "0"},
|
|
{"Long Insight Count", "0"},
|
|
{"Short Insight Count", "0"},
|
|
{"Long/Short Ratio", "100%"},
|
|
{"Estimated Monthly Alpha Value", "$0"},
|
|
{"Total Accumulated Estimated Alpha Value", "$0"},
|
|
{"Mean Population Estimated Insight Value", "$0"},
|
|
{"Mean Population Direction", "0%"},
|
|
{"Mean Population Magnitude", "0%"},
|
|
{"Rolling Averaged Population Direction", "0%"},
|
|
{"Rolling Averaged Population Magnitude", "0%"},
|
|
{"OrderListHash", "de5fff32b0b169f3c02909ad31b7921c"}
|
|
};
|
|
}
|
|
}
|