Files
JosueNina eb12c8fa65 Seed runtime-added currency conversion rates immediately (#9568)
* Seed runtime-added currency conversion rates immediately

Fixes the spurious 'The conversion rate for <currency> is not available'
runtime error caused by a two-path seeding asymmetry.

The setup path (BaseSetupHandler.SetupCurrencyConversions) wires up a
currency's conversion feed AND seeds its rate via history/last-known-price
so the rate is non-zero right away. The runtime path
(UniverseSelection.EnsureCurrencyDataFeeds, invoked during universe
selection / SetCash mid-run) only created the conversion subscription and
left the rate at 0 until the first bar of the pair arrived. Any conversion
in that gap (classically a midnight scheduled SetHoldings firing before the
day's first conversion-pair bar) threw.

EnsureCurrencyDataFeeds now seeds newly introduced, still-zero-rate
conversion securities and calls cash.Update(), mirroring the setup path.
Seeding is gated behind a seedNewCurrencies flag (default true) so the
setup caller, which performs its own optionally white-listed seeding, can
opt out and not regress white-list semantics. SeedSecurities degrades
gracefully when no history/data is available, leaving the rate at 0 as
before, so live mode and no-history scenarios are safe.

Adds a regression test exercising the runtime path.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Make runtime currency seeding robust and fix regression expectation

CI failures from the runtime currency-conversion seeding change:

1. AlgorithmWarmupTests.WarmUpInternalSubscriptions threw
   ArgumentNullException because the new EnsureCurrencyDataFeeds seeding
   path ran GetLastKnownPrices in a stub where the conversion security
   lacked SymbolProperties. Pre-seeding is best-effort and must never
   break the algorithm, so wrap it in try/catch and degrade gracefully
   (leave the rate at 0, the pre-fix behavior) - matching the documented
   intent. The first conversion-pair bar still updates the rate.

2. ScheduledUniverseSelectionModelRegressionAlgorithm (C# + Python)
   asserted AlgorithmHistoryDataPoints == 0. The algorithm runtime-adds
   Forex pairs (EURGBP -> GBP cash) via scheduled universe selection;
   the fix now correctly seeds that runtime currency's conversion rate
   with a last-known-price history request (deterministically 50 points).
   The old 0 reflected the buggy unseeded behavior, so update the
   expectation to 50. No other statistics changed.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Seed runtime added currency conversion rates

* Seed currencies with no new conversion feed and dedup the seeding helper

---------

Co-authored-by: Martin-Molinero <Martin-Molinero@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-01 12:40:54 -03:00

159 lines
7.2 KiB
C#

/*
* QUANTCONNECT.COM - Democratizing Finance, Empowering Individuals.
* Lean Algorithmic Trading Engine v2.0. Copyright 2014 QuantConnect Corporation.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*/
using NUnit.Framework;
using QuantConnect.Data;
using QuantConnect.Data.UniverseSelection;
using QuantConnect.Util;
using QuantConnect.Data.Auxiliary;
using QuantConnect.Lean.Engine.Setup;
using QuantConnect.Lean.Engine.DataFeeds;
using QuantConnect.Lean.Engine.HistoricalData;
namespace QuantConnect.Tests.Engine.Setup
{
[TestFixture]
public class BaseSetupHandlerTests
{
[Test]
public void CurrencyConversionRateResolved()
{
// Unit test to prove that in the event that default resolution (minute) history request returns
// no data for our currency conversion that BaseSetupHandler will use a daily history request
// to determine the the conversion rate if possible.
// Setup history provider and algorithm
var historyProvider = new SubscriptionDataReaderHistoryProvider();
var algorithm = new BrokerageSetupHandlerTests.TestAlgorithm { UniverseSettings = { Resolution = Resolution.Minute } };
historyProvider.Initialize(new HistoryProviderInitializeParameters(
null,
null,
TestGlobals.DataProvider,
TestGlobals.DataCacheProvider,
TestGlobals.MapFileProvider,
TestGlobals.FactorFileProvider,
null,
false,
new DataPermissionManager(),
algorithm.ObjectStore,
algorithm.Settings));
algorithm.SetHistoryProvider(historyProvider);
// Pick a date range where we do NOT have BTCUSD minute data
algorithm.SetStartDate(2015, 1, 24);
algorithm.SetCash("USD", 0);
algorithm.SetCash("BTC", 10);
// Have BaseSetupHandler resolve the currency conversion
BaseSetupHandler.SetupCurrencyConversions(algorithm, algorithm.DataManager.UniverseSelection);
// Assert that our portfolio has some value and that value is bitcoin
Assert.IsTrue(algorithm.Portfolio.Cash > 0);
Assert.IsTrue(algorithm.Portfolio.CashBook["BTC"].ValueInAccountCurrency > 0);
}
[Test]
public void CurrencyConversionRateResolvedForWhiteListedCurrenciesOnly()
{
// Unit test to prove that in the event that default resolution (minute) history request returns
// no data for our currency conversion that BaseSetupHandler will use a daily history request
// to determine the the conversion rate if possible.
// Setup history provider and algorithm
var historyProvider = new SubscriptionDataReaderHistoryProvider();
var algorithm = new BrokerageSetupHandlerTests.TestAlgorithm { UniverseSettings = { Resolution = Resolution.Minute } };
historyProvider.Initialize(new HistoryProviderInitializeParameters(
null,
null,
TestGlobals.DataProvider,
TestGlobals.DataCacheProvider,
TestGlobals.MapFileProvider,
TestGlobals.FactorFileProvider,
null,
false,
new DataPermissionManager(),
algorithm.ObjectStore,
algorithm.Settings));
algorithm.SetHistoryProvider(historyProvider);
// Pick a date range where we do NOT have BTCUSD minute data
algorithm.SetStartDate(2015, 1, 24);
algorithm.SetCash("USD", 0);
algorithm.SetCash("BTC", 10);
algorithm.SetCash("EUR", 1000);
algorithm.SetCash("USDT", 1000);
// Have BaseSetupHandler resolve the currency conversion
BaseSetupHandler.SetupCurrencyConversions(algorithm, algorithm.DataManager.UniverseSelection, new[] { "BTC" });
// Bitcoin's conversion rate should be set
Assert.IsNotNull(algorithm.Portfolio.CashBook["BTC"].CurrencyConversion);
Assert.AreNotEqual(0, algorithm.Portfolio.CashBook["BTC"].ConversionRate);
// The remaining currencies should not have conversion rate set
Assert.AreEqual(0, algorithm.Portfolio.CashBook["EUR"].ConversionRate);
Assert.AreEqual(0, algorithm.Portfolio.CashBook["USDT"].ConversionRate);
}
[Test]
public void RuntimeCurrencyConversionRateIsSeeded()
{
// When a currency requiring a conversion feed is introduced at runtime (a universe adding a security
// whose quote currency isn't in the cashbook yet), the runtime path used to wire up the conversion
// subscription without seeding its price, leaving the rate at 0 until the first pair bar. After the fix
// it seeds the new conversion security right away, just like BaseSetupHandler does during setup.
var historyProvider = new SubscriptionDataReaderHistoryProvider();
var algorithm = new BrokerageSetupHandlerTests.TestAlgorithm { UniverseSettings = { Resolution = Resolution.Minute } };
historyProvider.Initialize(new HistoryProviderInitializeParameters(
null,
null,
TestGlobals.DataProvider,
TestGlobals.DataCacheProvider,
TestGlobals.MapFileProvider,
TestGlobals.FactorFileProvider,
null,
false,
new DataPermissionManager(),
algorithm.ObjectStore,
algorithm.Settings));
algorithm.SetHistoryProvider(historyProvider);
algorithm.SetStartDate(2015, 1, 24);
algorithm.SetCash("USD", 0);
// Run setup so the engine is in the post-setup (runtime) state
BaseSetupHandler.SetupCurrencyConversions(algorithm, algorithm.DataManager.UniverseSelection);
// Introduce a new currency at runtime and drive the runtime path that wires up its conversion feed
algorithm.SetCash("BTC", 10);
algorithm.DataManager.UniverseSelection.EnsureCurrencyDataFeeds(SecurityChanges.None);
// The new currency should already have a non-zero rate, without waiting for a live bar
Assert.IsNotNull(algorithm.Portfolio.CashBook["BTC"].CurrencyConversion);
Assert.AreNotEqual(0, algorithm.Portfolio.CashBook["BTC"].ConversionRate);
Assert.IsTrue(algorithm.Portfolio.CashBook["BTC"].ValueInAccountCurrency > 0);
Assert.DoesNotThrow(() => algorithm.Portfolio.CashBook.ConvertToAccountCurrency(10, "BTC"));
}
}
}